<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/gitlab/gitlab-ce.git/spec/models/hooks, branch docs-pages-force-https</title>
<subtitle>gitlab.com: gitlab-org/gitlab-ce.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/'/>
<entry>
<title>Add # frozen_string_literal to spec/models</title>
<updated>2019-04-01T01:37:54+00:00</updated>
<author>
<name>Thong Kuah</name>
<email>tkuah@gitlab.com</email>
</author>
<published>2019-03-30T07:23:56+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=a2cfc150cec677b27728a4758e5e40fff5b4c284'/>
<id>a2cfc150cec677b27728a4758e5e40fff5b4c284</id>
<content type='text'>
Adds `# frozen_string_literal: true` to spec/models ruby files
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Adds `# frozen_string_literal: true` to spec/models ruby files
</pre>
</div>
</content>
</entry>
<entry>
<title>Migrate sensitive web hook data in the background</title>
<updated>2018-10-01T14:34:16+00:00</updated>
<author>
<name>Nick Thomas</name>
<email>nick@gitlab.com</email>
</author>
<published>2018-09-14T17:21:28+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=466371a06c6d4d5b206b6fc2b09d7a44d80e8679'/>
<id>466371a06c6d4d5b206b6fc2b09d7a44d80e8679</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'filter-web-hooks-by-branch' into 'master'</title>
<updated>2018-09-05T13:39:41+00:00</updated>
<author>
<name>Dmitriy Zaporozhets</name>
<email>dmitriy.zaporozhets@gmail.com</email>
</author>
<published>2018-09-05T13:39:41+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=464b0de1acfc9383a551a05efa8c8a705c8bf70c'/>
<id>464b0de1acfc9383a551a05efa8c8a705c8bf70c</id>
<content type='text'>
Filter web hooks by branch

See merge request gitlab-org/gitlab-ce!19513</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Filter web hooks by branch

See merge request gitlab-org/gitlab-ce!19513</pre>
</div>
</content>
</entry>
<entry>
<title>Refactor: move active hook filter to TriggerableHooks</title>
<updated>2018-09-05T11:58:52+00:00</updated>
<author>
<name>Duana Saskia</name>
<email>starkcoffee@users.noreply.github.com</email>
</author>
<published>2018-09-01T15:55:06+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=9d742e61a79dcc85589598259e2fdac030b7ac00'/>
<id>9d742e61a79dcc85589598259e2fdac030b7ac00</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Whitelist existing destroy_all offenses</title>
<updated>2018-08-16T15:29:37+00:00</updated>
<author>
<name>Yorick Peterse</name>
<email>yorickpeterse@gmail.com</email>
</author>
<published>2018-08-16T12:46:40+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=9606dbbb033567de9831a8cdea0e56236e7d2eb2'/>
<id>9606dbbb033567de9831a8cdea0e56236e7d2eb2</id>
<content type='text'>
This whitelists all existing places where we use "destroy_all".
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This whitelists all existing places where we use "destroy_all".
</pre>
</div>
</content>
</entry>
<entry>
<title>Filter project hooks by branch</title>
<updated>2018-08-13T11:20:58+00:00</updated>
<author>
<name>Duana Saskia</name>
<email>starkcoffee@users.noreply.github.com</email>
</author>
<published>2018-06-07T07:35:17+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=ece6a1ea6ecffdbde5ff7d663f1ad1eb74f78aa6'/>
<id>ece6a1ea6ecffdbde5ff7d663f1ad1eb74f78aa6</id>
<content type='text'>
Allow specificying a branch filter for a project hook and only trigger
a project hook if either the branch filter is blank or the branch matches.
Only supported for push_events for now.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Allow specificying a branch filter for a project hook and only trigger
a project hook if either the branch filter is blank or the branch matches.
Only supported for push_events for now.
</pre>
</div>
</content>
</entry>
<entry>
<title>Resolve "Rename the `Master` role to `Maintainer`" Backend</title>
<updated>2018-07-11T14:36:08+00:00</updated>
<author>
<name>Mark Chao</name>
<email>mchao@gitlab.com</email>
</author>
<published>2018-07-11T14:36:08+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=a63bce1a4b55bc6cbafb9dec12d33028521489e9'/>
<id>a63bce1a4b55bc6cbafb9dec12d33028521489e9</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Fixed pagination of web hook logs</title>
<updated>2018-07-03T12:24:17+00:00</updated>
<author>
<name>Yorick Peterse</name>
<email>yorickpeterse@gmail.com</email>
</author>
<published>2018-06-28T13:34:31+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=f30089075fabfbac45c6382c0a2717bbb682734e'/>
<id>f30089075fabfbac45c6382c0a2717bbb682734e</id>
<content type='text'>
For reasons unknown, the logs of a web hook were paginated in memory.
This would result in the "Edit" page of a web hook timing out once it
has more than a few thousand log entries.

This commit makes the following changes:

1. We use LIMIT/OFFSET to paginate the data, instead of doing this in
   memory.

2. We limit the logs to the last two days, just like the documentation
   says (instead of retrieving everything).

3. We change the indexes on "web_hook_logs" so the query to get the data
   can perform a backwards index scan, without the need for a Filter.

These changes combined ensure that Projects::HooksController#edit no
longer times out.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
For reasons unknown, the logs of a web hook were paginated in memory.
This would result in the "Edit" page of a web hook timing out once it
has more than a few thousand log entries.

This commit makes the following changes:

1. We use LIMIT/OFFSET to paginate the data, instead of doing this in
   memory.

2. We limit the logs to the last two days, just like the documentation
   says (instead of retrieving everything).

3. We change the indexes on "web_hook_logs" so the query to get the data
   can perform a backwards index scan, without the need for a Filter.

These changes combined ensure that Projects::HooksController#edit no
longer times out.
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'feature/merge-request-system-hook' into 'master'</title>
<updated>2018-01-18T11:37:16+00:00</updated>
<author>
<name>Douwe Maan</name>
<email>douwe@gitlab.com</email>
</author>
<published>2018-01-18T11:37:16+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=8e9c073a146f655cea2fd13f259bd68dc2c37259'/>
<id>8e9c073a146f655cea2fd13f259bd68dc2c37259</id>
<content type='text'>
System hooks for Merge Requests

See merge request gitlab-org/gitlab-ce!14387</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
System hooks for Merge Requests

See merge request gitlab-org/gitlab-ce!14387</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch '41293-fix-command-injection-vulnerability-on-system_hook_push-queue-through-web-hook' into 'security-10-3'</title>
<updated>2018-01-17T01:04:51+00:00</updated>
<author>
<name>Robert Speicher</name>
<email>robert@gitlab.com</email>
</author>
<published>2018-01-05T21:36:18+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=791ca43f3f8f12451ee1e70efc90f5d82347af93'/>
<id>791ca43f3f8f12451ee1e70efc90f5d82347af93</id>
<content type='text'>
Don't allow line breaks on HTTP headers

See merge request gitlab/gitlabhq!2277

(cherry picked from commit 7fc0a6fc096768a5604d6dd24d7d952e53300c82)

073b8f9c Don't allow line breaks on HTTP headers
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Don't allow line breaks on HTTP headers

See merge request gitlab/gitlabhq!2277

(cherry picked from commit 7fc0a6fc096768a5604d6dd24d7d952e53300c82)

073b8f9c Don't allow line breaks on HTTP headers
</pre>
</div>
</content>
</entry>
</feed>
