delta/gitlab/gitlab-ce.git/spec/models/cycle_analytics, branch absorb-gitlab-git gitlab.com: gitlab-org/gitlab-ce.git fixed newline 2016-10-12T12:30:49+00:00 James Lopez james@jameslopez.es 2016-10-12T12:30:49+00:00 42ba19f339a63a1e49a40fd4df9c75470ec71f25 






Ignore deployment for statistics in Cycle Analytics, except in staging and production stages
2016-10-12T10:32:25+00:00

James Lopez
james@jameslopez.es

2016-10-11T10:58:56+00:00

2b37f040b612303b714ec8cee0b482427e7c2b3c

Also, updated specs and docs.





Also, updated specs and docs.







Fix the "Commits" section of the cycle analytics summary.
2016-09-26T13:08:40+00:00

Timothy Andrew
mail@timothyandrew.net

2016-09-26T04:33:57+00:00

c0ecef79fe936b9e71384f8d951fc5503f26f4a7

- The commit count was capped at 10, due to
  `Gitlab::Git::Repository#log` enforcing a limit, with the default set
  to 10.

- Reimplement a small portion of this `log` function to get just the
  data we need.





- The commit count was capped at 10, due to
  `Gitlab::Git::Repository#log` enforcing a limit, with the default set
  to 10.

- Reimplement a small portion of this `log` function to get just the
  data we need.







Implement a second round of review comments from @DouweM.
2016-09-20T19:17:37+00:00

Timothy Andrew
mail@timothyandrew.net

2016-09-20T19:17:37+00:00

918e589c2b29c18d9fe3a8e6c93a3f490c86beb1

- Don't use `TableReferences` - using `.arel_table` is shorter!
- Move some database-related code to `Gitlab::Database`
- Remove the `MergeRequest#issues_closed` and
  `Issue#closed_by_merge_requests`  associations. They were either
  shadowing or were too similar to existing methods. They are not being
  used anywhere, so it's better to remove them to reduce confusion.
- Use Rails 3-style validations
- Index for `MergeRequest::Metrics#first_deployed_to_production_at`
- Only include `CycleAnalyticsHelpers::TestGeneration` for specs that
  need it.
- Other minor refactorings.





- Don't use `TableReferences` - using `.arel_table` is shorter!
- Move some database-related code to `Gitlab::Database`
- Remove the `MergeRequest#issues_closed` and
  `Issue#closed_by_merge_requests`  associations. They were either
  shadowing or were too similar to existing methods. They are not being
  used anywhere, so it's better to remove them to reduce confusion.
- Use Rails 3-style validations
- Index for `MergeRequest::Metrics#first_deployed_to_production_at`
- Only include `CycleAnalyticsHelpers::TestGeneration` for specs that
  need it.
- Other minor refactorings.







Fix rubocop spec.
2016-09-20T12:56:31+00:00

Timothy Andrew
mail@timothyandrew.net

2016-09-20T12:51:59+00:00

231a9f5b8788aa0bbb2fa304f8b937f7c09fcee1

And `scss_lint`





And `scss_lint`







Fix all cycle analytics specs.
2016-09-20T07:53:14+00:00

Timothy Andrew
mail@timothyandrew.net

2016-09-20T05:47:36+00:00

d0e101e997347b0b52d4ef3a945a0f26571546a2

A number of failures were introduced due to performance
improvements (like pre-calculating metrics).





A number of failures were introduced due to performance
improvements (like pre-calculating metrics).







Test the `CycleAnalytics::Summary` model.
2016-09-20T07:53:14+00:00

Timothy Andrew
mail@timothyandrew.net

2016-09-20T04:24:42+00:00

204419e9e9b01977cbeac34b1a8385239b1455aa












Consolidate all cycle analytics helper methods.
2016-09-07T08:59:12+00:00

Timothy Andrew
mail@timothyandrew.net

2016-09-07T08:59:12+00:00

0a767f7b618161278b66f7e1d842a51c8cab37b3

1. Move the test generation to `CycleAnalyticsHelpers::TestGeneration`

2. Move all helper methods (previously placed in each individual spec
   file) to `CycleAnalyticsHelpers`





1. Move the test generation to `CycleAnalyticsHelpers::TestGeneration`

2. Move all helper methods (previously placed in each individual spec
   file) to `CycleAnalyticsHelpers`







Test the `test` cycle analytics phase.
2016-09-07T08:41:24+00:00

Timothy Andrew
mail@timothyandrew.net

2016-09-07T08:41:24+00:00

9cff3f8f5282633fd0c5920e3b6d277415ae9000












Test the `production` cycle analytics phase.
2016-09-07T07:36:58+00:00

Timothy Andrew
mail@timothyandrew.net

2016-09-07T07:36:58+00:00

de483c6834153b75403633b42f20b0c85eae35e7

Add a `before_end_fn` option to the code that generates cycle analytics
specs. `before_end_fn` is called before the end conditions are. Used for
data setup that needs to be called after the start conditions and before
the end conditions.





Add a `before_end_fn` option to the code that generates cycle analytics
specs. `before_end_fn` is called before the end conditions are. Used for
data setup that needs to be called after the start conditions and before
the end conditions.