delta/gitlab/gitlab-ce.git/spec/models/cycle_analytics, branch 25264-ref-commit

Merge branch 'jej-fix-missing-access-check-on-issues' into 'security'

2016-11-29T00:25:46+00:00

Fix missing access checks on issue lookup using IssuableFinder

Split from !2024 to partially solve https://gitlab.com/gitlab-org/gitlab-ce/issues/23867

:warning: - Potentially untested
:bomb: - No test coverage
:traffic_light: - Test coverage of some sort exists (a test failed when error raised)
:vertical_traffic_light: - Test coverage of return value (a test failed when nil used)
:white_check_mark: - Permissions check tested

- [x] :white_check_mark: app/controllers/projects/branches_controller.rb:39
  - `before_action :authorize_push_code!` helpes limit/prevent exploitation. Always checks for reporter access so fine with
    confidential issues, issues only visible to team, etc.
- [x] :traffic_light: app/models/cycle_analytics/summary.rb:9 [`.count`]
- [x] :white_check_mark: app/controllers/projects/todos_controller.rb:19

- [x] Potential double render in app/controllers/projects/todos_controller.rb

- https://dev.gitlab.org/gitlab/gitlabhq/merge_requests/2024/diffs#cedccb227af9bfdf88802767cb58d43c2b977439_24_24

See merge request !2030

fixed newline

2016-10-12T12:30:49+00:00

Ignore deployment for statistics in Cycle Analytics, except in staging and production stages

2016-10-12T10:32:25+00:00

Also, updated specs and docs.

Fix the "Commits" section of the cycle analytics summary.

2016-09-26T13:08:40+00:00

- The commit count was capped at 10, due to
  `Gitlab::Git::Repository#log` enforcing a limit, with the default set
  to 10.

- Reimplement a small portion of this `log` function to get just the
  data we need.

Implement a second round of review comments from @DouweM.

2016-09-20T19:17:37+00:00

- Don't use `TableReferences` - using `.arel_table` is shorter!
- Move some database-related code to `Gitlab::Database`
- Remove the `MergeRequest#issues_closed` and
  `Issue#closed_by_merge_requests`  associations. They were either
  shadowing or were too similar to existing methods. They are not being
  used anywhere, so it's better to remove them to reduce confusion.
- Use Rails 3-style validations
- Index for `MergeRequest::Metrics#first_deployed_to_production_at`
- Only include `CycleAnalyticsHelpers::TestGeneration` for specs that
  need it.
- Other minor refactorings.

Fix rubocop spec.

2016-09-20T12:56:31+00:00

And `scss_lint`

Fix all cycle analytics specs.

2016-09-20T07:53:14+00:00

A number of failures were introduced due to performance
improvements (like pre-calculating metrics).

Test the `CycleAnalytics::Summary` model.

2016-09-20T07:53:14+00:00

Consolidate all cycle analytics helper methods.

2016-09-07T08:59:12+00:00

1. Move the test generation to `CycleAnalyticsHelpers::TestGeneration`

2. Move all helper methods (previously placed in each individual spec
   file) to `CycleAnalyticsHelpers`

Test the `test` cycle analytics phase.

2016-09-07T08:41:24+00:00