delta/gitlab/gitlab-ce.git/spec/models/cycle_analytics/code_spec.rb, branch sql-buckets gitlab.com: gitlab-org/gitlab-ce.git Adapt cycle analytics spec helper and cycle analytics usage data spec 2018-03-01T16:43:26+00:00 Tiago Botelho tiagonbotelho@hotmail.com 2018-02-21T12:13:56+00:00 522f4b2c6a0a1fe1e93d7bc2f9fe5290fccba4f9 






Remove superfluous type defs in specs
2017-07-27T12:31:52+00:00

Keifer Furzland
kfrz.code@gmail.com

2017-06-29T04:13:10+00:00

7e113b6824628a7e82e93965300f2ce3b9aadf4b

Signed-off-by: Rémy Coutable <remy@rymai.me>





Signed-off-by: Rémy Coutable <remy@rymai.me>







Reduce the number of loops that Cycle Analytics specs use
2017-02-01T21:14:20+00:00

Robert Speicher
rspeicher@gmail.com

2017-01-29T22:53:48+00:00

dd1c410ea4478400e2650f4102726f2ab1a906bd

See https://gitlab.com/gitlab-org/gitlab-ce/issues/27402





See https://gitlab.com/gitlab-org/gitlab-ce/issues/27402







Use `:empty_project` where possible in model specs
2017-01-26T22:44:59+00:00

Robert Speicher
rspeicher@gmail.com

2017-01-26T22:44:58+00:00

fcb37542e746d69f20094e2918e498564bbcd863












refactor fetcher and fixed specs
2017-01-17T10:32:55+00:00

James Lopez
james@jameslopez.es

2016-12-01T11:44:35+00:00

69ecd951a9e0acbc31f0a4b9b02e8a1981ceff1e












more refactoring and fixing old specs
2017-01-17T10:32:54+00:00

James Lopez
james@jameslopez.es

2016-11-22T13:29:25+00:00

02e1e4819234662faddd7d8eb5c54d9bfdf9e7e6












Merge branch 'jej-fix-missing-access-check-on-issues' into 'security'
2016-11-29T00:25:46+00:00

Douwe Maan
douwe@gitlab.com

2016-11-18T13:51:52+00:00

6d37fe952b5679d7586eaa569d0488dbb92032fe

Fix missing access checks on issue lookup using IssuableFinder

Split from !2024 to partially solve https://gitlab.com/gitlab-org/gitlab-ce/issues/23867

:warning: - Potentially untested
:bomb: - No test coverage
:traffic_light: - Test coverage of some sort exists (a test failed when error raised)
:vertical_traffic_light: - Test coverage of return value (a test failed when nil used)
:white_check_mark: - Permissions check tested

- [x] :white_check_mark: app/controllers/projects/branches_controller.rb:39
  - `before_action :authorize_push_code!` helpes limit/prevent exploitation. Always checks for reporter access so fine with
    confidential issues, issues only visible to team, etc.
- [x] :traffic_light: app/models/cycle_analytics/summary.rb:9 [`.count`]
- [x] :white_check_mark: app/controllers/projects/todos_controller.rb:19

- [x] Potential double render in app/controllers/projects/todos_controller.rb

- https://dev.gitlab.org/gitlab/gitlabhq/merge_requests/2024/diffs#cedccb227af9bfdf88802767cb58d43c2b977439_24_24

See merge request !2030





Fix missing access checks on issue lookup using IssuableFinder

Split from !2024 to partially solve https://gitlab.com/gitlab-org/gitlab-ce/issues/23867

:warning: - Potentially untested
:bomb: - No test coverage
:traffic_light: - Test coverage of some sort exists (a test failed when error raised)
:vertical_traffic_light: - Test coverage of return value (a test failed when nil used)
:white_check_mark: - Permissions check tested

- [x] :white_check_mark: app/controllers/projects/branches_controller.rb:39
  - `before_action :authorize_push_code!` helpes limit/prevent exploitation. Always checks for reporter access so fine with
    confidential issues, issues only visible to team, etc.
- [x] :traffic_light: app/models/cycle_analytics/summary.rb:9 [`.count`]
- [x] :white_check_mark: app/controllers/projects/todos_controller.rb:19

- [x] Potential double render in app/controllers/projects/todos_controller.rb

- https://dev.gitlab.org/gitlab/gitlabhq/merge_requests/2024/diffs#cedccb227af9bfdf88802767cb58d43c2b977439_24_24

See merge request !2030







Ignore deployment for statistics in Cycle Analytics, except in staging and production stages
2016-10-12T10:32:25+00:00

James Lopez
james@jameslopez.es

2016-10-11T10:58:56+00:00

2b37f040b612303b714ec8cee0b482427e7c2b3c

Also, updated specs and docs.





Also, updated specs and docs.







Implement a second round of review comments from @DouweM.
2016-09-20T19:17:37+00:00

Timothy Andrew
mail@timothyandrew.net

2016-09-20T19:17:37+00:00

918e589c2b29c18d9fe3a8e6c93a3f490c86beb1

- Don't use `TableReferences` - using `.arel_table` is shorter!
- Move some database-related code to `Gitlab::Database`
- Remove the `MergeRequest#issues_closed` and
  `Issue#closed_by_merge_requests`  associations. They were either
  shadowing or were too similar to existing methods. They are not being
  used anywhere, so it's better to remove them to reduce confusion.
- Use Rails 3-style validations
- Index for `MergeRequest::Metrics#first_deployed_to_production_at`
- Only include `CycleAnalyticsHelpers::TestGeneration` for specs that
  need it.
- Other minor refactorings.





- Don't use `TableReferences` - using `.arel_table` is shorter!
- Move some database-related code to `Gitlab::Database`
- Remove the `MergeRequest#issues_closed` and
  `Issue#closed_by_merge_requests`  associations. They were either
  shadowing or were too similar to existing methods. They are not being
  used anywhere, so it's better to remove them to reduce confusion.
- Use Rails 3-style validations
- Index for `MergeRequest::Metrics#first_deployed_to_production_at`
- Only include `CycleAnalyticsHelpers::TestGeneration` for specs that
  need it.
- Other minor refactorings.







Fix all cycle analytics specs.
2016-09-20T07:53:14+00:00

Timothy Andrew
mail@timothyandrew.net

2016-09-20T05:47:36+00:00

d0e101e997347b0b52d4ef3a945a0f26571546a2

A number of failures were introduced due to performance
improvements (like pre-calculating metrics).





A number of failures were introduced due to performance
improvements (like pre-calculating metrics).