delta/gitlab/gitlab-ce.git/spec/models/concerns, branch commit-message-scroll

rename Statuseable to HasStatus

2016-08-25T02:55:32+00:00

Further refactor and syntax fixes.

2016-08-15T22:20:57+00:00

Refactored AkismetHelper into AkismetService and cleaned up `Spammable`

2016-08-15T18:18:15+00:00

- Refactored SpamCheckService into SpamService

Allow `Issue` to be submitted as spam

2016-08-15T18:18:15+00:00

- Added controller actions as reusable concerns
- Added controller tests

Allow `SpamLog` to be submitted as ham

2016-08-15T18:18:15+00:00

- Added `submitted_as_ham` to `SpamLog` to mark which logs have been submitted to Akismet.
- Added routes and controller action.

Refactored spam related code even further

2016-08-15T18:18:15+00:00

- Removed unnecessary column from `SpamLog`
- Moved creation of SpamLogs out of its own service and into SpamCheckService
- Simplified code in SpamCheckService.
- Moved move spam related code into Spammable concern

Complete refactor of the `Spammable` concern and tests:

2016-08-15T18:18:15+00:00

- Merged `AkismetSubmittable` into `Spammable`
- Clean up `SpamCheckService`
- Added tests for `Spammable`
- Added submit (ham or spam) options to `AkismetHelper`

adds second batch of tests changed to active tense

2016-08-09T14:11:39+00:00

Added concern for a faster "cache_key" method

2016-08-08T14:49:22+00:00

This concern provides an optimized/simplified version of the "cache_key"
method. This method is about 9 times faster than the default "cache_key"
method.

The produced cache keys _are_ different from the previous ones but this
is worth the performance improvement. To showcase this I set up a
benchmark (using benchmark-ips) that compares FasterCacheKeys#cache_key
with the regular cache_key. The output of this benchmark was:

    Calculating -------------------------------------
               cache_key     4.825k i/100ms
          cache_key_fast    21.723k i/100ms
    -------------------------------------------------
               cache_key     59.422k (± 7.2%) i/s -    299.150k
          cache_key_fast    543.243k (± 9.2%) i/s -      2.694M

    Comparison:
          cache_key_fast:   543243.4 i/s
               cache_key:    59422.0 i/s - 9.14x slower

To see the impact on real code I applied these changes and benchmarked
Issue#referenced_merge_requests. For an issue referencing 10 merge
requests these changes shaved off between 40 and 60 milliseconds.

Method for returning issues readable by a user

2016-07-29T10:51:18+00:00

The method Ability.issues_readable_by_user takes a list of users and an
optional user and returns an Array of issues readable by said user. This
method in turn is used by
Banzai::ReferenceParser::IssueParser#nodes_visible_to_user so this
method no longer needs to get all the available abilities just to check
if a user has the "read_issue" ability.

To test this I benchmarked an issue with 222 comments on my development
environment. Using these changes the time spent in nodes_visible_to_user
was reduced from around 120 ms to around 40 ms.