<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/gitlab/gitlab-ce.git/spec/models/commit_spec.rb, branch frozen_string_lib_2</title>
<subtitle>gitlab.com: gitlab-org/gitlab-ce.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/'/>
<entry>
<title>Fix inline rendering of SVGs from current repo</title>
<updated>2019-08-01T22:34:20+00:00</updated>
<author>
<name>Heinrich Lee Yu</name>
<email>heinrich@gitlab.com</email>
</author>
<published>2019-07-31T18:53:33+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=3b1da9be250560c9a2e4ca69c6fa89e8b36f01e1'/>
<id>3b1da9be250560c9a2e4ca69c6fa89e8b36f01e1</id>
<content type='text'>
Changes generated URL to raw instead of blob
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Changes generated URL to raw instead of blob
</pre>
</div>
</content>
</entry>
<entry>
<title>Speed up commit loads by disabling BatchLoader replace_methods</title>
<updated>2019-06-13T21:21:23+00:00</updated>
<author>
<name>Stan Hu</name>
<email>stanhu@gmail.com</email>
</author>
<published>2019-06-13T20:50:27+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=18020f00f880fd849800624e08e87d0a5aa5111f'/>
<id>18020f00f880fd849800624e08e87d0a5aa5111f</id>
<content type='text'>
We've seen a significant performance penalty when using
`BatchLoader#__replace_with!`. This defines methods on the batch loader
that proxy to the 'real' object using send. The alternative is
`method_missing`, which is slower.  However, we've noticed that
`method_missing` can be faster if:

1. The objects being loaded have a large interface.
2. We don't call too many methods on the loaded object.

In production, we've seen the rendering times of the merge request
widget increase as a result of loading commit data. BatchLoader attempts
to call replace_methods on the lazy object, but this has a significant
performance penalty. Disabling this mode
(https://github.com/exAspArk/batch-loader/pull/45) appears to cut load
times by about 50% for MergeRequestsController#show.

Relates to https://gitlab.com/gitlab-com/gl-infra/infrastructure/issues/6941
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
We've seen a significant performance penalty when using
`BatchLoader#__replace_with!`. This defines methods on the batch loader
that proxy to the 'real' object using send. The alternative is
`method_missing`, which is slower.  However, we've noticed that
`method_missing` can be faster if:

1. The objects being loaded have a large interface.
2. We don't call too many methods on the loaded object.

In production, we've seen the rendering times of the merge request
widget increase as a result of loading commit data. BatchLoader attempts
to call replace_methods on the lazy object, but this has a significant
performance penalty. Disabling this mode
(https://github.com/exAspArk/batch-loader/pull/45) appears to cut load
times by about 50% for MergeRequestsController#show.

Relates to https://gitlab.com/gitlab-com/gl-infra/infrastructure/issues/6941
</pre>
</div>
</content>
</entry>
<entry>
<title>Add # frozen_string_literal to spec/models</title>
<updated>2019-04-01T01:37:54+00:00</updated>
<author>
<name>Thong Kuah</name>
<email>tkuah@gitlab.com</email>
</author>
<published>2019-03-30T07:23:56+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=a2cfc150cec677b27728a4758e5e40fff5b4c284'/>
<id>a2cfc150cec677b27728a4758e5e40fff5b4c284</id>
<content type='text'>
Adds `# frozen_string_literal: true` to spec/models ruby files
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Adds `# frozen_string_literal: true` to spec/models ruby files
</pre>
</div>
</content>
</entry>
<entry>
<title>Add back Rugged support for retrieving a commit tree entry</title>
<updated>2019-03-09T00:01:59+00:00</updated>
<author>
<name>Stan Hu</name>
<email>stanhu@gmail.com</email>
</author>
<published>2019-03-07T21:53:22+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=4ee08fd1f71caca88243833f08c2b1a59bd0fa9e'/>
<id>4ee08fd1f71caca88243833f08c2b1a59bd0fa9e</id>
<content type='text'>
This brings back some of the changes in
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/20176/diffs.

We discovered another N+1 that hits Gitaly `TreeEntry` via the
`RelativeLinkFilter`:
https://gitlab.com/gitlab-org/gitlab-ce/issues/58657. When a blob is
loaded with many relative links, `TreeEntry` is called for each link to
scan the URI type.

There are multiple paths that hit Gitaly `TreeEntry`, and
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/25706 did not
cover all cases. This commit covers another common use case.

For users using Gitaly on top of NFS, accessing the Git data directly
via Rugged may be faster than going through than Gitaly. This merge
request introduces the feature flag `rugged_commit_tree_entry` to
activate the Rugged method.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This brings back some of the changes in
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/20176/diffs.

We discovered another N+1 that hits Gitaly `TreeEntry` via the
`RelativeLinkFilter`:
https://gitlab.com/gitlab-org/gitlab-ce/issues/58657. When a blob is
loaded with many relative links, `TreeEntry` is called for each link to
scan the URI type.

There are multiple paths that hit Gitaly `TreeEntry`, and
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/25706 did not
cover all cases. This commit covers another common use case.

For users using Gitaly on top of NFS, accessing the Git data directly
via Rugged may be faster than going through than Gitaly. This merge
request introduces the feature flag `rugged_commit_tree_entry` to
activate the Rugged method.
</pre>
</div>
</content>
</entry>
<entry>
<title>[master] Pipelines section is available to unauthorized users</title>
<updated>2019-01-31T15:52:50+00:00</updated>
<author>
<name>Kamil Trzciński</name>
<email>kamil@gitlab.com</email>
</author>
<published>2019-01-28T12:12:30+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=d4c7214799586a9b5063b0ea5b4327bbffe1170f'/>
<id>d4c7214799586a9b5063b0ea5b4327bbffe1170f</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Truncate merge request titles with periods instead of ellipsis</title>
<updated>2018-12-07T05:51:51+00:00</updated>
<author>
<name>Stan Hu</name>
<email>stanhu@gmail.com</email>
</author>
<published>2018-12-04T17:59:48+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=7d18c4d23637f52fa0fdc3028223f8cd1ec1e072'/>
<id>7d18c4d23637f52fa0fdc3028223f8cd1ec1e072</id>
<content type='text'>
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/54862
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/54862
</pre>
</div>
</content>
</entry>
<entry>
<title>Match users better by their private commit email</title>
<updated>2018-11-19T12:45:07+00:00</updated>
<author>
<name>Nick Thomas</name>
<email>nick@gitlab.com</email>
</author>
<published>2018-11-14T18:42:36+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=59c4fb4ecb3aa81ea73a5fe75528ef969c28fa9d'/>
<id>59c4fb4ecb3aa81ea73a5fe75528ef969c28fa9d</id>
<content type='text'>
Private commit emails were introduced in !22560, but some parts of
GitLab were not updated to take account of them. This commit adds
support in places that were missed.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Private commit emails were introduced in !22560, but some parts of
GitLab were not updated to take account of them. This commit adds
support in places that were missed.
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'fix-committer-typo' into 'master'</title>
<updated>2018-09-25T17:08:23+00:00</updated>
<author>
<name>Rémy Coutable</name>
<email>remy@rymai.me</email>
</author>
<published>2018-09-25T17:08:23+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=4ca1afec3534b7e70454bfd99552804c55ca0c83'/>
<id>4ca1afec3534b7e70454bfd99552804c55ca0c83</id>
<content type='text'>
Fix committer typo

Closes #51808

See merge request gitlab-org/gitlab-ce!21899</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Fix committer typo

Closes #51808

See merge request gitlab-org/gitlab-ce!21899</pre>
</div>
</content>
</entry>
<entry>
<title>Fix committer typo</title>
<updated>2018-09-25T08:51:07+00:00</updated>
<author>
<name>George Tsiolis</name>
<email>tsiolis.g@gmail.com</email>
</author>
<published>2018-09-25T08:37:32+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=f6114939126493409eb7f1bab26eda15ec2d2473'/>
<id>f6114939126493409eb7f1bab26eda15ec2d2473</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Use `Gitlab::SafeRequestStore` in more places</title>
<updated>2018-09-24T19:11:27+00:00</updated>
<author>
<name>Michael Kozono</name>
<email>mkozono@gmail.com</email>
</author>
<published>2018-09-20T22:40:15+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=a54a5d9f39df505fe7c68e14c693553bd29bd725'/>
<id>a54a5d9f39df505fe7c68e14c693553bd29bd725</id>
<content type='text'>
Even if it doesn’t save lines of code, since people will tend to use
code they’ve seen. And `SafeRequestStore` is safer since you
don’t have to remember to check `RequestStore.active?`.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Even if it doesn’t save lines of code, since people will tend to use
code they’ve seen. And `SafeRequestStore` is safer since you
don’t have to remember to check `RequestStore.active?`.
</pre>
</div>
</content>
</entry>
</feed>
