delta/gitlab/gitlab-ce.git/spec/models/commit_spec.rb, branch bootstrap-markdown-code-highlight

Preload pipeline data for project pipelines

2018-05-17T11:53:00+00:00

When displaying the pipelines of a project we now preload the following
data:

1. Authors of the commits that belong to these pipelines
2. The number of warnings per pipeline, which is used by
   Ci::Pipeline#has_warnings?

== Commit Authors

Previously this data was queried for every Commit separately, leading to
20 SQL queries being executed in the worst case. With an average of 3 to
5 milliseconds per SQL query this could result in 100 milliseconds being
spent in _just_ getting Commit authors.

To preload this data Commit#author now uses BatchLoader (through
Commit#lazy_author), and a separate module
Gitlab::Ci::Pipeline::Preloader is used to ensure all authors are loaded
before they are used.

== Number of warnings

This changes Ci::Pipeline#has_warnings? so it supports preloading of the
number of warnings per pipeline. This removes the need for executing a
COUNT(*) query for every pipeline just to see if it has any warnings or
not.

Workhorse to send raw diff and patch for commits

2018-05-16T09:52:43+00:00

Prior to this change, this was done through unicorn. In theory this
could time out. Workhorse has been sending these raw patches and diffs
for a long time and is stable in doing so.

Added bonus is the fact that `Commit#to_patch` can be removed.

`Commit#to_diff` too, which closes
https://gitlab.com/gitlab-org/gitaly/issues/324

Closes https://gitlab.com/gitlab-org/gitaly/issues/1196

Return nil on empty path

2018-04-17T14:30:18+00:00

The execution path wasn't clear from the error, but either way this is a
fix.

Closes gitlab-org/gitaly#1115

Fix an order dependency in a spec

2018-01-29T16:18:31+00:00

Migrate Commit#uri_type to Gitaly

2018-01-15T13:16:22+00:00

Closes gitaly#915

Display related merge requests in commit detail page

2018-01-12T20:38:36+00:00

Remove the Commit#tree method

2018-01-04T17:00:28+00:00

Replace '.team << [user, role]' with 'add_role(user)' in specs

2017-12-22T08:18:28+00:00

Load commit in batches for pipelines#index

2017-12-19T09:05:40+00:00

Uses `list_commits_by_oid` on the CommitService, to request the needed
commits for pipelines. These commits are needed to display the user that
created the commit and the commit title.

This includes fixes for tests failing that depended on the commit
being `nil`. However, now these are batch loaded, this doesn't happen
anymore and the commits are an instance of BatchLoader.

Optimise getting the pipeline status of commits

2017-11-16T15:01:14+00:00

This adds an optimised way of getting the latest pipeline status for a
list of Commit objects (or just a single one).