delta/gitlab/gitlab-ce.git/spec/models/ci/runner_spec.rb, branch koding-setting-api

Rename according to:

2016-06-20T08:52:05+00:00

https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/4093#note_12563922

For clarification and consistency

Use active tense, feedback from:

2016-06-16T15:33:53+00:00

https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/4093#note_12501303

blank line between setup and expectation, feedback:

2016-06-16T15:26:49+00:00

https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/4093/diffs#note_12501266
and:
https://robots.thoughtbot.com/four-phase-test

Adopt the rename from ci_commits to ci_pipelines

2016-06-15T09:34:44+00:00

Rename specific_for to available_for:

2016-06-14T08:07:57+00:00

Feedback from:
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/4093#note_12413950

Extra tests inside shared_examples:

2016-06-09T08:00:24+00:00

Feedback from:
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/4093#note_12321421

The advantage of this is that tests are less about logic and more
straightforward, thus could be easier to reason about each individual
tests.

The disadvantage of this is that we write more duplicated codes and
once something changed we might need to change all places and it's
harder to reason all tests as a whole. Because now we need to look at
more places to figure out how it should work under another option!

Remove Build#can_be_served? and rename Runner#can_serve? to can_pick?

2016-06-09T08:00:24+00:00

This also moves tests from build_spec.rb to runner_spec.rb

Prefer string for describe, feedback from:

2016-06-09T08:00:24+00:00

https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/4093#note_12321029

Prefer do and end for before/after:

2016-06-09T08:00:24+00:00

Feedback:
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/4404#note_12217415

Introduced Ci::Runner.specific_for for getting specific runners:

2016-06-09T08:00:24+00:00

for a particular project.