<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/gitlab/gitlab-ce.git/spec/migrations, branch scripts-differences</title>
<subtitle>gitlab.com: gitlab-org/gitlab-ce.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/'/>
<entry>
<title>Migrations for adding issue_id to versions table</title>
<updated>2019-07-29T18:55:19+00:00</updated>
<author>
<name>Luke Duncalfe</name>
<email>lduncalfe@gitlab.com</email>
</author>
<published>2019-07-29T18:55:19+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=177463007b1b97d29c7f4f8e279365c1ca6bfc9e'/>
<id>177463007b1b97d29c7f4f8e279365c1ca6bfc9e</id>
<content type='text'>
These migrations do the following:

- Adds a new `issue_id` column to `versions`. This fixes an n+1 problem
  when loading versions for an issue in GraphQL as AR can now load from
  cache
- Change the unique restraint on versions.sha to be scoped to `issue_id`
  as in order to import version data, we need to allow duplicate `sha`
  values for versions
- Update all versions with an `issue_id`

https://gitlab.com/gitlab-org/gitlab-ee/issues/11090
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
These migrations do the following:

- Adds a new `issue_id` column to `versions`. This fixes an n+1 problem
  when loading versions for an issue in GraphQL as AR can now load from
  cache
- Change the unique restraint on versions.sha to be scoped to `issue_id`
  as in order to import version data, we need to allow duplicate `sha`
  values for versions
- Update all versions with an `issue_id`

https://gitlab.com/gitlab-org/gitlab-ee/issues/11090
</pre>
</div>
</content>
</entry>
<entry>
<title>Add default for outbound_local_requests_whitelist</title>
<updated>2019-07-25T18:43:52+00:00</updated>
<author>
<name>Thong Kuah</name>
<email>tkuah@gitlab.com</email>
</author>
<published>2019-07-25T18:43:52+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=64f3324096e759b599682ef7ce5bdee75c9701b2'/>
<id>64f3324096e759b599682ef7ce5bdee75c9701b2</id>
<content type='text'>
It needs to default to an empty array logically.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
It needs to default to an empty array logically.
</pre>
</div>
</content>
</entry>
<entry>
<title>Fix wrong pages access level default</title>
<updated>2019-07-17T12:56:58+00:00</updated>
<author>
<name>Vladimir Shushlin</name>
<email>vshushlin@gitlab.com</email>
</author>
<published>2019-07-17T12:56:58+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=6796dcf27715f9a149387bb80e7a359208602f1f'/>
<id>6796dcf27715f9a149387bb80e7a359208602f1f</id>
<content type='text'>
- Set access level in before_validation hook
- Add post migration for updating existing project_features
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
- Set access level in before_validation hook
- Add post migration for updating existing project_features
</pre>
</div>
</content>
</entry>
<entry>
<title>Upgrade to Rails 5.2</title>
<updated>2019-07-12T02:15:31+00:00</updated>
<author>
<name>Heinrich Lee Yu</name>
<email>heinrich@gitlab.com</email>
</author>
<published>2019-06-25T17:54:42+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=aeb67dd489b1ccc7f0ab1d702725729ab9cc3e27'/>
<id>aeb67dd489b1ccc7f0ab1d702725729ab9cc3e27</id>
<content type='text'>
Updates changed method names and fixes spec failures
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Updates changed method names and fixes spec failures
</pre>
</div>
</content>
</entry>
<entry>
<title>Change occurrence of Sidekiq::Testing.inline!</title>
<updated>2019-07-03T20:02:17+00:00</updated>
<author>
<name>Reuben Pereira</name>
<email>rpereira@gitlab.com</email>
</author>
<published>2019-07-03T20:02:17+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=49b5ef5c3110ec25b65e20c75c3f98dbb2c8dfea'/>
<id>49b5ef5c3110ec25b65e20c75c3f98dbb2c8dfea</id>
<content type='text'>
- Change it to perform_enqueued_jobs
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
- Change it to perform_enqueued_jobs
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch '44990-remove-old-i' into 'master'</title>
<updated>2019-07-03T09:19:17+00:00</updated>
<author>
<name>Nick Thomas</name>
<email>nick@gitlab.com</email>
</author>
<published>2019-07-03T09:19:17+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=e555db6f28260e5473b8634fe3a21e89ec1ba578'/>
<id>e555db6f28260e5473b8634fe3a21e89ec1ba578</id>
<content type='text'>
Remove old migration specs that violate FactoriesInMigrationSpecs

See merge request gitlab-org/gitlab-ce!30280</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Remove old migration specs that violate FactoriesInMigrationSpecs

See merge request gitlab-org/gitlab-ce!30280</pre>
</div>
</content>
</entry>
<entry>
<title>Show upcoming status for releases</title>
<updated>2019-07-03T09:12:15+00:00</updated>
<author>
<name>Jason Goodman</name>
<email>jgoodman@gitlab.com</email>
</author>
<published>2019-07-03T09:12:15+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=7ecffe2987e0f3953489759d080fc263c5cb95c5'/>
<id>7ecffe2987e0f3953489759d080fc263c5cb95c5</id>
<content type='text'>
Add released_at field to releases API
Add released_at column to releases table
Return releases to the API sorted by released_at
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Add released_at field to releases API
Add released_at column to releases table
Return releases to the API sorted by released_at
</pre>
</div>
</content>
</entry>
<entry>
<title>Remove old migrations and specs</title>
<updated>2019-07-02T19:55:56+00:00</updated>
<author>
<name>Heinrich Lee Yu</name>
<email>heinrich@gitlab.com</email>
</author>
<published>2019-07-02T19:55:56+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=28ac2d304989164a1e9bf6d82fa8106a86a5f688'/>
<id>28ac2d304989164a1e9bf6d82fa8106a86a5f688</id>
<content type='text'>
This removes old migrations that violate the
FactoriesinMigrationSpecs cop
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This removes old migrations that violate the
FactoriesinMigrationSpecs cop
</pre>
</div>
</content>
</entry>
<entry>
<title>Remove migration specs from 201[4567]</title>
<updated>2019-07-02T08:35:03+00:00</updated>
<author>
<name>Nick Thomas</name>
<email>nick@gitlab.com</email>
</author>
<published>2019-07-01T11:39:27+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=876d4151167d237fda853585442d9a8e9681c23e'/>
<id>876d4151167d237fda853585442d9a8e9681c23e</id>
<content type='text'>
Since the migrations are gone, we don't need these specs either
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Since the migrations are gone, we don't need these specs either
</pre>
</div>
</content>
</entry>
<entry>
<title>Prevent EE backport migrations from running if CE is not migrated</title>
<updated>2019-06-25T12:42:10+00:00</updated>
<author>
<name>Stan Hu</name>
<email>stanhu@gmail.com</email>
</author>
<published>2019-06-24T21:07:37+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=1b0637781205623547ed1ae7242125f78f7b0b31'/>
<id>1b0637781205623547ed1ae7242125f78f7b0b31</id>
<content type='text'>
If a user upgraded to any GitLab 11.x EE version but switched
back to CE, it's possible the state of the EE tables are not
in the right state for the EE backport migration to work properly.
In particular, there were three tables that had trouble:

* epics
* geo_event_log
* vulnerability_feedback

The EE backport migration would fail while trying to add foreign key
constraints because a key didn't exist in the table. This happens
because any EE migration that add or removed columns between v11.0.0 and
v11.11.3 are not guaranteed to be applied in an CE installation. The EE
backport schema does not individually backport these migrations.

We now check if certain columns are present to determine whether
the backport migration is in the proper state. CE users are required
to upgrade to v11.11.3 EE if they ever installed EE previously before
they can go back to v12.x CE.

Tested via:

```
git checkout -f v11.0.0-ee
bundle exec rake db:reset
git checkout .; git checkout -f v11.11.3
bundle exec rake db:migrate
git checkout .; git checkout -f v12.0.0
bundle exec rake db:migrate
&lt;failure happens&gt;
```
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
If a user upgraded to any GitLab 11.x EE version but switched
back to CE, it's possible the state of the EE tables are not
in the right state for the EE backport migration to work properly.
In particular, there were three tables that had trouble:

* epics
* geo_event_log
* vulnerability_feedback

The EE backport migration would fail while trying to add foreign key
constraints because a key didn't exist in the table. This happens
because any EE migration that add or removed columns between v11.0.0 and
v11.11.3 are not guaranteed to be applied in an CE installation. The EE
backport schema does not individually backport these migrations.

We now check if certain columns are present to determine whether
the backport migration is in the proper state. CE users are required
to upgrade to v11.11.3 EE if they ever installed EE previously before
they can go back to v12.x CE.

Tested via:

```
git checkout -f v11.0.0-ee
bundle exec rake db:reset
git checkout .; git checkout -f v11.11.3
bundle exec rake db:migrate
git checkout .; git checkout -f v12.0.0
bundle exec rake db:migrate
&lt;failure happens&gt;
```
</pre>
</div>
</content>
</entry>
</feed>
