<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/gitlab/gitlab-ce.git/spec/lib, branch docs-avoid-CephFS-GlusterFS</title>
<subtitle>gitlab.com: gitlab-org/gitlab-ce.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/'/>
<entry>
<title>Handle missing keys in sentry api response</title>
<updated>2019-03-29T14:53:40+00:00</updated>
<author>
<name>Reuben Pereira</name>
<email>rpereira@gitlab.com</email>
</author>
<published>2019-03-29T14:53:40+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=c558d72b5bca44984c32b6f65f4b56332ee828f6'/>
<id>c558d72b5bca44984c32b6f65f4b56332ee828f6</id>
<content type='text'>
- Do not raise error when there are missing non-essential keys in sentry
api response.
- Add specs for to check for missing keys behavior.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
- Do not raise error when there are missing non-essential keys in sentry
api response.
- Add specs for to check for missing keys behavior.
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch '50199-quick-actions-refactor' into 'master'</title>
<updated>2019-03-29T14:48:01+00:00</updated>
<author>
<name>Sean McGivern</name>
<email>sean@gitlab.com</email>
</author>
<published>2019-03-29T14:48:01+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=bf48b071f9c19c6585eb3e589bb8bc2ab6a75723'/>
<id>bf48b071f9c19c6585eb3e589bb8bc2ab6a75723</id>
<content type='text'>
Extend quick actions dsl

Closes #50199

See merge request gitlab-org/gitlab-ce!26095</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Extend quick actions dsl

Closes #50199

See merge request gitlab-org/gitlab-ce!26095</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch '59462-applicatonsettings-not-tolerant-of-missing-db-columns' into 'master'</title>
<updated>2019-03-29T13:13:10+00:00</updated>
<author>
<name>Stan Hu</name>
<email>stanhu@gmail.com</email>
</author>
<published>2019-03-29T13:13:10+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=a9d9907a8e44c849835d08efbd25f29349749c72'/>
<id>a9d9907a8e44c849835d08efbd25f29349749c72</id>
<content type='text'>
Use a Gitlab::FakeApplicationSettings when migrations are pending

Closes #59462

See merge request gitlab-org/gitlab-ce!26601</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Use a Gitlab::FakeApplicationSettings when migrations are pending

Closes #59462

See merge request gitlab-org/gitlab-ce!26601</pre>
</div>
</content>
</entry>
<entry>
<title>Extend quick actions dsl</title>
<updated>2019-03-29T10:53:28+00:00</updated>
<author>
<name>Alexandru Croitor</name>
<email>acroitor@gitlab.com</email>
</author>
<published>2019-03-13T10:45:43+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=4b9ff4d2fe2eb22e3abed32f56aef6b24d40aa31'/>
<id>4b9ff4d2fe2eb22e3abed32f56aef6b24d40aa31</id>
<content type='text'>
* Extend quick actions dsl to allow specifying model types
to which given quick action applies
* Rename issuable attribute to noteable in interpret_service.rb
* Refactor and reorder quick action specs
* Create a shared example spec for each quick action to be used for
issue, merge request and commit specs.

https://gitlab.com/gitlab-org/gitlab-ce/issues/50199
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
* Extend quick actions dsl to allow specifying model types
to which given quick action applies
* Rename issuable attribute to noteable in interpret_service.rb
* Refactor and reorder quick action specs
* Create a shared example spec for each quick action to be used for
issue, merge request and commit specs.

https://gitlab.com/gitlab-org/gitlab-ce/issues/50199
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'persist-fulll-ref-path-for-mr-pipelines' into 'master'</title>
<updated>2019-03-29T10:46:02+00:00</updated>
<author>
<name>Kamil Trzciński</name>
<email>ayufan@ayufan.eu</email>
</author>
<published>2019-03-29T10:46:02+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=0d26c48332e7c580946adbd41795d4817909e2ef'/>
<id>0d26c48332e7c580946adbd41795d4817909e2ef</id>
<content type='text'>
Use merge request HEAD ref for detached merge request pipelines

Closes #58454

See merge request gitlab-org/gitlab-ce!25504</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Use merge request HEAD ref for detached merge request pipelines

Closes #58454

See merge request gitlab-org/gitlab-ce!25504</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'sh-fix-gitaly-find-commit-caching' into 'master'</title>
<updated>2019-03-29T10:31:57+00:00</updated>
<author>
<name>Kamil Trzciński</name>
<email>ayufan@ayufan.eu</email>
</author>
<published>2019-03-29T10:31:57+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=a7cf61355a45a67ef404eeec3e38738f997ef2ec'/>
<id>a7cf61355a45a67ef404eeec3e38738f997ef2ec</id>
<content type='text'>
Allow ref name caching CommitService#find_commit

Closes #57083

See merge request gitlab-org/gitlab-ce!26248</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Allow ref name caching CommitService#find_commit

Closes #57083

See merge request gitlab-org/gitlab-ce!26248</pre>
</div>
</content>
</entry>
<entry>
<title>Create detached merge request pipelines</title>
<updated>2019-03-29T06:58:45+00:00</updated>
<author>
<name>Shinya Maeda</name>
<email>shinya@gitlab.com</email>
</author>
<published>2019-03-21T13:08:32+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=bf639fd504c84929ff8542eef81578a6745bf428'/>
<id>bf639fd504c84929ff8542eef81578a6745bf428</id>
<content type='text'>
By using `refs/merge-requests/:iid/head`

ok

ok

Improve naming nicely

Add nice tests

add nice tests

fix some more

revert
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
By using `refs/merge-requests/:iid/head`

ok

ok

Improve naming nicely

Add nice tests

add nice tests

fix some more

revert
</pre>
</div>
</content>
</entry>
<entry>
<title>Use a fixed git abbrev parameter when we fetch a git revision</title>
<updated>2019-03-28T13:24:56+00:00</updated>
<author>
<name>Valery Sizov</name>
<email>valery@gitlab.com</email>
</author>
<published>2019-03-28T11:05:03+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=cc2e849afd1a2b7c5c0ad1dcb5b675d072800b8b'/>
<id>cc2e849afd1a2b7c5c0ad1dcb5b675d072800b8b</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Apply suggestion to spec/lib/gitlab/current_settings_spec.rb</title>
<updated>2019-03-28T07:05:12+00:00</updated>
<author>
<name>Lin Jen-Shin</name>
<email>godfat@godfat.org</email>
</author>
<published>2019-03-28T07:05:12+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=43afcd03332b03ef6b51ac8bc67e8f121d71cc8c'/>
<id>43afcd03332b03ef6b51ac8bc67e8f121d71cc8c</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Allow ref name caching CommitService#find_commit</title>
<updated>2019-03-27T19:46:39+00:00</updated>
<author>
<name>Stan Hu</name>
<email>stanhu@gmail.com</email>
</author>
<published>2019-03-17T06:23:11+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=db759c5d9ca3ba9c1610b05d6725c1427d653bef'/>
<id>db759c5d9ca3ba9c1610b05d6725c1427d653bef</id>
<content type='text'>
For a given merge request, it's quite common to see duplicate FindCommit
Gitaly requests because the Gitaly CommitService caches the request by
the commit SHA, not by the ref name. However, most of the duplicate
requests use the ref name, so the cache is never actually used in
practice. This leads to unnecessary requests that slow performance.

This commit allows certain callers to bypass the ref name to
OID conversion in the cache. We don't do this by default because it's
possible the tip of the branch changes during the commit, which
would cause the caller to get stale data.

This commit also forces the Ci::Pipeline to use the full ref name
so that caching can work for merge requests.

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/57083
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
For a given merge request, it's quite common to see duplicate FindCommit
Gitaly requests because the Gitaly CommitService caches the request by
the commit SHA, not by the ref name. However, most of the duplicate
requests use the ref name, so the cache is never actually used in
practice. This leads to unnecessary requests that slow performance.

This commit allows certain callers to bypass the ref name to
OID conversion in the cache. We don't do this by default because it's
possible the tip of the branch changes during the commit, which
would cause the caller to get stale data.

This commit also forces the Ci::Pipeline to use the full ref name
so that caching can work for merge requests.

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/57083
</pre>
</div>
</content>
</entry>
</feed>
