delta/gitlab/gitlab-ce.git/spec/lib, branch ce-docker_image_replication gitlab.com: gitlab-org/gitlab-ce.git Merge branch 'sh-fix-infite-loop-peek-bar' into 'master' 2019-08-01T09:42:28+00:00 Sean McGivern sean@gitlab.com 2019-08-01T09:42:28+00:00 3186a3bfe31455ab0f0228aac3cc94ef2467f933 Fix SystemStackError when Peek bar is active with Rugged calls Closes #65404 See merge request gitlab-org/gitlab-ce!31357 
Fix SystemStackError when Peek bar is active with Rugged calls

Closes #65404

See merge request gitlab-org/gitlab-ce!31357
 Merge branch '65363-add-feature-remove' into 'master' 2019-08-01T00:02:07+00:00 Stan Hu stanhu@gmail.com 2019-08-01T00:02:07+00:00 cfb7f11644d41bedc423865caa28b4266840f8e4 Add Feature.remove Closes #65363 See merge request gitlab-org/gitlab-ce!31315 
Add Feature.remove

Closes #65363

See merge request gitlab-org/gitlab-ce!31315
 Fix SystemStackError when Peek bar is active with Rugged calls 2019-07-31T22:47:19+00:00 Stan Hu stanhu@gmail.com 2019-07-31T22:38:02+00:00 7a5c4cd0ca692e2fac0d648726b71dcd304602ec Peek attempts to serialize results with `to_json`, which calls `ActiveSupport::JSON`. If an object is passed to `to_json` that contains instance variables, `ActiveSupport` will attempt to recursively traverse all variables. The problem is that we can get into an infinite loop if the instance references to an instance that references to something else that points back to the same instance. To avoid this mess, we just call `to_s` on the object. It appears only `Gitlab::Git::Repository` and `::Repository` are the culprits here. Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/65404 
Peek attempts to serialize results with `to_json`, which calls
`ActiveSupport::JSON`. If an object is passed to `to_json` that contains
instance variables, `ActiveSupport` will attempt to recursively traverse
all variables.

The problem is that we can get into an infinite loop if the instance
references to an instance that references to something else that points
back to the same instance.

To avoid this mess, we just call `to_s` on the object. It appears only
`Gitlab::Git::Repository` and `::Repository` are the culprits here.

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/65404
Add new Feature.remove method 2019-07-31T22:29:14+00:00 Ash McKenzie amckenzie@gitlab.com 2019-07-31T00:41:11+00:00 31e419e945f8058be58487057bf77c338ca8f536 






Merge branch '65297-fix-typo-on-clusters_applications_cert_managers-factory' into 'master'
2019-07-31T21:40:00+00:00

Thong Kuah
tkuah@gitlab.com

2019-07-31T21:40:00+00:00

7f198de92914664363a18a5da079cd289580f8ba

Resolve "Fix typo on clusters_applications_cert_managers factory"

Closes #65297

See merge request gitlab-org/gitlab-ce!31278




Resolve "Fix typo on clusters_applications_cert_managers factory"

Closes #65297

See merge request gitlab-org/gitlab-ce!31278






Merge branch 'fix-sidekiq-memory-killer-warn-message' into 'master'
2019-07-31T13:04:46+00:00

Stan Hu
stanhu@gmail.com

2019-07-31T13:04:46+00:00

7bab7b6993edbaf0d1fa2dfce315563dad676a44

Fix sidekiq memory killer warning message

Closes gitlab-com/gl-infra/infrastructure#7371

See merge request gitlab-org/gitlab-ce!31264




Fix sidekiq memory killer warning message

Closes gitlab-com/gl-infra/infrastructure#7371

See merge request gitlab-org/gitlab-ce!31264






Adds Sidekiq scheduling latency structured logging field
2019-07-31T12:07:47+00:00

Andrew Newdigate
andrew@gitlab.com

2019-07-31T12:07:47+00:00

ee828f09bfb063280695f8c3066e7906d5b13769












Default dependency job stage index to Infinity, and correctly report it as undefined in prior stages
2019-07-31T12:06:01+00:00

drew
dscimino@gmail.com

2019-07-31T12:06:01+00:00

5eb3c4af38959c3e9414053c954e397c0b03a26b












Merge branch '65317-adapt-tae-role-name-change' into 'master'
2019-07-31T11:32:13+00:00

Sean McGivern
sean@gitlab.com

2019-07-31T11:32:13+00:00

fff0fc7b4c2475a432fd4e1b025be66f9f5ba519

Fix Danger finding a test reviewer

Closes #65317

See merge request gitlab-org/gitlab-ce!31292




Fix Danger finding a test reviewer

Closes #65317

See merge request gitlab-org/gitlab-ce!31292






Merge branch 'sh-fix-gitaly-access-control' into 'master'
2019-07-30T15:32:59+00:00

Douglas Barbosa Alexandre
dbalexandre@gmail.com

2019-07-30T15:32:59+00:00

d92a8c1a5f9b061a10140239bed44b432b28abdf

Fix exception handling in Gitaly autodetection

Closes #65328

See merge request gitlab-org/gitlab-ce!31285




Fix exception handling in Gitaly autodetection

Closes #65328

See merge request gitlab-org/gitlab-ce!31285