delta/gitlab/gitlab-ce.git/spec/lib, branch add-docker-debugging-docs

Fix specs

2016-08-01T11:24:06+00:00

Signed-off-by: Rémy Coutable

Trim extra displayed carriage returns in diffs and files with CRLFs

2016-08-01T11:24:06+00:00

Closes #20440

squashed - fixed label and milestone association problems, updated specs and refactored reader class a bit

2016-08-01T07:57:40+00:00

Merge branch 'ability-batch-issue-checking' into 'master'

2016-07-29T16:54:37+00:00


Optimize checking if a user can read multiple issues

## What does this MR do?

This optimizes various parts of the code so it can more efficiently check if a user can read a list of issues.

## Are there points in the code the reviewer needs to double check?

Yes, in particular `Ability.issues_readable_by_user` should be checked to make sure it correctly allows/restricts access to issues.

## Why was this MR needed?

Currently the general approach to checking if one can read an issue is to iterate over the issues to check and call `can?(user, :read_issue, issue)` for every issue. This is not efficient as the same work has to be done for every issue.

## What are the relevant issue numbers?

* #15607 
* #17463

See merge request !5370

Merge branch 'refactor/ci-config-move-job-entries' into 'master'

2016-07-29T13:53:35+00:00


Move CI job config entries from legacy to new config

## What does this MR do?

This MR extracts jobs configuration logic from legacy CI config processor to the new code.

## What are the relevant issue numbers?

#15060

## Does this MR meet the acceptance criteria?

- Tests
  - [x] Added for this feature/bug
  - [x] All builds are passing
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if you do - rebase it please)

See merge request !5087

Improve code, remove unused validator, improve names

2016-07-29T12:09:35+00:00

Method for returning issues readable by a user

2016-07-29T10:51:18+00:00

The method Ability.issues_readable_by_user takes a list of users and an
optional user and returns an Array of issues readable by said user. This
method in turn is used by
Banzai::ReferenceParser::IssueParser#nodes_visible_to_user so this
method no longer needs to get all the available abilities just to check
if a user has the "read_issue" ability.

To test this I benchmarked an issue with 222 comments on my development
environment. Using these changes the time spent in nodes_visible_to_user
was reduced from around 120 ms to around 40 ms.

Remove duplicate specs from `git_access_spec`

2016-07-29T09:50:39+00:00

- Likely introduced during an improper conflict resolution.

Admins count as masters too.

2016-07-29T09:50:39+00:00

1. In the context of protected branches.

2. Test this behaviour.

Fix all specs related to changes in !5081.

2016-07-29T09:50:39+00:00

1. Remove `Project#developers_can_push_to_protected_branch?` since it
   isn't used anymore.

2. Remove `Project#developers_can_merge_to_protected_branch?` since it
   isn't used anymore.