delta/gitlab/gitlab-ce.git/spec/lib/banzai/reference_parser, branch commit-description-border gitlab.com: gitlab-org/gitlab-ce.git Use `:empty_project` where possible throughout spec/lib 2017-01-25T17:25:42+00:00 Robert Speicher rspeicher@gmail.com 2017-01-24T23:42:12+00:00 80a6d2fda2483bf81c4cf9cdac9aa3c9e42b7982 






Parse JIRA issue references even if Issue Tracker is disabled
2016-12-29T18:52:04+00:00

Felipe Artur
felipefac@gmail.com

2016-12-21T18:36:24+00:00

f9963fe029122c9d7e866368b1fc1218e071f9d6












Merge branch 'issue_23548_dev' into 'master'
2016-11-09T11:25:17+00:00

Douwe Maan
douwe@gitlab.com

2016-11-01T20:18:51+00:00

bf061d0aff091a73611037b811cea2d3380962f4

disable markdown in comments when referencing disabled features

fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/23548

This MR prevents the following references when tool is disabled:

- issues
- snippets
- commits - when repo is disabled
- commit range - when repo is disabled
- milestones

This MR does not prevent references to repository files, since they are just markdown links and don't leak
information.

See merge request !2011

Signed-off-by: Rémy Coutable <remy@rymai.me>





disable markdown in comments when referencing disabled features

fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/23548

This MR prevents the following references when tool is disabled:

- issues
- snippets
- commits - when repo is disabled
- commit range - when repo is disabled
- milestones

This MR does not prevent references to repository files, since they are just markdown links and don't leak
information.

See merge request !2011

Signed-off-by: Rémy Coutable <remy@rymai.me>







remove Ability.abilities
2016-08-30T18:35:06+00:00

http://jneen.net/
jneen@jneen.net

2016-08-08T18:55:13+00:00

5853c96b49010aaf33b85caeb94dfc18873d5656












Method for returning issues readable by a user
2016-07-29T10:51:18+00:00

Yorick Peterse
yorickpeterse@gmail.com

2016-07-20T18:13:02+00:00

002ad215818450d2cbbc5fa065850a953dc7ada8

The method Ability.issues_readable_by_user takes a list of users and an
optional user and returns an Array of issues readable by said user. This
method in turn is used by
Banzai::ReferenceParser::IssueParser#nodes_visible_to_user so this
method no longer needs to get all the available abilities just to check
if a user has the "read_issue" ability.

To test this I benchmarked an issue with 222 comments on my development
environment. Using these changes the time spent in nodes_visible_to_user
was reduced from around 120 ms to around 40 ms.





The method Ability.issues_readable_by_user takes a list of users and an
optional user and returns an Array of issues readable by said user. This
method in turn is used by
Banzai::ReferenceParser::IssueParser#nodes_visible_to_user so this
method no longer needs to get all the available abilities just to check
if a user has the "read_issue" ability.

To test this I benchmarked an issue with 222 comments on my development
environment. Using these changes the time spent in nodes_visible_to_user
was reduced from around 120 ms to around 40 ms.







Re-use queries in reference parsers
2016-07-08T19:54:35+00:00

Yorick Peterse
yorickpeterse@gmail.com

2016-06-30T09:51:07+00:00

9ac4c556eac857fc285838070ffc24650a1bab44

This caches various queries to ensure that multiple reference extraction
runs re-use any objects queried in previous runs.





This caches various queries to ensure that multiple reference extraction
runs re-use any objects queried in previous runs.







Split Markdown rendering & reference gathering
2016-05-26T15:14:00+00:00

Yorick Peterse
yorickpeterse@gmail.com

2016-05-26T11:16:43+00:00

86166d28029d5fcc729f7b7f5a41635c2e783a9e

This splits the Markdown rendering and reference extraction phases into
two distinct code bases. The reference extraction phase no longer relies
on the html-pipeline Gem (and any related code) and allows for
extracting of references from multiple HTML nodes in a single pass. This
means that if you want to extract user references from 200 comments you
no longer need to run 200 times N number of queries, instead only a
handful of queries may be needed.





This splits the Markdown rendering and reference extraction phases into
two distinct code bases. The reference extraction phase no longer relies
on the html-pipeline Gem (and any related code) and allows for
extracting of references from multiple HTML nodes in a single pass. This
means that if you want to extract user references from 200 comments you
no longer need to run 200 times N number of queries, instead only a
handful of queries may be needed.