delta/gitlab/gitlab-ce.git/spec/javascripts/notes/stores, branch patch-63 gitlab.com: gitlab-org/gitlab-ce.git Add failing test for saveNote error handling 2019-05-07T21:15:36+00:00 Winnie Hellmann winnie@gitlab.com 2019-05-03T21:11:55+00:00 0625ccc652f97310b2444bb16ed8e20ee0642300 






Resolve discussion when suggestion is applied
2019-05-07T05:00:40+00:00

Paul Slaughter
pslaughter@gitlab.com

2019-05-06T17:56:48+00:00

d24d77a93a64e4698163c5ca579954f61ad9248a

- Adds color and a tooltip to describe this new behavior
- Does not resolve if discussion is already resolved
- Adds an action `resolveDiscussion` to simplify `toggleResolveNote`
- Updates docs

https://gitlab.com/gitlab-org/gitlab-ce/issues/54405





- Adds color and a tooltip to describe this new behavior
- Does not resolve if discussion is already resolved
- Adds an action `resolveDiscussion` to simplify `toggleResolveNote`
- Updates docs

https://gitlab.com/gitlab-org/gitlab-ce/issues/54405







Handle transformed notes from polling response
2019-03-06T09:19:27+00:00

Heinrich Lee Yu
heinrich@gitlab.com

2019-03-06T06:39:53+00:00

d72a61b41d1aaf6b0ed9041b32fa411e8907d4f8

Transforms notes when the note was transformed in some other tab





Transforms notes when the note was transformed in some other tab







Move EE differences in CE diff files into CE
2019-03-01T09:34:16+00:00

Phil Hughes
me@iamphill.com

2019-03-01T09:34:16+00:00

37541114770f9229acb29e798494a063e1b40d04

Closes https://gitlab.com/gitlab-org/gitlab-ee/issues/9974, https://gitlab.com/gitlab-org/gitlab-ee/issues/9973, https://gitlab.com/gitlab-org/gitlab-ee/issues/9969





Closes https://gitlab.com/gitlab-org/gitlab-ee/issues/9974, https://gitlab.com/gitlab-org/gitlab-ee/issues/9973, https://gitlab.com/gitlab-org/gitlab-ee/issues/9969







Fix misspellings in app/spec executable lines
2019-02-27T13:41:34+00:00

Takuya Noguchi
takninnovationresearch@gmail.com

2019-02-25T08:19:36+00:00

a565f3d88d9c2e38b615378298b8db1f306ebd53

Signed-off-by: Takuya Noguchi <takninnovationresearch@gmail.com>





Signed-off-by: Takuya Noguchi <takninnovationresearch@gmail.com>







Cancelling reply reverts comment to initial state
2019-02-18T07:16:13+00:00

Constance Okoghenun
constanceokoghenun@gmail.com

2019-02-18T07:16:13+00:00

5e137b58ca15f224a3b1b05999e6e689b463417a

When converting a comment to a discussion
if the "Cancel" button is used to exit the new discussion note,
the comment would revert back to its initial state





When converting a comment to a discussion
if the "Cancel" button is used to exit the new discussion note,
the comment would revert back to its initial state







Fix polling for replies to individual notes
2019-02-14T10:07:13+00:00

Heinrich Lee Yu
heinrich@gitlab.com

2019-02-14T10:07:13+00:00

f60734d3cb15492310820e6571c69e2f68939d16

Sets `updated_at` so that the transformed note is returned together with
the new reply





Sets `updated_at` so that the transformed note is returned together with
the new reply







Add reply to notes to turn into discussions
2019-02-06T10:31:46+00:00

Heinrich Lee Yu
heinrich@gitlab.com

2019-02-06T10:31:46+00:00

a04d9ba90c0d1df02f613b7aa01ef598e1ac5b28












Trim first char of diff line text on diff discussions
2019-01-22T16:00:16+00:00

Douwe Maan
douwe@selenight.nl

2019-01-22T12:35:28+00:00

03df54b226f63a05ee2229b9f7f1f3e90383430a

Before, diff file `higlighted_diff_lines`/`parallel_diff_lines` and
diff discussion `truncated_diff_lines` were inconsistent: `text` and
`rich_text` on the latter included the leading +/-/<space> character,
like on the backend, while the former had no `text` and its `rich_text`
had dropped this char.

This resulted in a bug when the suggestions feature expected these diff
line objects to be identical in format and thus interchangeable, which
was not the case.





Before, diff file `higlighted_diff_lines`/`parallel_diff_lines` and
diff discussion `truncated_diff_lines` were inconsistent: `text` and
`rich_text` on the latter included the leading +/-/<space> character,
like on the backend, while the former had no `text` and its `rich_text`
had dropped this char.

This resulted in a bug when the suggestions feature expected these diff
line objects to be identical in format and thus interchangeable, which
was not the case.







Fix MR discussion counts being off
2018-12-10T22:44:35+00:00

Paul Slaughter
pslaughter@gitlab.com

2018-12-10T22:41:22+00:00

958aaebdde3255df1cfd45e1e75c7a0c19700a6c

**What was the issue?**
Notes can be unresolved, but not resolvable. Without this, the
unresolvedDiscussionsCount was inflated.

**References**
https://gitlab.com/gitlab-org/gitlab-ce/issues/55138





**What was the issue?**
Notes can be unresolved, but not resolvable. Without this, the
unresolvedDiscussionsCount was inflated.

**References**
https://gitlab.com/gitlab-org/gitlab-ce/issues/55138