<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/gitlab/gitlab-ce.git/spec/javascripts/ide, branch patch-49</title>
<subtitle>gitlab.com: gitlab-org/gitlab-ce.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/'/>
<entry>
<title>Merge branch '60021-fix-ide-file-dropdown' into 'master'</title>
<updated>2019-04-05T07:39:40+00:00</updated>
<author>
<name>Phil Hughes</name>
<email>me@iamphill.com</email>
</author>
<published>2019-04-05T07:39:40+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=36d1d9082cc0d12ebce52050730ae50a0cc51d1a'/>
<id>36d1d9082cc0d12ebce52050730ae50a0cc51d1a</id>
<content type='text'>
Fix IDE file dropdown

Closes #60021

See merge request gitlab-org/gitlab-ce!27015</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Fix IDE file dropdown

Closes #60021

See merge request gitlab-org/gitlab-ce!27015</pre>
</div>
</content>
</entry>
<entry>
<title>Fix IDE detecting MR from fork branch</title>
<updated>2019-04-05T07:29:53+00:00</updated>
<author>
<name>Paul Slaughter</name>
<email>pslaughter@gitlab.com</email>
</author>
<published>2019-04-05T07:29:53+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=59ac0924da8ffc6ae28eecffda2654cd7ab8f761'/>
<id>59ac0924da8ffc6ae28eecffda2654cd7ab8f761</id>
<content type='text'>
**Why?**
Currently the IDE loads a merge request based on only the
`source_branch` name. This means it loads MR's from
forks that have the same branch name (not good).

- This required updating the BE API to accept `source_project_id`
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
**Why?**
Currently the IDE loads a merge request based on only the
`source_branch` name. This means it loads MR's from
forks that have the same branch name (not good).

- This required updating the BE API to accept `source_project_id`
</pre>
</div>
</content>
</entry>
<entry>
<title>Refactor new_dropdown/index to receive isOpen prop</title>
<updated>2019-04-04T20:35:45+00:00</updated>
<author>
<name>Paul Slaughter</name>
<email>pslaughter@gitlab.com</email>
</author>
<published>2019-04-04T18:55:49+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=c1a097e1cee43b127de17d769546ffa244cbf484'/>
<id>c1a097e1cee43b127de17d769546ffa244cbf484</id>
<content type='text'>
**Why?**

Previously it managed this as an internal data property, but there
was extra complexity involved because the component doesn't have
all the information it needs (i.e. the `mouseOver` prop).

This is a good opportunity to colocate the data prop with the component
that has the information to change it (i.e. `file_row`) and let
`new_dropdown/index` receive this value as a prop.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
**Why?**

Previously it managed this as an internal data property, but there
was extra complexity involved because the component doesn't have
all the information it needs (i.e. the `mouseOver` prop).

This is a good opportunity to colocate the data prop with the component
that has the information to change it (i.e. `file_row`) and let
`new_dropdown/index` receive this value as a prop.
</pre>
</div>
</content>
</entry>
<entry>
<title>Fix vue render error for IDE status bar</title>
<updated>2019-04-04T15:00:44+00:00</updated>
<author>
<name>Paul Slaughter</name>
<email>pslaughter@gitlab.com</email>
</author>
<published>2019-04-04T07:44:16+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=bd1122ee2fd5c8083c945390a1593b2b5774d8a1'/>
<id>bd1122ee2fd5c8083c945390a1593b2b5774d8a1</id>
<content type='text'>
**What?**

A Vue warning that `ide_status_bar` sent a `Boolean` to a `String`
property (`img-src).

**What was the fix?**

Previously, `latestPipeline` could be one of the following values:

|          |        |
|----------|--------|
| `null`   | The pipeline hasn't loaded yet |
| `false`  | The pipeline has loaded, but nothing was returned. |
| `Object` | The piepline has loaded. |

Giving a semantic meaning to different falsey values hurts
maintainability. This commit fixes the above problem by removing the
`false` value and introducing a `hasLoadedPipeline` state property.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
**What?**

A Vue warning that `ide_status_bar` sent a `Boolean` to a `String`
property (`img-src).

**What was the fix?**

Previously, `latestPipeline` could be one of the following values:

|          |        |
|----------|--------|
| `null`   | The pipeline hasn't loaded yet |
| `false`  | The pipeline has loaded, but nothing was returned. |
| `Object` | The piepline has loaded. |

Giving a semantic meaning to different falsey values hurts
maintainability. This commit fixes the above problem by removing the
`false` value and introducing a `hasLoadedPipeline` state property.
</pre>
</div>
</content>
</entry>
<entry>
<title>Upgraded Vue to 2.6.8</title>
<updated>2019-03-27T21:33:20+00:00</updated>
<author>
<name>Tim Zallmann</name>
<email>tzallmann@gitlab.com</email>
</author>
<published>2019-03-27T21:33:20+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=4f0b2079dedef24778e6176c0e1f814cdb739a90'/>
<id>4f0b2079dedef24778e6176c0e1f814cdb739a90</id>
<content type='text'>
Upgrade to latest Version
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Upgrade to latest Version
</pre>
</div>
</content>
</entry>
<entry>
<title>Fixed commit logic to pick a branch</title>
<updated>2019-03-25T09:16:41+00:00</updated>
<author>
<name>Natalia Tepluhina</name>
<email>ntepluhina@gitlab.com</email>
</author>
<published>2019-03-25T09:16:41+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=a72241f4a92ab0b202eb3c7e03931857428237b6'/>
<id>a72241f4a92ab0b202eb3c7e03931857428237b6</id>
<content type='text'>
- fixed getter spec with correct getter name
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
- fixed getter spec with correct getter name
</pre>
</div>
</content>
</entry>
<entry>
<title>Move some tests from Karma to Jest</title>
<updated>2019-03-23T16:53:46+00:00</updated>
<author>
<name>Winnie Hellmann</name>
<email>winnie@gitlab.com</email>
</author>
<published>2019-03-23T16:52:35+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=514ee63826e47229bfd03bdbb740f2dd1eae1d03'/>
<id>514ee63826e47229bfd03bdbb740f2dd1eae1d03</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Implemented trimming for item's name in Web IDE</title>
<updated>2019-03-18T12:59:16+00:00</updated>
<author>
<name>Denys Mishunov</name>
<email>dmishunov@gitlab.com</email>
</author>
<published>2019-03-18T11:22:51+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=1a2bdb4366ab819a43e2df48124073c836564e37'/>
<id>1a2bdb4366ab819a43e2df48124073c836564e37</id>
<content type='text'>
Resolves https://gitlab.com/gitlab-org/gitlab-ce/issues/57540
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Resolves https://gitlab.com/gitlab-org/gitlab-ce/issues/57540
</pre>
</div>
</content>
</entry>
<entry>
<title>Improve files_decorator performance</title>
<updated>2019-03-07T09:22:05+00:00</updated>
<author>
<name>Paul Slaughter</name>
<email>pslaughter@gitlab.com</email>
</author>
<published>2019-03-07T09:22:05+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=c49d4a4985c806aa62dcd4899013143484b5d3c6'/>
<id>c49d4a4985c806aa62dcd4899013143484b5d3c6</id>
<content type='text'>
**How?**
Previously the files_decorator inserted parent folders inefficiently.
It started at the first part and ensured each was inserted.

Since the file entries are given to use in alphabetical order, we can
start at the last part of the blob's parents. If this exists, we can
short circuit and be done inserting parents.

**What else?**
- Improve performance of decorateData. The object spread operator is
not needed because the object is brand new.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
**How?**
Previously the files_decorator inserted parent folders inefficiently.
It started at the first part and ensured each was inserted.

Since the file entries are given to use in alphabetical order, we can
start at the last part of the blob's parents. If this exists, we can
short circuit and be done inserting parents.

**What else?**
- Improve performance of decorateData. The object spread operator is
not needed because the object is brand new.
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch '49663-branch-to-mr-connection' into 'master'</title>
<updated>2019-03-05T08:43:44+00:00</updated>
<author>
<name>Phil Hughes</name>
<email>me@iamphill.com</email>
</author>
<published>2019-03-05T08:43:44+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=1caa760f5d2d0df1c29df6bf376ce1037785250f'/>
<id>1caa760f5d2d0df1c29df6bf376ce1037785250f</id>
<content type='text'>
Link to the MR from current branch in Web IDE

Closes #49663

See merge request gitlab-org/gitlab-ce!25689</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Link to the MR from current branch in Web IDE

Closes #49663

See merge request gitlab-org/gitlab-ce!25689</pre>
</div>
</content>
</entry>
</feed>
