<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/gitlab/gitlab-ce.git/spec/javascripts/diffs/store, branch docs/ssh-win</title>
<subtitle>gitlab.com: gitlab-org/gitlab-ce.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/'/>
<entry>
<title>Fixes diff discussions not being fully removed</title>
<updated>2018-10-30T10:41:25+00:00</updated>
<author>
<name>Phil Hughes</name>
<email>me@iamphill.com</email>
</author>
<published>2018-10-30T10:41:25+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=605e7fddc8f399e6d4cc8ceecb60d9c818b25a7f'/>
<id>605e7fddc8f399e6d4cc8ceecb60d9c818b25a7f</id>
<content type='text'>
This fixes a bug where a discussion on a none changed line
would not get fully removed and therefore leave the comment row
empty. This was caused by the discussiob being added
to the right when it shouldnt of been

This also fixes a very rare edge case where discussions would get added
twice to diff lines causing a Vue rendering warning

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/53317
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This fixes a bug where a discussion on a none changed line
would not get fully removed and therefore leave the comment row
empty. This was caused by the discussiob being added
to the right when it shouldnt of been

This also fixes a very rare edge case where discussions would get added
twice to diff lines causing a Vue rendering warning

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/53317
</pre>
</div>
</content>
</entry>
<entry>
<title>Fixed action &amp; mutation specs</title>
<updated>2018-10-25T11:57:08+00:00</updated>
<author>
<name>Phil Hughes</name>
<email>me@iamphill.com</email>
</author>
<published>2018-10-25T11:57:08+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=81944ec925b5bf59855ada4e73a55c30ffce0b35'/>
<id>81944ec925b5bf59855ada4e73a55c30ffce0b35</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Impove diff discussion data</title>
<updated>2018-10-24T12:30:30+00:00</updated>
<author>
<name>Phil Hughes</name>
<email>me@iamphill.com</email>
</author>
<published>2018-10-19T13:09:16+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=80a689fab83861aa412a14983411710c3f04fb15'/>
<id>80a689fab83861aa412a14983411710c3f04fb15</id>
<content type='text'>
Pre-request to https://gitlab.com/gitlab-org/gitlab-ce/issues/48956
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Pre-request to https://gitlab.com/gitlab-org/gitlab-ce/issues/48956
</pre>
</div>
</content>
</entry>
<entry>
<title>Fixed failing specs</title>
<updated>2018-10-23T08:12:37+00:00</updated>
<author>
<name>Phil Hughes</name>
<email>me@iamphill.com</email>
</author>
<published>2018-10-16T11:05:19+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=9fd5a78d8bb8be1146574fdda5920bc2ec72620a'/>
<id>9fd5a78d8bb8be1146574fdda5920bc2ec72620a</id>
<content type='text'>
Added tests to file row truncated text computed prop
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Added tests to file row truncated text computed prop
</pre>
</div>
</content>
</entry>
<entry>
<title>Add list mode to file browser in diffs</title>
<updated>2018-10-23T08:12:36+00:00</updated>
<author>
<name>Phil Hughes</name>
<email>me@iamphill.com</email>
</author>
<published>2018-10-08T10:50:22+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=2d00e7fce5b33f2a8c89dccd33d5d1758cc846c7'/>
<id>2d00e7fce5b33f2a8c89dccd33d5d1758cc846c7</id>
<content type='text'>
This adds toggle buttons to switch between file &amp; tree list.
For file list, it renders the truncated paths with the ellipsis
at the start of the path.

When focusing the input, it hides the toggle buttons.
On blur, the buttons get shown again.

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/51859
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This adds toggle buttons to switch between file &amp; tree list.
For file list, it renders the truncated paths with the ellipsis
at the start of the path.

When focusing the input, it hides the toggle buttons.
On blur, the buttons get shown again.

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/51859
</pre>
</div>
</content>
</entry>
<entry>
<title>enable jasmine/new-line-before-expect</title>
<updated>2018-10-17T04:57:29+00:00</updated>
<author>
<name>Johann Hubert Sonntagbauer</name>
<email>johann.sonntagbauer@gmail.com</email>
</author>
<published>2018-10-09T18:03:09+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=6f5723a169b5d400c136dbd844fc54c68e5f8563'/>
<id>6f5723a169b5d400c136dbd844fc54c68e5f8563</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch '51958-fix-mr-discussion-loading' into 'master'</title>
<updated>2018-10-04T07:37:24+00:00</updated>
<author>
<name>Phil Hughes</name>
<email>me@iamphill.com</email>
</author>
<published>2018-10-04T07:37:24+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=14ed916cf2ffe82ca11b8d25a88cb20f88823734'/>
<id>14ed916cf2ffe82ca11b8d25a88cb20f88823734</id>
<content type='text'>
Fix MR discussion not loaded issue

Closes #51958

See merge request gitlab-org/gitlab-ce!21982</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Fix MR discussion not loaded issue

Closes #51958

See merge request gitlab-org/gitlab-ce!21982</pre>
</div>
</content>
</entry>
<entry>
<title>Added file tree to merge request diffs</title>
<updated>2018-10-03T09:05:43+00:00</updated>
<author>
<name>Phil Hughes</name>
<email>me@iamphill.com</email>
</author>
<published>2018-10-03T09:05:43+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=33c4c5b8f30c07ff30de4cd26494becd3ad058c0'/>
<id>33c4c5b8f30c07ff30de4cd26494becd3ad058c0</id>
<content type='text'>
This file tree displays all the diff files in a tree like format
Each file is taken and converted into a tree with folders
Each folder can be toggled open &amp; closed
Clicking a file will scroll to the diff file &amp; highlight with a glow affect

Searching the tree list will search only files &amp; return a list of the
files without any folders

Each file row contains an icon to show changed, new file or deleted
Each row will also contain the added &amp; removed lines count

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/14249
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This file tree displays all the diff files in a tree like format
Each file is taken and converted into a tree with folders
Each folder can be toggled open &amp; closed
Clicking a file will scroll to the diff file &amp; highlight with a glow affect

Searching the tree list will search only files &amp; return a list of the
files without any folders

Each file row contains an icon to show changed, new file or deleted
Each row will also contain the added &amp; removed lines count

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/14249
</pre>
</div>
</content>
</entry>
<entry>
<title>Fix MR discussion not loaded issue</title>
<updated>2018-10-01T14:37:43+00:00</updated>
<author>
<name>Mark Chao</name>
<email>mchao@gitlab.com</email>
</author>
<published>2018-09-28T09:54:32+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=f09303b00aa61825d2fed22aa04d8c6d1dace1b0'/>
<id>f09303b00aa61825d2fed22aa04d8c6d1dace1b0</id>
<content type='text'>
Display `formatter` as the sole content of `position` object.
This means `diff_file` data is not referenced, which is the
caseu of "IOError: not opened for reading".
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Display `formatter` as the sole content of `position` object.
This means `diff_file` data is not referenced, which is the
caseu of "IOError: not opened for reading".
</pre>
</div>
</content>
</entry>
<entry>
<title>Fixed utils spec</title>
<updated>2018-09-21T10:59:45+00:00</updated>
<author>
<name>Phil Hughes</name>
<email>me@iamphill.com</email>
</author>
<published>2018-09-19T21:23:13+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=f1a3eff8d5852fc15ead9a8f40da0916d6286a51'/>
<id>f1a3eff8d5852fc15ead9a8f40da0916d6286a51</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
</feed>
