<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/gitlab/gitlab-ce.git/spec/javascripts/diffs/mock_data, branch docs/quick_actions</title>
<subtitle>gitlab.com: gitlab-org/gitlab-ce.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/'/>
<entry>
<title>Impove the performance of expanding full diff</title>
<updated>2019-05-03T07:33:15+00:00</updated>
<author>
<name>Phil Hughes</name>
<email>me@iamphill.com</email>
</author>
<published>2019-05-03T07:33:15+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=9d24d4a8fdd299a1e84f2e549fb58ee526a2f0f9'/>
<id>9d24d4a8fdd299a1e84f2e549fb58ee526a2f0f9</id>
<content type='text'>
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/58597
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/58597
</pre>
</div>
</content>
</entry>
<entry>
<title>Remove now-unnecessary noteable_line class</title>
<updated>2019-03-26T13:37:14+00:00</updated>
<author>
<name>Douwe Maan</name>
<email>douwe@selenight.nl</email>
</author>
<published>2019-03-23T13:34:08+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=40e3f207cbc2817c75df35ad19febb1aa76e9993'/>
<id>40e3f207cbc2817c75df35ad19febb1aa76e9993</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Add option to expand diff to full file</title>
<updated>2019-03-06T07:51:44+00:00</updated>
<author>
<name>Phil Hughes</name>
<email>me@iamphill.com</email>
</author>
<published>2019-02-28T14:14:15+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=b14de8e1f519b9b874033f783051814129af176c'/>
<id>b14de8e1f519b9b874033f783051814129af176c</id>
<content type='text'>
The user can also toggle between the diff changes and
the full file diff.

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/19054</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The user can also toggle between the diff changes and
the full file diff.

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/19054</pre>
</div>
</content>
</entry>
<entry>
<title>Replaced part of diff file properties with diff viewer</title>
<updated>2019-02-15T17:56:50+00:00</updated>
<author>
<name>Natalia Tepluhina</name>
<email>ntepluhina@gitlab.com</email>
</author>
<published>2019-02-15T17:56:50+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=bf8f32da7ffc0c8490e1920152fd1dfd214747ba'/>
<id>bf8f32da7ffc0c8490e1920152fd1dfd214747ba</id>
<content type='text'>
- replaced file.too_large
- replaced file.text
- replaced file.collapsed
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
- replaced file.too_large
- replaced file.text
- replaced file.collapsed
</pre>
</div>
</content>
</entry>
<entry>
<title>Resolve "In Merge Request diff screen, master is not a hyperlink"</title>
<updated>2019-01-16T13:18:10+00:00</updated>
<author>
<name>Natalia Tepluhina</name>
<email>ntepluhina@gitlab.com</email>
</author>
<published>2019-01-16T13:18:10+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=7407dfdc2010bce121567393f0f223b3d09cbaf0'/>
<id>7407dfdc2010bce121567393f0f223b3d09cbaf0</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Allow suggesting single line changes in diffs</title>
<updated>2018-12-13T19:17:19+00:00</updated>
<author>
<name>Oswaldo Ferreira</name>
<email>oswaldo@gitlab.com</email>
</author>
<published>2018-12-13T19:17:19+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=ed3034bbb71d43b12944a9da29b5264cb3ff3312'/>
<id>ed3034bbb71d43b12944a9da29b5264cb3ff3312</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Remove unused data from discussions endpoint</title>
<updated>2018-12-07T01:07:49+00:00</updated>
<author>
<name>Oswaldo Ferreira</name>
<email>oswaldo@gitlab.com</email>
</author>
<published>2018-12-04T22:17:10+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=26b94bcc7d510482eea253b02dcc4ff22c48d68a'/>
<id>26b94bcc7d510482eea253b02dcc4ff22c48d68a</id>
<content type='text'>
We don't need a series of attributes to render diff files on
discussions.json request. Therefore this MR removes lots of unnecessary
attributes from the request, mainly the highlighted diff lines, which
are pretty expensive.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
We don't need a series of attributes to render diff files on
discussions.json request. Therefore this MR removes lots of unnecessary
attributes from the request, mainly the highlighted diff lines, which
are pretty expensive.
</pre>
</div>
</content>
</entry>
<entry>
<title>Made diff &amp; note data consistent</title>
<updated>2018-11-14T19:16:46+00:00</updated>
<author>
<name>Phil Hughes</name>
<email>me@iamphill.com</email>
</author>
<published>2018-11-09T19:48:41+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=234563ba30d759870cb33d479116becb85e06eca'/>
<id>234563ba30d759870cb33d479116becb85e06eca</id>
<content type='text'>
This caused many pain points when working with it.
Part of the data was camel cased the other snake case.
Other parts where snake case &amp; then getting converted in components,
this conversion has the potential for leaking memory.

This changes that &amp; makes it consistent with what it returned from the
API, snake case.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This caused many pain points when working with it.
Part of the data was camel cased the other snake case.
Other parts where snake case &amp; then getting converted in components,
this conversion has the potential for leaking memory.

This changes that &amp; makes it consistent with what it returned from the
API, snake case.
</pre>
</div>
</content>
</entry>
<entry>
<title>Restored width &amp; height properties</title>
<updated>2018-11-06T10:17:59+00:00</updated>
<author>
<name>Phil Hughes</name>
<email>me@iamphill.com</email>
</author>
<published>2018-11-06T09:40:03+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=35faecb06b4b921d12a62344976918e88cd73fca'/>
<id>35faecb06b4b921d12a62344976918e88cd73fca</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Re-implemented image commenting on diffs</title>
<updated>2018-11-05T14:02:41+00:00</updated>
<author>
<name>Phil Hughes</name>
<email>me@iamphill.com</email>
</author>
<published>2018-10-18T07:50:38+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=f7df9ddb52be8a03b8fbd8c9a870f3e3af577562'/>
<id>f7df9ddb52be8a03b8fbd8c9a870f3e3af577562</id>
<content type='text'>
This re-implements image commenting in merge request diffs.
This feature was previously lost when the merge request
page was refactored into Vue.

With this, we create an overlay component. The overlay
component handles displaying the comment badges
and the comment form badge.
Badges are displayed based on the position attribute
sent with the discussion.

Comment forms for diff files are controlled through
a different state property. This is so we don't
tie comment forms to diff files directly creating
deep nested state. Instead we create a flat array
which holds the file hash &amp; the X &amp; Y position of
the comment form.

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/48956
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This re-implements image commenting in merge request diffs.
This feature was previously lost when the merge request
page was refactored into Vue.

With this, we create an overlay component. The overlay
component handles displaying the comment badges
and the comment form badge.
Badges are displayed based on the position attribute
sent with the discussion.

Comment forms for diff files are controlled through
a different state property. This is so we don't
tie comment forms to diff files directly creating
deep nested state. Instead we create a flat array
which holds the file hash &amp; the X &amp; Y position of
the comment form.

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/48956
</pre>
</div>
</content>
</entry>
</feed>
