<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/gitlab/gitlab-ce.git/spec/javascripts/diffs/components/app_spec.js, branch patch-63</title>
<subtitle>gitlab.com: gitlab-org/gitlab-ce.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/'/>
<entry>
<title>Fixed fluid layout preference not being respected in diffs</title>
<updated>2019-04-12T08:32:05+00:00</updated>
<author>
<name>Phil Hughes</name>
<email>me@iamphill.com</email>
</author>
<published>2019-04-12T08:32:05+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=45ef6fd77710b29dc3fb1d413eb819ad47f154e5'/>
<id>45ef6fd77710b29dc3fb1d413eb819ad47f154e5</id>
<content type='text'>
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/52916
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/52916
</pre>
</div>
</content>
</entry>
<entry>
<title>Improve diff navigation header</title>
<updated>2019-04-05T18:57:01+00:00</updated>
<author>
<name>Sam Bigelow</name>
<email>sbigelow@gitlab.com</email>
</author>
<published>2019-03-28T21:37:06+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=bf47270e9072fccc1bc9575b4d70b9d5c8ac021f'/>
<id>bf47270e9072fccc1bc9575b4d70b9d5c8ac021f</id>
<content type='text'>
- Compare versions header is full width except in the unified diff mode
with no tree sidebar
  - Bar is always full width, but the content within stays centered when
unified and no tree sidebar
- File header is the same height as the "Compare versions header"
- aligns with the design system grid guidelines =&gt; 56px
- Diff file headers use a button group, switch icon order to open file
externally being the last option, all buttons will become icon buttons
(icon delivery by @dimitrieh)
- If a file header becomes sticky no rounded corner/double border
problem is visible anymore
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
- Compare versions header is full width except in the unified diff mode
with no tree sidebar
  - Bar is always full width, but the content within stays centered when
unified and no tree sidebar
- File header is the same height as the "Compare versions header"
- aligns with the design system grid guidelines =&gt; 56px
- Diff file headers use a button group, switch icon order to open file
externally being the last option, all buttons will become icon buttons
(icon delivery by @dimitrieh)
- If a file header becomes sticky no rounded corner/double border
problem is visible anymore
</pre>
</div>
</content>
</entry>
<entry>
<title>Collapse diff tree is only one file is present</title>
<updated>2019-03-19T11:34:21+00:00</updated>
<author>
<name>Phil Hughes</name>
<email>me@iamphill.com</email>
</author>
<published>2019-03-19T11:34:21+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=27fa7b9ca897c77e45878f3fecb7debe8f8cd64c'/>
<id>27fa7b9ca897c77e45878f3fecb7debe8f8cd64c</id>
<content type='text'>
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/53139
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/53139
</pre>
</div>
</content>
</entry>
<entry>
<title>Resolve "Add missing karma tests to the the MR Diff components"</title>
<updated>2019-02-28T08:23:17+00:00</updated>
<author>
<name>Natalia Tepluhina</name>
<email>ntepluhina@gitlab.com</email>
</author>
<published>2019-02-28T08:23:17+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=edfdf568d3ef121ef696f769f6d57a334c961871'/>
<id>edfdf568d3ef121ef696f769f6d57a334c961871</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Set up basic keyboard next/previous navigation in diff list</title>
<updated>2019-02-27T09:12:13+00:00</updated>
<author>
<name>Denys Mishunov</name>
<email>dmishunov@gitlab.com</email>
</author>
<published>2019-02-27T09:12:13+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=0aff8e27530d391e4c819838b46d77f6231ecf70'/>
<id>0aff8e27530d391e4c819838b46d77f6231ecf70</id>
<content type='text'>
Mousetrap is used as the help-tool to listen to keystrokes

Added currentDiffIndex getter to store that holds
the index of currently active diff file in the list

Instead of computing it on the component, we will take advantage of it
being available for all components in DiffsApp

Testing keyboard navigation and jumpToFile()
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Mousetrap is used as the help-tool to listen to keystrokes

Added currentDiffIndex getter to store that holds
the index of currently active diff file in the list

Instead of computing it on the component, we will take advantage of it
being available for all components in DiffsApp

Testing keyboard navigation and jumpToFile()
</pre>
</div>
</content>
</entry>
<entry>
<title>Make the file tree in merge requests resizable</title>
<updated>2019-02-15T10:33:33+00:00</updated>
<author>
<name>Phil Hughes</name>
<email>me@iamphill.com</email>
</author>
<published>2019-02-15T10:25:33+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=d17de657fe782eb838545aabeee00285e181dce1'/>
<id>d17de657fe782eb838545aabeee00285e181dce1</id>
<content type='text'>
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/51857
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/51857
</pre>
</div>
</content>
</entry>
<entry>
<title>Fix diff changes empty state</title>
<updated>2018-12-13T10:57:45+00:00</updated>
<author>
<name>Phil Hughes</name>
<email>me@iamphill.com</email>
</author>
<published>2018-12-13T10:57:45+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=ee2f3cac35e630cb5d5aef93752e3eb28b6852c2'/>
<id>ee2f3cac35e630cb5d5aef93752e3eb28b6852c2</id>
<content type='text'>
The empty state now only gets shown when no files exist in the branch.
If the user is reviewing 2 versions with no files, we don't show the state.

Refactors the diff app spec to use Vue test utils.

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/48635
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The empty state now only gets shown when no files exist in the branch.
If the user is reviewing 2 versions with no files, we don't show the state.

Refactors the diff app spec to use Vue test utils.

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/48635
</pre>
</div>
</content>
</entry>
<entry>
<title>Resolve "Merge request refactor does not highlight selected line"</title>
<updated>2018-11-30T08:48:47+00:00</updated>
<author>
<name>Sam Bigelow</name>
<email>sbigelow@gitlab.com</email>
</author>
<published>2018-11-30T08:48:47+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=44a0121ad4a0851d7b7c723afebd3c4b07adc6c3'/>
<id>44a0121ad4a0851d7b7c723afebd3c4b07adc6c3</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Show toggle tree button on merge request commits</title>
<updated>2018-11-22T12:04:18+00:00</updated>
<author>
<name>Phil Hughes</name>
<email>me@iamphill.com</email>
</author>
<published>2018-11-20T12:37:57+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=93c614ce9243c0743176a6e406a55f9dcb9bedf3'/>
<id>93c614ce9243c0743176a6e406a55f9dcb9bedf3</id>
<content type='text'>
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/53019
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/53019
</pre>
</div>
</content>
</entry>
<entry>
<title>Prettify all spec files</title>
<updated>2018-10-17T16:18:17+00:00</updated>
<author>
<name>Mike Greiling</name>
<email>mike@pixelcog.com</email>
</author>
<published>2018-10-17T07:13:26+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=f666026d71ebefd70219d5078b1f0c83fa01f84d'/>
<id>f666026d71ebefd70219d5078b1f0c83fa01f84d</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
</feed>
