<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/gitlab/gitlab-ce.git/spec/initializers, branch diff-notes-refactor</title>
<subtitle>gitlab.com: gitlab-org/gitlab-ce.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/'/>
<entry>
<title>Add metric initializer spec</title>
<updated>2017-01-24T14:42:57+00:00</updated>
<author>
<name>Sean McGivern</name>
<email>sean@gitlab.com</email>
</author>
<published>2017-01-23T14:41:32+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=a96765e6274b9b6886ee6172d25d47a9d36f18c6'/>
<id>a96765e6274b9b6886ee6172d25d47a9d36f18c6</id>
<content type='text'>
An empty file in one of the instrumented directories will cause the app
to fail to start when metrics are enabled. Metrics aren't enabled by
default in development or test.

We could handle the empty file case explicitly, but a file could still
not define the constant it is expected to, so instead run the
initializer manually in a spec and check that it succeeds.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
An empty file in one of the instrumented directories will cause the app
to fail to start when metrics are enabled. Metrics aren't enabled by
default in development or test.

We could handle the empty file case explicitly, but a file could still
not define the constant it is expected to, so instead run the
initializer manually in a spec and check that it succeeds.
</pre>
</div>
</content>
</entry>
<entry>
<title>Introduce "stub_env" test helper for safely stubbing environment variables</title>
<updated>2017-01-09T17:19:48+00:00</updated>
<author>
<name>Adam Niedzielski</name>
<email>adamsunday@gmail.com</email>
</author>
<published>2017-01-09T17:19:48+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=a8177e03e5eeade5b8af405dbb4bcd8a6d06bb0a'/>
<id>a8177e03e5eeade5b8af405dbb4bcd8a6d06bb0a</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Give priority to environment variables</title>
<updated>2016-08-03T14:48:48+00:00</updated>
<author>
<name>Sean McGivern</name>
<email>sean@gitlab.com</email>
</author>
<published>2016-07-19T14:12:40+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=90565b5f95ce3d6d0b81078fe9fa9a9f196b4cde'/>
<id>90565b5f95ce3d6d0b81078fe9fa9a9f196b4cde</id>
<content type='text'>
If an environment variable exists for secret_key_base, use that -
always. But don't save it to secrets.yml.

Also ensure that we never write to secrets.yml if there's a non-blank
value there.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
If an environment variable exists for secret_key_base, use that -
always. But don't save it to secrets.yml.

Also ensure that we never write to secrets.yml if there's a non-blank
value there.
</pre>
</div>
</content>
</entry>
<entry>
<title>Store all secret keys in secrets.yml</title>
<updated>2016-08-03T14:48:47+00:00</updated>
<author>
<name>Sean McGivern</name>
<email>sean@gitlab.com</email>
</author>
<published>2016-07-17T10:01:38+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=379c2cbcbd1544a1f80135c491937dabb04821df'/>
<id>379c2cbcbd1544a1f80135c491937dabb04821df</id>
<content type='text'>
Move the last secret from .secret to config/secrets.yml, and delete
.secret if it exists.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Move the last secret from .secret to config/secrets.yml, and delete
.secret if it exists.
</pre>
</div>
</content>
</entry>
<entry>
<title>Store OTP secret key in secrets.yml</title>
<updated>2016-08-03T14:46:37+00:00</updated>
<author>
<name>Sean McGivern</name>
<email>sean@gitlab.com</email>
</author>
<published>2016-07-15T12:19:29+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=405379bbfcb7821b3dae77e5254362f2d696bb7d'/>
<id>405379bbfcb7821b3dae77e5254362f2d696bb7d</id>
<content type='text'>
.secret stores the secret token used for both encrypting login cookies
and for encrypting stored OTP secrets. We can't rotate this, because
that would invalidate all existing OTP secrets.

If the secret token is present in the .secret file or an environment
variable, save it as otp_key_base in secrets.yml. Now .secret can be
rotated without invalidating OTP secrets.

If the secret token isn't present (initial setup), then just generate a
separate otp_key_base and save in secrets.yml.

Update the docs to reflect that secrets.yml needs to be retained past
upgrades, but .secret doesn't.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
.secret stores the secret token used for both encrypting login cookies
and for encrypting stored OTP secrets. We can't rotate this, because
that would invalidate all existing OTP secrets.

If the secret token is present in the .secret file or an environment
variable, save it as otp_key_base in secrets.yml. Now .secret can be
rotated without invalidating OTP secrets.

If the secret token isn't present (initial setup), then just generate a
separate otp_key_base and save in secrets.yml.

Update the docs to reflect that secrets.yml needs to be retained past
upgrades, but .secret doesn't.
</pre>
</div>
</content>
</entry>
<entry>
<title>Ignore invalid IPs in X-Forwarded-For when trusted proxies are configured.</title>
<updated>2016-07-31T19:36:11+00:00</updated>
<author>
<name>lookatmike</name>
<email>cisephys@gmail.com</email>
</author>
<published>2016-07-31T19:36:11+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=ae108ff703a8b9e73f2a260806c89eccac5a6cf6'/>
<id>ae108ff703a8b9e73f2a260806c89eccac5a6cf6</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Ignore invalid trusted proxies in X-Forwarded-For header</title>
<updated>2016-07-24T04:06:19+00:00</updated>
<author>
<name>Stan Hu</name>
<email>stanhu@gmail.com</email>
</author>
<published>2016-07-24T04:01:23+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=8d73c7613178f5d46ff91a81f7783ca907deb64a'/>
<id>8d73c7613178f5d46ff91a81f7783ca907deb64a</id>
<content type='text'>
Certain reverse proxies can send invalid IP addresses in the X-Forwarded-For header
For example, Apache can send (null).

Closes #20194
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Certain reverse proxies can send invalid IP addresses in the X-Forwarded-For header
For example, Apache can send (null).

Closes #20194
</pre>
</div>
</content>
</entry>
<entry>
<title>Skip repository storage path valitaions on test environment</title>
<updated>2016-07-21T22:33:51+00:00</updated>
<author>
<name>Alejandro Rodríguez</name>
<email>alejorro70@gmail.com</email>
</author>
<published>2016-07-18T21:28:26+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=89589007aee6780c3dea2d44df12e9509a22f975'/>
<id>89589007aee6780c3dea2d44df12e9509a22f975</id>
<content type='text'>
Storage path are not created until `TestEnv.init`, so we must skip
their validation on initialization.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Storage path are not created until `TestEnv.init`, so we must skip
their validation on initialization.
</pre>
</div>
</content>
</entry>
<entry>
<title>Use Pathname to make the repository storage path validations more robust</title>
<updated>2016-07-21T22:29:56+00:00</updated>
<author>
<name>Alejandro Rodríguez</name>
<email>alejorro70@gmail.com</email>
</author>
<published>2016-07-12T01:29:13+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=72f59ddf4c9d276bd565892c0cf79d5622906090'/>
<id>72f59ddf4c9d276bd565892c0cf79d5622906090</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Enable Style/EmptyLines cop, remove redundant ones</title>
<updated>2016-07-01T19:56:17+00:00</updated>
<author>
<name>Grzegorz Bizon</name>
<email>grzesiek.bizon@gmail.com</email>
</author>
<published>2016-07-01T19:56:17+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=9e211091a85c20adea63b89111240350d6d8ffcb'/>
<id>9e211091a85c20adea63b89111240350d6d8ffcb</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
</feed>
