<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/gitlab/gitlab-ce.git/spec/helpers, branch docs/edit-after-script-context</title>
<subtitle>gitlab.com: gitlab-org/gitlab-ce.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/'/>
<entry>
<title>Set project default visibility to max allowed</title>
<updated>2019-06-05T23:43:31+00:00</updated>
<author>
<name>Stan Hu</name>
<email>stanhu@gmail.com</email>
</author>
<published>2019-05-26T05:42:42+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=f8d93b24822937d803da4c9fcc89d50c85de89c7'/>
<id>f8d93b24822937d803da4c9fcc89d50c85de89c7</id>
<content type='text'>
If the default, instance-wide visibility were set to internal but a
group were private, the radio button would be set on internal even
though that setting were not allowed. We now consider the allowed
visibility setting for the group in determining what the default should
be.

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/62298
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
If the default, instance-wide visibility were set to internal but a
group were private, the radio button would be set on internal even
though that setting were not allowed. We now consider the allowed
visibility setting for the group in determining what the default should
be.

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/62298
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch '54140-non-ar-cache-commit-markdown' into 'master'</title>
<updated>2019-06-05T16:30:51+00:00</updated>
<author>
<name>Douwe Maan</name>
<email>douwe@gitlab.com</email>
</author>
<published>2019-06-05T16:30:51+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=e7b6dace063fce593e6f9ac61390e7385a9868a1'/>
<id>e7b6dace063fce593e6f9ac61390e7385a9868a1</id>
<content type='text'>
Use Redis for CacheMarkDownField on non AR models

Closes #54140

See merge request gitlab-org/gitlab-ce!29054</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Use Redis for CacheMarkDownField on non AR models

Closes #54140

See merge request gitlab-org/gitlab-ce!29054</pre>
</div>
</content>
</entry>
<entry>
<title>Add snowplow haml attr helper</title>
<updated>2019-06-05T16:28:41+00:00</updated>
<author>
<name>Luke Bennett</name>
<email>lbennett@gitlab.com</email>
</author>
<published>2019-06-05T16:28:41+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=0b0f39c5737265eb796040d13f6411f0c6b17708'/>
<id>0b0f39c5737265eb796040d13f6411f0c6b17708</id>
<content type='text'>
Helps build a hash of snowplow tracking data attrs.
Updates import project pane to use new helper.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Helps build a hash of snowplow tracking data attrs.
Updates import project pane to use new helper.
</pre>
</div>
</content>
</entry>
<entry>
<title>Use Redis for CacheMarkDownField on non AR models</title>
<updated>2019-06-05T05:19:59+00:00</updated>
<author>
<name>Patrick Bajao</name>
<email>ebajao@gitlab.com</email>
</author>
<published>2019-06-05T04:59:48+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=2eecfd8f9d111c6518930b818a16daea8263b37f'/>
<id>2eecfd8f9d111c6518930b818a16daea8263b37f</id>
<content type='text'>
This allows using `CacheMarkdownField` for models that are not backed
by ActiveRecord.

When the including class inherits `ActiveRecord::Base` we include
`Gitlab::MarkdownCache::ActiveRecord::Extension`. This will cause the
markdown fields to be rendered and the generated HTML stored in a
`&lt;field&gt;_html` attribute on the record. We also store the version
used for generating the markdown.

All other classes that include this model will include the
`Gitlab::MarkdownCache::Redis::Extension`. This add the `&lt;field&gt;_html`
attributes to that model and will generate the html in them. The
generated HTML will be cached in redis under the key
`markdown_cache:&lt;class&gt;:&lt;id&gt;`. The class this included in must
therefore respond to `id`.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This allows using `CacheMarkdownField` for models that are not backed
by ActiveRecord.

When the including class inherits `ActiveRecord::Base` we include
`Gitlab::MarkdownCache::ActiveRecord::Extension`. This will cause the
markdown fields to be rendered and the generated HTML stored in a
`&lt;field&gt;_html` attribute on the record. We also store the version
used for generating the markdown.

All other classes that include this model will include the
`Gitlab::MarkdownCache::Redis::Extension`. This add the `&lt;field&gt;_html`
attributes to that model and will generate the html in them. The
generated HTML will be cached in redis under the key
`markdown_cache:&lt;class&gt;:&lt;id&gt;`. The class this included in must
therefore respond to `id`.
</pre>
</div>
</content>
</entry>
<entry>
<title>Change s_() calls to _() calls</title>
<updated>2019-06-04T09:56:32+00:00</updated>
<author>
<name>Michał Zając</name>
<email>gitlab.com@quintasan.pl</email>
</author>
<published>2019-06-04T09:56:32+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=e72efed323741d0f934b79aae812c1bea57d244b'/>
<id>e72efed323741d0f934b79aae812c1bea57d244b</id>
<content type='text'>
There are no namespaces in the strings so we don't need those
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
There are no namespaces in the strings so we don't need those
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'dz-scope-project-routes-3' into 'master'</title>
<updated>2019-05-31T15:53:04+00:00</updated>
<author>
<name>Lin Jen-Shin</name>
<email>godfat@godfat.org</email>
</author>
<published>2019-05-31T15:53:04+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=d7b277df46ffa3723a16159878958f9a825315e6'/>
<id>d7b277df46ffa3723a16159878958f9a825315e6</id>
<content type='text'>
Move some project routes under - scope

See merge request gitlab-org/gitlab-ce!28830</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Move some project routes under - scope

See merge request gitlab-org/gitlab-ce!28830</pre>
</div>
</content>
</entry>
<entry>
<title>Add wiki size to project statistics</title>
<updated>2019-05-29T14:08:25+00:00</updated>
<author>
<name>Peter Marko</name>
<email>peter.marko@siemens.com</email>
</author>
<published>2019-02-13T22:38:11+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=40490cc4922fedbf4512109429cdc2c5aed65ded'/>
<id>40490cc4922fedbf4512109429cdc2c5aed65ded</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Make external_dashboard_url available to frontend</title>
<updated>2019-05-29T13:36:36+00:00</updated>
<author>
<name>Reuben Pereira</name>
<email>rpereira@gitlab.com</email>
</author>
<published>2019-05-29T13:36:36+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=5c088584eccf89f389866d37a1c18400c002eaf8'/>
<id>5c088584eccf89f389866d37a1c18400c002eaf8</id>
<content type='text'>
- On Operations settings page
- On Metrics dashboard page
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
- On Operations settings page
- On Metrics dashboard page
</pre>
</div>
</content>
</entry>
<entry>
<title>Fix specs after routing change</title>
<updated>2019-05-29T13:31:04+00:00</updated>
<author>
<name>Dmitriy Zaporozhets</name>
<email>dmitriy.zaporozhets@gmail.com</email>
</author>
<published>2019-05-29T10:45:27+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=c1b142b86744e7709e8557931f4e8adba706410a'/>
<id>c1b142b86744e7709e8557931f4e8adba706410a</id>
<content type='text'>
Signed-off-by: Dmitriy Zaporozhets &lt;dmitriy.zaporozhets@gmail.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Signed-off-by: Dmitriy Zaporozhets &lt;dmitriy.zaporozhets@gmail.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Fix display of promote to group label</title>
<updated>2019-05-28T10:05:20+00:00</updated>
<author>
<name>Jan Provaznik</name>
<email>jprovaznik@gitlab.com</email>
</author>
<published>2019-05-28T10:05:20+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=4df0e2599bc9bd7c50b6acea02278c1fb97d3ead'/>
<id>4df0e2599bc9bd7c50b6acea02278c1fb97d3ead</id>
<content type='text'>
Since label presenter is used in label index view, label class
check doesn't work as expected because the class is now LabelPresenter.

Also `label.subject` doesn't work as expected now because Label's model
`subject` method is shadowed by Gitlab's presenter's method which uses
`subject` for referencing the original object.

Instead we use a presenter's method for both checks now.

`label_deletion_confirm_text` is not used anywhere so it's removed
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Since label presenter is used in label index view, label class
check doesn't work as expected because the class is now LabelPresenter.

Also `label.subject` doesn't work as expected now because Label's model
`subject` method is shadowed by Gitlab's presenter's method which uses
`subject` for referencing the original object.

Instead we use a presenter's method for both checks now.

`label_deletion_confirm_text` is not used anywhere so it's removed
</pre>
</div>
</content>
</entry>
</feed>
