<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/gitlab/gitlab-ce.git/spec/finders/autocomplete, branch docs-pages-force-https</title>
<subtitle>gitlab.com: gitlab-org/gitlab-ce.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/'/>
<entry>
<title>Return all runner tags when search is empty</title>
<updated>2019-06-24T13:44:04+00:00</updated>
<author>
<name>Dmitriy Zaporozhets</name>
<email>dmitriy.zaporozhets@gmail.com</email>
</author>
<published>2019-06-24T12:04:07+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=f928c22ff0952cd6a358ae0102aa45c58c2478aa'/>
<id>f928c22ff0952cd6a358ae0102aa45c58c2478aa</id>
<content type='text'>
Signed-off-by: Dmitriy Zaporozhets &lt;dmitriy.zaporozhets@gmail.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Signed-off-by: Dmitriy Zaporozhets &lt;dmitriy.zaporozhets@gmail.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Only show in autocomplete when author active</title>
<updated>2019-04-12T06:58:42+00:00</updated>
<author>
<name>Wei-Meng Lee</name>
<email>wlee@gitlab.com</email>
</author>
<published>2019-04-12T03:59:09+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=3ef5666783b220422283e4d5acbcbbbfac1e935a'/>
<id>3ef5666783b220422283e4d5acbcbbbfac1e935a</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>make assertions on objects instead of tag names</title>
<updated>2019-02-27T19:20:24+00:00</updated>
<author>
<name>Alexis Reigel</name>
<email>alexis.reigel.ext@siemens.com</email>
</author>
<published>2019-02-21T19:26:54+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=0853c234fc39dcfd70175d86990089712c462d58'/>
<id>0853c234fc39dcfd70175d86990089712c462d58</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>don't filter tags by taggable type</title>
<updated>2019-02-27T19:19:50+00:00</updated>
<author>
<name>Alexis Reigel</name>
<email>alexis.reigel.ext@siemens.com</email>
</author>
<published>2018-12-11T08:43:34+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=022ee0c0c91d30dea3c1c0472525e86ec8379827'/>
<id>022ee0c0c91d30dea3c1c0472525e86ec8379827</id>
<content type='text'>
Due to performance reasons we cannot use the type filter on the tags.
The table for ActsAsTaggableOn is too big and too unoptimized, such that
the queries time out on production.

See the discussion
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/19740#note_120087938
for more info.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Due to performance reasons we cannot use the type filter on the tags.
The table for ActsAsTaggableOn is too big and too unoptimized, such that
the queries time out on production.

See the discussion
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/19740#note_120087938
for more info.
</pre>
</div>
</content>
</entry>
<entry>
<title>use lazy ajax filter dropdown for runner tags</title>
<updated>2019-02-27T19:19:49+00:00</updated>
<author>
<name>Alexis Reigel</name>
<email>alexis.reigel.ext@siemens.com</email>
</author>
<published>2018-11-15T15:10:10+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=2e05292562e71deeff9b76bd3c696eca2a65a491'/>
<id>2e05292562e71deeff9b76bd3c696eca2a65a491</id>
<content type='text'>
the potential number of available runner tags is too large to load it
statically to a dropdown. we use the same lazy loaded dropdown as is
used for the users dropdown already.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
the potential number of available runner tags is too large to load it
statically to a dropdown. we use the same lazy loaded dropdown as is
used for the users dropdown already.
</pre>
</div>
</content>
</entry>
<entry>
<title>Refactor AutocompleteController</title>
<updated>2018-08-20T11:53:00+00:00</updated>
<author>
<name>Yorick Peterse</name>
<email>yorickpeterse@gmail.com</email>
</author>
<published>2018-07-30T15:45:49+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=6f3c490107f5fa7dd00bce0bbd89e4a0fa4d6389'/>
<id>6f3c490107f5fa7dd00bce0bbd89e4a0fa4d6389</id>
<content type='text'>
This refactors the AutocompleteController according to the guidelines
and boundaries discussed in
https://gitlab.com/gitlab-org/gitlab-ce/issues/49653. Specifically,
ActiveRecord logic is moved to different finders, which are then used in
the controller. View logic in turn is moved to presenters, instead of
directly using ActiveRecord's "to_json" method.

The finder MoveToProjectFinder is also adjusted according to the
abstraction guidelines and boundaries, resulting in a much more simple
finder.

By using finders (and other abstractions) more actively, we can push a
lot of logic out of the controller. We also remove the need for various
"before_action" hooks, though this could be achieved without using
finders as well.

The various finders related to AutcompleteController have also been
moved into a namespace. This removes the need for calling everything
"AutocompleteSmurfFinder", instead you can use
"Autocomplete::SmurfFinder".
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This refactors the AutocompleteController according to the guidelines
and boundaries discussed in
https://gitlab.com/gitlab-org/gitlab-ce/issues/49653. Specifically,
ActiveRecord logic is moved to different finders, which are then used in
the controller. View logic in turn is moved to presenters, instead of
directly using ActiveRecord's "to_json" method.

The finder MoveToProjectFinder is also adjusted according to the
abstraction guidelines and boundaries, resulting in a much more simple
finder.

By using finders (and other abstractions) more actively, we can push a
lot of logic out of the controller. We also remove the need for various
"before_action" hooks, though this could be achieved without using
finders as well.

The various finders related to AutcompleteController have also been
moved into a namespace. This removes the need for calling everything
"AutocompleteSmurfFinder", instead you can use
"Autocomplete::SmurfFinder".
</pre>
</div>
</content>
</entry>
</feed>
