delta/gitlab/gitlab-ce.git/spec/features, branch commit-message-contribution gitlab.com: gitlab-org/gitlab-ce.git Merge branch 'pmq20/gitlab-ce-issue_12785' 2016-04-19T16:25:42+00:00 Douwe Maan douwe@selenight.nl 2016-04-19T16:25:42+00:00 55380e69fcd070751a26e368da55968fa3f57419 






Merge branch 'rs-issue-15126' into 'master'

2016-04-19T15:16:00+00:00

Douwe Maan
douwe@gitlab.com

2016-04-19T15:16:00+00:00

60942bf581d61d7e64bea9aa5be808a3fde11ace


Remove persistent XSS vulnerability in `commit_person_link` helper

Because we were incorrectly supplying the tooltip title as
`data-original-title` (which Bootstrap's Tooltip JS automatically
applies based on the `title` attribute; we should never be setting it
directly), the value was being passed through as-is.

Instead, we should be supplying the normal `title` attribute and letting
Rails escape the value, which also negates the need for us to call
`sanitize` on it.

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/15126

See merge request !1948





Remove persistent XSS vulnerability in `commit_person_link` helper

Because we were incorrectly supplying the tooltip title as
`data-original-title` (which Bootstrap's Tooltip JS automatically
applies based on the `title` attribute; we should never be setting it
directly), the value was being passed through as-is.

Instead, we should be supplying the normal `title` attribute and letting
Rails escape the value, which also negates the need for us to call
`sanitize` on it.

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/15126

See merge request !1948






Use different markdown
2016-04-19T11:39:53+00:00

Kamil Trzcinski
ayufan@ayufan.eu

2016-04-19T11:39:53+00:00

d58d88fbd5dca6efdb95d5e07ad0b1c6f43bb565












Remove additional misuse of `data-original-title` attribute
2016-04-18T15:40:24+00:00

Robert Speicher
rspeicher@gmail.com

2016-04-18T15:40:24+00:00

17a730178def129d49e92d7a9a1b309efc67c755












Update according to review comments
2016-04-18T13:56:38+00:00

Kamil Trzcinski
ayufan@ayufan.eu

2016-04-18T13:56:38+00:00

21041525af5a678053cc47e082dc7484a67dfdf5












Add configurable shared runners text
2016-04-18T13:54:52+00:00

Kamil Trzcinski
ayufan@ayufan.eu

2016-04-15T13:51:41+00:00

6b124d42d9861a5f8c3dd5add7cabc864fa3673c












Add support to cherry-pick any commit
2016-04-18T07:39:07+00:00

P.S.V.R
pmq2001@gmail.com

2016-04-18T07:39:07+00:00

3d6ba3b1076e68a67691d0e0de24ef97cc07f119

Issue: https://gitlab.com/gitlab-org/gitlab-ce/issues/12785
Merge Request: https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/3514





Issue: https://gitlab.com/gitlab-org/gitlab-ce/issues/12785
Merge Request: https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/3514







Add acceptance test to check if the user password persists after form redisplays.
2016-04-18T06:49:11+00:00

Timothy Andrew
mail@timothyandrew.net

2016-04-18T06:49:11+00:00

40bc8e7677cb27f87fef7d4362fbd17bee8980ef

- While signing up.





- While signing up.







Merge branch 'fix-issue-dropzone' into 'master'

2016-04-18T03:02:12+00:00

Stan Hu
stanhu@gmail.com

2016-04-18T03:02:12+00:00

e9f20f5922e9c365b4af14e53881a7bafba4139c


Fixed issue with dropzone not working on new issuable

Closes #15295

See merge request !3760





Fixed issue with dropzone not working on new issuable

Closes #15295

See merge request !3760






Added upload file test to new issue form
2016-04-17T11:15:45+00:00

Phil Hughes
me@iamphill.com

2016-04-17T11:15:45+00:00

0be158a0725c254629e7e4e5de194021322e2fa9