delta/gitlab/gitlab-ce.git/spec/features, branch backport-gitlab-database gitlab.com: gitlab-org/gitlab-ce.git Merge branch 'blackst0ne-replace-sidekiq-inline-with-perform-enqueued-jobs' into 'master' 2018-07-23T16:09:29+00:00 Rémy Coutable remy@rymai.me 2018-07-23T16:09:29+00:00 92802e51075f485ce2aa80d19f40688f1dd95fb7 Replace 'Sidekiq::Testing.inline!' with 'perform_enqueued_jobs' Closes #22991 See merge request gitlab-org/gitlab-ce!20768 
Replace 'Sidekiq::Testing.inline!' with 'perform_enqueued_jobs'

Closes #22991

See merge request gitlab-org/gitlab-ce!20768
 Merge branch '29278-commits-page-tooltips' into 'master' 2018-07-23T15:55:12+00:00 Annabel Gray annabel.m.gray@gmail.com 2018-07-23T15:55:12+00:00 f0b1780f4517530ed540be5dd48a6f43bf75af3b Resolve "Commits page tooltips" Closes #29278 See merge request gitlab-org/gitlab-ce!20674 
Resolve "Commits page tooltips"

Closes #29278

See merge request gitlab-org/gitlab-ce!20674
 Replace 'Sidekiq::Testing.inline!' with 'perform_enqueued_jobs' 2018-07-23T04:34:54+00:00 blackst0ne blackst0ne.ru@gmail.com 2018-07-23T04:34:54+00:00 ddd2a25679f1d875332f603f115e25577b05a5a2 `perform_enqueued_jobs` is a Sidekiq method. Using this method violates the Dependency inversion principle[0]. This commit replaces `perform_enqueued_jobs` with ActiveJob's abstract method `perform_enqueued_jobs` in specs. [0]: https://en.wikipedia.org/wiki/Dependency_inversion_principle 
`perform_enqueued_jobs` is a Sidekiq method.
Using this method violates the Dependency inversion principle[0].

This commit replaces `perform_enqueued_jobs` with ActiveJob's abstract
method `perform_enqueued_jobs` in specs.

[0]: https://en.wikipedia.org/wiki/Dependency_inversion_principle
Merge branch '_acet-fix-spec' into 'master' 2018-07-20T21:26:25+00:00 Tim Zallmann tzallmann@gitlab.com 2018-07-20T21:26:25+00:00 2ec7b5182de8716876438786dc30d19f114eb878 Fix one disabled spec of comment posting. See merge request gitlab-org/gitlab-ce!20747 
Fix one disabled spec of comment posting.

See merge request gitlab-org/gitlab-ce!20747
 Resolve ""Jump to first/next unresolved discussion" jumps to resolved discussions" 2018-07-20T15:24:46+00:00 André Luís me@andr3.net 2018-07-20T15:24:46+00:00 f2f8ddf4ccc43c86d8432a63b11aba8b216afd41 






Fix one disabled spec of comment posting.
2018-07-20T13:50:26+00:00

Fatih Acet
acetfatih@gmail.com

2018-07-20T13:50:26+00:00

85b982a4c57fe0870d2b9a119e1d4e8d56ff2c10












fix user_browses_commits_spec
2018-07-20T12:25:31+00:00

Luke Bennett
lukeeeebennettplus@gmail.com

2018-07-20T12:25:31+00:00

362e9e40b131c896e2c3545248752ae84e9635d5












Rails5 fix user sees revert modal spec
2018-07-19T08:07:38+00:00

Jasper Maes
jaspermaes.jm@gmail.com

2018-07-19T07:43:27+00:00

76abd6d3a154785a2f22f6eb681c03e1372cc1a6












Merge branch '47419-Fix-breadcrumbs' into 'master'
2018-07-18T07:01:49+00:00

Phil Hughes
me@iamphill.com

2018-07-18T07:01:49+00:00

f97c4425ebc3c2dc0549d0bcae91e977cc92d2fc

Resolve "broken breadcrumb in admin/user when switching tabs"

Closes #47419

See merge request gitlab-org/gitlab-ce!19608




Resolve "broken breadcrumb in admin/user when switching tabs"

Closes #47419

See merge request gitlab-org/gitlab-ce!19608






Fix broken breadcrumb in admin/user
2018-07-17T17:50:01+00:00

Robin Naundorf
r.naundorf@fh-muenster.de

2018-06-09T06:45:05+00:00

2d5c8a59d3e605ef03ac5cb068957c999bb00f86

  * Fix broken breadcrumb when switching tabs in admin/user

Closes #47419





  * Fix broken breadcrumb when switching tabs in admin/user

Closes #47419