delta/gitlab/gitlab-ce.git/spec/features/users_spec.rb, branch 25264-ref-commit gitlab.com: gitlab-org/gitlab-ce.git Allow registering users where the username contains dots (.). 2016-11-18T06:17:37+00:00 Timothy Andrew mail@timothyandrew.net 2016-11-16T12:24:43+00:00 78b6d6624be3a6d59710bf766e7253c2e6787f5a Javascript does not support the negative lookbehind assertion (?<!) used in the Ruby regex (to disallow usernames ending in `.git` or `.atom`. Getting the client side code to fully support this format is non-trivial, since we'd either have to heavily complicate the regex used, or modify the frontend code to support more complex validation schemes (it currently uses HTML5 validations). The pragmatic choice is to create a `Gitlab::Regex::NAMESPACE_REGEX_STR_SIMPLE` regex to serve as a Javascript-compatible version of `NAMESPACE_REGEX_STR`. The client-side code will not display an error for usernames ending in `.git` and `.atom`, but these will be caught by the server-side validation. 
Javascript does not support the negative lookbehind assertion (?<!) used
in the Ruby regex (to disallow usernames ending in `.git` or `.atom`.

Getting the client side code to fully support this format is
non-trivial, since we'd either have to heavily complicate the
regex used, or modify the frontend code to support more complex
validation schemes (it currently uses HTML5 validations).

The pragmatic choice is to create a
`Gitlab::Regex::NAMESPACE_REGEX_STR_SIMPLE` regex to serve as a
Javascript-compatible version of `NAMESPACE_REGEX_STR`.

The client-side code will not display an error for usernames ending in
`.git` and `.atom`, but these will be caught by the server-side
validation.
Merge branch 'dz-rename-user-routes' into 'master' 2016-10-17T18:47:46+00:00 Robert Speicher rspeicher@gmail.com 2016-10-17T18:37:23+00:00 285172c33c6acd66af284d8f1e97a41079fe90de Rename users routing from /u/:username to /users/:username for consistency with other routes Renames /u/:username to /users/:username To follow consistency with other routes (like groups) and UsersController name. Now when you can use `/:username` for accessing user page there is no need in shortcut like `/u/` See merge request !6851 
Rename users routing from /u/:username to /users/:username for
consistency with other routes

Renames /u/:username to /users/:username

To follow consistency with other routes (like groups) and
UsersController name.
Now when you can use `/:username` for accessing user page there is no
need in shortcut like `/u/`

See merge request !6851
Don't use member properties in users_spec, and remove loading ref. 2016-10-15T06:28:55+00:00 Bryce Johnson bryce@gitlab.com 2016-10-13T15:59:55+00:00 b46307d3c59e3cf24eef3a2411ea8af2f25e78ba 






Shush rubocop.
2016-10-15T06:28:52+00:00

Bryce Johnson
bryce@gitlab.com

2016-09-27T12:54:15+00:00

076749645a51c4fe948cdf5ed16dc8455a9aae05












Get tests passing.
2016-10-15T06:27:24+00:00

Bryce Johnson
bryce@gitlab.com

2016-09-23T09:15:07+00:00

83fb1190205c3d1fbe16a684794ed1af10ed1bff












Make UX upgrades to SignIn/Register views.
2016-10-15T06:27:21+00:00

Bryce Johnson
bryce@gitlab.com

2016-09-09T12:21:00+00:00

1dd826d4aad2ce6c195bad24b458b1967b74db1d

- Tab between register and sign in forms
- Add individual input validation error messages
- Validate username
- Update many styles for all login-box forms





- Tab between register and sign in forms
- Add individual input validation error messages
- Validate username
- Update many styles for all login-box forms







Update users routing spec
2016-10-13T11:11:26+00:00

Dmitriy Zaporozhets
dmitriy.zaporozhets@gmail.com

2016-10-13T11:11:26+00:00

bc4d732af126277b3e85aedce795158bd389fbea

Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>





Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>







Fix users feature spec
2016-10-06T16:50:48+00:00

Dmitriy Zaporozhets
dmitriy.zaporozhets@gmail.com

2016-10-06T12:34:30+00:00

105260314899303de4c70a1125b5ab69fb50e6d9

Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>





Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>







Change user & group landing page routing from /u/:name & /groups/:name to /:name
2016-10-06T16:50:48+00:00

Dmitriy Zaporozhets
dmitriy.zaporozhets@gmail.com

2016-10-06T12:14:24+00:00

6b90ccb9fd57401912e1978cbad28cc693a2e0a1

Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>





Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>







Enable Style/EmptyLines cop, remove redundant ones
2016-07-01T19:56:17+00:00

Grzegorz Bizon
grzesiek.bizon@gmail.com

2016-07-01T19:56:17+00:00

9e211091a85c20adea63b89111240350d6d8ffcb