delta/gitlab/gitlab-ce.git/spec/features/users, branch bootstrap-markdown-code-highlight gitlab.com: gitlab-org/gitlab-ce.git Export assigned issues in iCalendar feed 2018-05-31T14:01:04+00:00 Imre Farkas ifarkas@gitlab.com 2018-05-31T14:01:04+00:00 20dfe25c151cc883ce0d38b67125b5ca41e6d422 






Fix local storage not being cleared after creating a new issue
2018-05-30T03:48:21+00:00

Stan Hu
stanhu@gmail.com

2018-05-30T00:51:30+00:00

294ab0fffd8776f9b79a458a276cdce89b0d2fa6

Creating a new issue will always result in a 302 redirect to the newly-created
issue. This reverts the change introduced in
https://gitlab.com/gitlab-org/gitlab-ce/commit/7684217d6806408cd338260119364419260d1720
to handle the case where a user is in the middle of creating a new form and
redirected to accepting the terms of service.

Closes #37162





Creating a new issue will always result in a 302 redirect to the newly-created
issue. This reverts the change introduced in
https://gitlab.com/gitlab-org/gitlab-ce/commit/7684217d6806408cd338260119364419260d1720
to handle the case where a user is in the middle of creating a new form and
redirected to accepting the terms of service.

Closes #37162







Resolve "Merge request spinner spins forever after loading the diff"
2018-05-29T14:49:28+00:00

Lukas Eipert
leipert@gitlab.com

2018-05-29T14:49:28+00:00

8f1dd45aa23a893dfc7bbbafad2872b0c60b3a0b












Fix login_spec
2018-05-25T11:53:26+00:00

Annabel Dunstone Gray
annabel.dunstone@gmail.com

2018-05-25T11:53:26+00:00

5322de32d17ffd65056d764ccbacfd5921aac182












Order UsersController#projects.json by updated_at
2018-05-18T22:19:58+00:00

Takuya Noguchi
takninnovationresearch@gmail.com

2018-04-05T14:56:32+00:00

d8a9bfb6b7e17812915fe6767158abaca2ea6a74












Merge branch 'bvl-fix-sign-out-on-terms' into 'master'
2018-05-11T17:15:43+00:00

Nick Thomas
nick@gitlab.com

2018-05-11T17:15:43+00:00

aa3004c48d6062c4f6f0dcaad91a9774445966e8

Allow a user to sign out when on the terms page

Closes #46211

See merge request gitlab-org/gitlab-ce!18875




Allow a user to sign out when on the terms page

Closes #46211

See merge request gitlab-org/gitlab-ce!18875






Enforce terms acceptance before other requirements
2018-05-11T12:27:22+00:00

Bob Van Landuyt
bob@vanlanduyt.co

2018-05-11T07:35:27+00:00

f25e00bc1e2ece94189cffbc3ffdda6588084cb3

This prevents a redirect loop when a user has to enable 2FA and accept
the terms.

Now they will need to accept the terms, then enable 2FA, or any other requirements.





This prevents a redirect loop when a user has to enable 2FA and accept
the terms.

Now they will need to accept the terms, then enable 2FA, or any other requirements.







Allow a user to sign out when on the terms page
2018-05-11T06:27:43+00:00

Bob Van Landuyt
bob@vanlanduyt.co

2018-05-10T09:35:02+00:00

a5cb2fe2e09b9b758905693360ecc680ff4afe2a

Before we would block the `sign_out` request when the user did not
accept the terms, therefore redirecting them to the terms again.

By allowing all request to devise controllers, we avoid this problem.





Before we would block the `sign_out` request when the user did not
accept the terms, therefore redirecting them to the terms again.

By allowing all request to devise controllers, we avoid this problem.







Enforces terms in the web application
2018-05-04T11:54:43+00:00

Bob Van Landuyt
bob@vanlanduyt.co

2018-04-27T14:50:33+00:00

7684217d6806408cd338260119364419260d1720

This enforces the terms in the web application. These cases are
specced:

- Logging in: When terms are enforced, and a user logs in that has not
  accepted the terms, they are presented with the screen. They get
  directed to their customized root path afterwards.
- Signing up: After signing up, the first screen the user is presented
  with the screen to accept the terms. After they accept they are
  directed to the dashboard.
- While a session is active:
  - For a GET: The user will be directed to the terms page first,
    after they accept the terms, they will be directed to the page
    they were going to
  - For any other request: They are directed to the terms, after they
    accept the terms, they are directed back to the page they came
    from to retry the request. Any information entered would be
    persisted in localstorage and available on the page.





This enforces the terms in the web application. These cases are
specced:

- Logging in: When terms are enforced, and a user logs in that has not
  accepted the terms, they are presented with the screen. They get
  directed to their customized root path afterwards.
- Signing up: After signing up, the first screen the user is presented
  with the screen to accept the terms. After they accept they are
  directed to the dashboard.
- While a session is active:
  - For a GET: The user will be directed to the terms page first,
    after they accept the terms, they will be directed to the page
    they were going to
  - For any other request: They are directed to the terms, after they
    accept the terms, they are directed back to the page they came
    from to retry the request. Any information entered would be
    persisted in localstorage and available on the page.







Allow a user to accept/decline terms
2018-05-04T11:54:43+00:00

Bob Van Landuyt
bob@vanlanduyt.co

2018-04-27T12:56:50+00:00

10aa55a770c2985c22c92d17b8a7ea90b0a09085

When a user accepts, we store this in the agreements to keep track of
which terms they accepted. We also update the flag on the user.





When a user accepts, we store this in the agreements to keep track of
which terms they accepted. We also update the flag on the user.