delta/gitlab/gitlab-ce.git/spec/features/projects, branch rc-document-preferred-array-syntax

Merge branch 'branches-mr-button-permissions' into 'master'

2016-09-09T18:31:46+00:00


Hides merge request button on branches page

## What does this MR do?

 If user does not have the correct permissions, the merge request button is hidden

## What are the relevant issue numbers?

Closes #21805

See merge request !6181

improve code after review

2016-09-06T12:42:43+00:00

add feature test

2016-09-06T12:42:43+00:00

add feature test

add feature test

add feature test

remove test to builds_spec

remove feature test to builds_spec

remove feature test to builds_spec

add changes to methods and remove FactoryGirl

add changes to methods and remove FactoryGirl

adding changes to test and js file

changes grammar

update changelog

rename file name

update files after review

update files after review

update files after review

Merge branch 'project-edit-features-hide' into 'master'

2016-09-02T18:29:17+00:00


Hides merge request section in edit project when disabled

## What does this MR do?

Correctly hides the merge request section in the project edit page when disabled. It used to work before the feature visibility part was changed to dropdown - so added a test to prevent in future! :thumbsup: 

## Screenshots (if relevant)

![hide](/uploads/eb72ef87bad19c2716472a0c1031fd32/hide.gif)

See merge request !6175

Merge branch 'fix/handle-raw-trace-error-on-old-builds' into 'master'

2016-09-02T14:31:46+00:00


Handle error on trace raw download with old builds (DB stored)

## What does this MR do?

Handles error on `raw build trace` download action for old builds (which are stored in DB instead of file).

## Are there points in the code the reviewer needs to double check?

No.

## Why was this MR needed?

At the beginning build traces were stored in database but at some point we moved to store them in files. All trace related actions are aware of this, but not `raw trace download`.

## What are the relevant issue numbers?

Fixes #18900

## Does this MR meet the acceptance criteria?


- [x] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added
- [ ] ~~[Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)~~
- [ ] ~~API support added~~
- Tests
  - [x] Added for this feature/bug
  - [x] All builds are passing
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if you do - rebase it please)
- [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)

See merge request !4822

Hides merge request button on branches page

2016-09-02T13:33:24+00:00

If user does not have the correct permissions, the merge request button is hidden

Closes #21805

Hides merge request section in edit project when disabled

2016-09-02T11:03:49+00:00

Project tools visibility level

2016-09-01T14:47:59+00:00

Fix rubocop offences

2016-09-01T12:00:47+00:00

Update specs - add mocks to simulate old versions

2016-09-01T12:00:46+00:00