<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/gitlab/gitlab-ce.git/spec/features/explore, branch patch-61</title>
<subtitle>gitlab.com: gitlab-org/gitlab-ce.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/'/>
<entry>
<title>Autocorrect with RSpec/ExampleWording cop</title>
<updated>2019-04-05T08:43:27+00:00</updated>
<author>
<name>Thong Kuah</name>
<email>tkuah@gitlab.com</email>
</author>
<published>2019-04-05T08:43:27+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=4ec16912b8f4eba9cc70dd21afb65c441f857da0'/>
<id>4ec16912b8f4eba9cc70dd21afb65c441f857da0</id>
<content type='text'>
- rewords examples starting with 'should'
- rewords examples starting with 'it'

Note: I had to manually fixup "onlies" to "only"
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
- rewords examples starting with 'should'
- rewords examples starting with 'it'

Note: I had to manually fixup "onlies" to "only"
</pre>
</div>
</content>
</entry>
<entry>
<title>Port GitLab.com gold trial callout changes to CE</title>
<updated>2019-01-03T18:39:36+00:00</updated>
<author>
<name>Luke Bennett</name>
<email>lbennett@gitlab.com</email>
</author>
<published>2018-12-06T13:41:20+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=5f110a6acff7571126c22013923d3f5d2aab770d'/>
<id>5f110a6acff7571126c22013923d3f5d2aab770d</id>
<content type='text'>
https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/8731
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/8731
</pre>
</div>
</content>
</entry>
<entry>
<title>Convert "New menu" feature spec to a view spec</title>
<updated>2018-11-26T17:19:15+00:00</updated>
<author>
<name>Robert Speicher</name>
<email>rspeicher@gmail.com</email>
</author>
<published>2018-11-23T22:49:52+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=c0fcf120b79ea90b60980a77b4b2e16c6653f450'/>
<id>c0fcf120b79ea90b60980a77b4b2e16c6653f450</id>
<content type='text'>
A feature spec to test this simple behavior takes about 2 minutes to run
in CI. Everything it's testing is conditionals and `href` attributes,
which can easily be done in a view spec that runs in about 8 seconds.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
A feature spec to test this simple behavior takes about 2 minutes to run
in CI. Everything it's testing is conditionals and `href` attributes,
which can easily be done in a view spec that runs in about 8 seconds.
</pre>
</div>
</content>
</entry>
<entry>
<title>Resolve "Create new group: Rename form fields and update UI"</title>
<updated>2018-10-30T16:23:47+00:00</updated>
<author>
<name>Martin Wortschack</name>
<email>mwortschack@gitlab.com</email>
</author>
<published>2018-10-30T16:23:47+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=66e8ecffa0990651e7bac46ac65120f5a98b1749'/>
<id>66e8ecffa0990651e7bac46ac65120f5a98b1749</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Resolve "Create new project: Re-add project name field"</title>
<updated>2018-09-08T06:03:00+00:00</updated>
<author>
<name>Martin Wortschack</name>
<email>mwortschack@gitlab.com</email>
</author>
<published>2018-09-08T06:03:00+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=03ab130e4b112d51ce77260e54d42b44126426c7'/>
<id>03ab130e4b112d51ce77260e54d42b44126426c7</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Use Projects::UpdateService to archive projects</title>
<updated>2018-08-03T15:55:21+00:00</updated>
<author>
<name>James Ramsay</name>
<email>jramsay@gitlab.com</email>
</author>
<published>2018-08-02T19:39:46+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=79d90cb6bd99b7af572c65af89597c2e55217aea'/>
<id>79d90cb6bd99b7af572c65af89597c2e55217aea</id>
<content type='text'>
System hooks were not being triggered when projects were archived or
unarchived. Reuse the Projects::UpdateService to automatically
trigger system hooks and increase code reuse.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
System hooks were not being triggered when projects were archived or
unarchived. Reuse the Projects::UpdateService to automatically
trigger system hooks and increase code reuse.
</pre>
</div>
</content>
</entry>
<entry>
<title>Enable Capybara/FeatureMethods cop</title>
<updated>2018-07-05T06:32:05+00:00</updated>
<author>
<name>Winnie Hellmann</name>
<email>winnie@gitlab.com</email>
</author>
<published>2018-07-05T06:32:05+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=3db2f327594e134729a0ca2f48a748bb28ab7d6c'/>
<id>3db2f327594e134729a0ca2f48a748bb28ab7d6c</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Fix flakey time-senstive group filter specs</title>
<updated>2018-06-15T02:31:54+00:00</updated>
<author>
<name>Eric Eastwood</name>
<email>contact@ericeastwood.com</email>
</author>
<published>2018-06-15T02:31:54+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=a1d0a16bfbef8654684bca828505632bcfaaaeba'/>
<id>a1d0a16bfbef8654684bca828505632bcfaaaeba</id>
<content type='text'>
This passed previously because the filtered group search is debounced by 0.5s. The test cleared the input, entered `group1`, cleared the input, entered nothing, and the all of groups are still listed because of the 0.5s debounce hasn't triggered and the test passes before anything is actually filtered.

Even if we assert that the list is filtered before clearing the input, the test still fails because the nature of the `fill_in 'filter', with: ""` method is that ["if you're setting the value to "", no keys are ever actually sent, hence no [`input`] event"](https://github.com/teamcapybara/capybara/issues/203#issuecomment-557281) and we never filter back to everything in the list.

So the solution is two-fold, add in the assertions that the list is actually filtered after each step. Then use a method that fills the input with proper events fired.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This passed previously because the filtered group search is debounced by 0.5s. The test cleared the input, entered `group1`, cleared the input, entered nothing, and the all of groups are still listed because of the 0.5s debounce hasn't triggered and the test passes before anything is actually filtered.

Even if we assert that the list is filtered before clearing the input, the test still fails because the nature of the `fill_in 'filter', with: ""` method is that ["if you're setting the value to "", no keys are ever actually sent, hence no [`input`] event"](https://github.com/teamcapybara/capybara/issues/203#issuecomment-557281) and we never filter back to everything in the list.

So the solution is two-fold, add in the assertions that the list is actually filtered after each step. Then use a method that fills the input with proper events fired.
</pre>
</div>
</content>
</entry>
<entry>
<title>Fix new menu spec</title>
<updated>2018-04-20T18:15:09+00:00</updated>
<author>
<name>Clement Ho</name>
<email>ClemMakesApps@gmail.com</email>
</author>
<published>2018-04-20T18:15:09+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=87d4d93fcb380a91416fa49a77a50cf8da17e2be'/>
<id>87d4d93fcb380a91416fa49a77a50cf8da17e2be</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Move explore groups spinach test to RSpec</title>
<updated>2017-12-25T07:27:47+00:00</updated>
<author>
<name>Semyon Pupkov</name>
<email>mail@semyonpupkov.com</email>
</author>
<published>2017-12-24T17:46:30+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=7a815d7585a8a433359297f37b349604bfbcf2c8'/>
<id>7a815d7585a8a433359297f37b349604bfbcf2c8</id>
<content type='text'>
https://gitlab.com/gitlab-org/gitlab-ce/issues/23036
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
https://gitlab.com/gitlab-org/gitlab-ce/issues/23036
</pre>
</div>
</content>
</entry>
</feed>
