<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/gitlab/gitlab-ce.git/spec/controllers, branch frozen_string_spec_models</title>
<subtitle>gitlab.com: gitlab-org/gitlab-ce.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/'/>
<entry>
<title>Allow ref name caching CommitService#find_commit</title>
<updated>2019-03-27T19:46:39+00:00</updated>
<author>
<name>Stan Hu</name>
<email>stanhu@gmail.com</email>
</author>
<published>2019-03-17T06:23:11+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=db759c5d9ca3ba9c1610b05d6725c1427d653bef'/>
<id>db759c5d9ca3ba9c1610b05d6725c1427d653bef</id>
<content type='text'>
For a given merge request, it's quite common to see duplicate FindCommit
Gitaly requests because the Gitaly CommitService caches the request by
the commit SHA, not by the ref name. However, most of the duplicate
requests use the ref name, so the cache is never actually used in
practice. This leads to unnecessary requests that slow performance.

This commit allows certain callers to bypass the ref name to
OID conversion in the cache. We don't do this by default because it's
possible the tip of the branch changes during the commit, which
would cause the caller to get stale data.

This commit also forces the Ci::Pipeline to use the full ref name
so that caching can work for merge requests.

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/57083
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
For a given merge request, it's quite common to see duplicate FindCommit
Gitaly requests because the Gitaly CommitService caches the request by
the commit SHA, not by the ref name. However, most of the duplicate
requests use the ref name, so the cache is never actually used in
practice. This leads to unnecessary requests that slow performance.

This commit allows certain callers to bypass the ref name to
OID conversion in the cache. We don't do this by default because it's
possible the tip of the branch changes during the commit, which
would cause the caller to get stale data.

This commit also forces the Ci::Pipeline to use the full ref name
so that caching can work for merge requests.

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/57083
</pre>
</div>
</content>
</entry>
<entry>
<title>Add API access check to Graphql</title>
<updated>2019-03-27T14:59:02+00:00</updated>
<author>
<name>Felipe Artur</name>
<email>fcardozo@gitlab.com</email>
</author>
<published>2019-03-27T14:59:02+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=73b553a42a1dec7bd38e0aeeb5514c2a566a98c9'/>
<id>73b553a42a1dec7bd38e0aeeb5514c2a566a98c9</id>
<content type='text'>
Check if user can access API on GraphqlController
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Check if user can access API on GraphqlController
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge remote-tracking branch 'dev/master'</title>
<updated>2019-03-20T20:57:19+00:00</updated>
<author>
<name>Alex Hanselka</name>
<email>alex@gitlab.com</email>
</author>
<published>2019-03-20T20:57:19+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=c7fc0bf5319aacfc8d8f399202e2f0785d844fcc'/>
<id>c7fc0bf5319aacfc8d8f399202e2f0785d844fcc</id>
<content type='text'>
* dev/master:
  Update CHANGELOG.md for 11.8.3
  Update CHANGELOG.md for 11.7.7
  Only return `commands_changes` used in frontend
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
* dev/master:
  Update CHANGELOG.md for 11.8.3
  Update CHANGELOG.md for 11.7.7
  Only return `commands_changes` used in frontend
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'security-2826-fix-project-serialization-in-quick-actions' into 'master'</title>
<updated>2019-03-20T20:56:40+00:00</updated>
<author>
<name>Alex Hanselka</name>
<email>alex@gitlab.com</email>
</author>
<published>2019-03-20T20:56:40+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=d8dfd330de71e54633995103103b0a6573ae298c'/>
<id>d8dfd330de71e54633995103103b0a6573ae298c</id>
<content type='text'>
Fix project serialization in quick actions response

Closes #2826

See merge request gitlab/gitlabhq!3001</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Fix project serialization in quick actions response

Closes #2826

See merge request gitlab/gitlabhq!3001</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'create-identity-provider-policy' into 'master'</title>
<updated>2019-03-20T16:08:05+00:00</updated>
<author>
<name>Nick Thomas</name>
<email>nick@gitlab.com</email>
</author>
<published>2019-03-20T16:08:05+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=4249eac3058fbc57724feb04b98a547732ca5959'/>
<id>4249eac3058fbc57724feb04b98a547732ca5959</id>
<content type='text'>
Move out link\unlink ability checks to a policy

See merge request gitlab-org/gitlab-ce!26278</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Move out link\unlink ability checks to a policy

See merge request gitlab-org/gitlab-ce!26278</pre>
</div>
</content>
</entry>
<entry>
<title>Reject HEAD requests to info/refs endpoint</title>
<updated>2019-03-19T18:23:51+00:00</updated>
<author>
<name>Stan Hu</name>
<email>stanhu@gmail.com</email>
</author>
<published>2019-03-19T17:02:17+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=d165754400cd68f116babc1b0f50cf6109e85009'/>
<id>d165754400cd68f116babc1b0f50cf6109e85009</id>
<content type='text'>
In production, we see high error rates due to clients attempting to use
the dumb Git HTTP protocol with HEAD /foo/bar.git/info/refs
endpoint. This isn't supported and causes Error 500s because Workhorse
doesn't send along its secret because it's not proxying this request.

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/54579
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
In production, we see high error rates due to clients attempting to use
the dumb Git HTTP protocol with HEAD /foo/bar.git/info/refs
endpoint. This isn't supported and causes Error 500s because Workhorse
doesn't send along its secret because it's not proxying this request.

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/54579
</pre>
</div>
</content>
</entry>
<entry>
<title>Move out link\unlink ability checks to a policy</title>
<updated>2019-03-19T12:38:16+00:00</updated>
<author>
<name>Pavel Shutsin</name>
<email>pshutsin@gitlab.com</email>
</author>
<published>2019-03-18T14:36:34+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=8ee1927db90d43205b4e6f8bd13f209c74b41bd1'/>
<id>8ee1927db90d43205b4e6f8bd13f209c74b41bd1</id>
<content type='text'>
We can extend the policy in EE for additional behavior
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
We can extend the policy in EE for additional behavior
</pre>
</div>
</content>
</entry>
<entry>
<title>Introduce ApplicationSettingImplementation yay</title>
<updated>2019-03-19T05:01:37+00:00</updated>
<author>
<name>Lin Jen-Shin</name>
<email>godfat@godfat.org</email>
</author>
<published>2019-03-06T12:12:04+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=6b0d493350ed9288c4a68a35dbbb4a4b91bd9637'/>
<id>6b0d493350ed9288c4a68a35dbbb4a4b91bd9637</id>
<content type='text'>
So the fake can enjoy it, too. We don't use `prepend`
because that'll require we change `allow_any_instance_of` to
`expect_next_instance_of`, but that's not very easy to do.
We can do that later.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
So the fake can enjoy it, too. We don't use `prepend`
because that'll require we change `allow_any_instance_of` to
`expect_next_instance_of`, but that's not very easy to do.
We can do that later.
</pre>
</div>
</content>
</entry>
<entry>
<title>Fix undefined variable error on json project views</title>
<updated>2019-03-19T00:27:28+00:00</updated>
<author>
<name>Alejandro Rodríguez</name>
<email>alejorro70@gmail.com</email>
</author>
<published>2019-03-19T00:01:49+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=585fcfb9e7be7300af04cd2f9c6d1d97d5333cf5'/>
<id>585fcfb9e7be7300af04cd2f9c6d1d97d5333cf5</id>
<content type='text'>
This mistake seems to have always been there, but it only resulted in
errors on the `/explore*.json` since they were the one that _actually_
relied on the local variables.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This mistake seems to have always been there, but it only resulted in
errors on the `/explore*.json` since they were the one that _actually_
relied on the local variables.
</pre>
</div>
</content>
</entry>
<entry>
<title>Only return `commands_changes` used in frontend</title>
<updated>2019-03-18T18:28:35+00:00</updated>
<author>
<name>Heinrich Lee Yu</name>
<email>heinrich@gitlab.com</email>
</author>
<published>2019-03-15T00:07:52+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=3d85406734fc31bb9c9fb95ce26898b65b60b3ea'/>
<id>3d85406734fc31bb9c9fb95ce26898b65b60b3ea</id>
<content type='text'>
When executing quick actions, this limits the `commands_changes`
response to only those used by the frontend
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
When executing quick actions, this limits the `commands_changes`
response to only those used by the frontend
</pre>
</div>
</content>
</entry>
</feed>
