delta/gitlab/gitlab-ce.git/spec/controllers/users_controller_spec.rb, branch bugfix/upgrade-ruby-parser gitlab.com: gitlab-org/gitlab-ce.git Fix ensure_canonical_path for top level routes 2017-05-18T23:24:10+00:00 Michael Kozono mkozono@gmail.com 2017-05-18T19:56:39+00:00 f9785dcec34c4205732871523f95b9743db00965 Don’t replace a substring of the path if it is part of the top level route. E.g. When redirecting from `/groups/ups` to `/groups/foo`, be careful not to do `/grofoo/ups`. Projects are unaffected by this issue, but I am grouping the `#ensure_canonical_path` tests similar to the group and user tests. 
Don’t replace a substring of the path if it is part of the top level route.

E.g. When redirecting from `/groups/ups` to `/groups/foo`, be careful not to do `/grofoo/ups`.

Projects are unaffected by this issue, but I am grouping the `#ensure_canonical_path` tests similar to the group and user tests.
Fix redirect message for groups and users 2017-05-11T22:28:13+00:00 Michael Kozono mkozono@gmail.com 2017-05-11T20:57:03+00:00 ab98f8b5b1fb323ded965cdb352a504525dd0703 






Resolve discussions
2017-05-05T19:12:50+00:00

Michael Kozono
mkozono@gmail.com

2017-05-05T00:06:01+00:00

f05469f99b8c52c4dab7ac9160b47676c87124f9












Dry up routable lookups. Fixes #30317
2017-05-05T19:12:50+00:00

Michael Kozono
mkozono@gmail.com

2017-05-04T21:20:13+00:00

9e48f02ea802814e4df1f1de5ed509942dca7581

Note: This changes the behavior of user lookups (see the spec change) so it acts the same way as groups and projects. Unauthenticated clients attempting to access a user page will be redirected to login whether the user exists and is publicly restricted, or does not exist at all.





Note: This changes the behavior of user lookups (see the spec change) so it acts the same way as groups and projects. Unauthenticated clients attempting to access a user page will be redirected to login whether the user exists and is publicly restricted, or does not exist at all.







Add “project moved” flash message on redirect
2017-05-05T19:12:50+00:00

Michael Kozono
mkozono@gmail.com

2017-05-04T18:12:19+00:00

e4bcc90d95fa3b78544cb9ddd6019a5f914c1628












Resolve discussions
2017-05-05T19:12:49+00:00

Michael Kozono
mkozono@gmail.com

2017-05-03T22:26:44+00:00

0c866f4a575d8127efbf3eafda83d8ccfbd97817












Redirect from redirect routes to canonical routes
2017-05-05T19:11:57+00:00

Michael Kozono
mkozono@gmail.com

2017-05-01T20:46:30+00:00

7d02bcd2e0165a90a9f2c1edb34b064ff76afd69












Use `empty_project` where possible in controller specs
2017-01-25T22:14:38+00:00

Robert Speicher
rspeicher@gmail.com

2017-01-25T21:44:33+00:00

4642ca6686d30e1bb203ece4836a294c868a6250












Enforce the fork_project permission in Projects::CreateService
2016-09-27T12:17:56+00:00

Nick Thomas
nick@gitlab.com

2016-09-19T18:28:41+00:00

3ed80a0176a0c8155ff6f84a8f3e70718babd8ce

Projects::ForkService delegates to this service almost entirely, but needed
one small change so it would propagate create errors correctly.

CreateService#execute needs significant refactoring; it is now right at the
complexity limit set by Rubocop. I avoided doing so in this commit to keep the
diff as small as possible.

Several tests depend on the insecure behaviour of ForkService, so fi them up at
the same time.





Projects::ForkService delegates to this service almost entirely, but needed
one small change so it would propagate create errors correctly.

CreateService#execute needs significant refactoring; it is now right at the
complexity limit set by Rubocop. I avoided doing so in this commit to keep the
diff as small as possible.

Several tests depend on the insecure behaviour of ForkService, so fi them up at
the same time.







Enable Style/EmptyLines cop, remove redundant ones
2016-07-01T19:56:17+00:00

Grzegorz Bizon
grzesiek.bizon@gmail.com

2016-07-01T19:56:17+00:00

9e211091a85c20adea63b89111240350d6d8ffcb