delta/gitlab/gitlab-ce.git/spec/controllers/snippets, branch docs-code-block-style

Correctly check permissions when creating snippet notes

2019-06-06T07:32:18+00:00

In the Snippets::NotesController the noteable was resolved and
authorized through the :snippet_id, so by passing a :target_id for a
different snippet it was possible to create a note on a snippet
where the user would be unauthorized to do so otherwise.

This fixes the problem by ignoring the :target_id and :target_type from
the request, and using the same noteable for creation and authorization.

Add some frozen string to spec/**/*.rb

2019-04-15T10:17:05+00:00

Adds frozen string to the following:

* spec/bin/**/*.rb
* spec/config/**/*.rb
* spec/controllers/**/*.rb

xref https://gitlab.com/gitlab-org/gitlab-ce/issues/59758

Update specs to rails5 format

2018-12-18T23:04:31+00:00

Updates specs to use new rails5 format.

The old format:
`get :show, { some: params }, { some: headers }`

The new format:
`get :show, params: { some: params }, headers: { some: headers }`

Refactor `have_http_status` into `have_gitlab_http_status` in the specs

2017-10-20T08:13:18+00:00

Enable the Layout/SpaceBeforeBlockBraces cop

2017-08-09T09:52:22+00:00

Signed-off-by: Rémy Coutable

Display comments for personal snippets

2017-05-02T11:07:53+00:00