delta/gitlab/gitlab-ce.git/spec/controllers/sessions_controller_spec.rb, branch app-differences gitlab.com: gitlab-org/gitlab-ce.git Prevent password sign in restriction bypass 2019-05-21T07:12:41+00:00 James Edwards-Jones jedwardsjones@gitlab.com 2018-12-12T14:45:55+00:00 fab6a50f17d15d21a157d4d561f41527fa943f27 






Add some frozen string to spec/**/*.rb
2019-04-15T10:17:05+00:00

gfyoung
gfyoung17+gitlab@gmail.com

2019-04-15T10:17:05+00:00

93a44e135b0d09ed0fd31dce5d81841a96ef8d67

Adds frozen string to the following:

* spec/bin/**/*.rb
* spec/config/**/*.rb
* spec/controllers/**/*.rb

xref https://gitlab.com/gitlab-org/gitlab-ce/issues/59758





Adds frozen string to the following:

* spec/bin/**/*.rb
* spec/config/**/*.rb
* spec/controllers/**/*.rb

xref https://gitlab.com/gitlab-org/gitlab-ce/issues/59758







Update specs to rails5 format
2018-12-18T23:04:31+00:00

blackst0ne
blackst0ne.ru@gmail.com

2018-12-17T22:52:17+00:00

b44a2c801a64fb282cea794871fcfcf81e4ec539

Updates specs to use new rails5 format.

The old format:
`get :show, { some: params }, { some: headers }`

The new format:
`get :show, params: { some: params }, headers: { some: headers }`





Updates specs to use new rails5 format.

The old format:
`get :show, { some: params }, { some: headers }`

The new format:
`get :show, params: { some: params }, headers: { some: headers }`







Fix typos in lib
2018-11-15T10:15:43+00:00

George Tsiolis
tsiolis.g@gmail.com

2018-11-15T10:13:50+00:00

566ba126f5d8090edc760fe0c20215da73452e47












Delete UserActivities and related workers
2018-07-18T13:44:10+00:00

Imre Farkas
ifarkas@gitlab.com

2018-07-12T11:21:08+00:00

c62fce988308e545488cbb32569f022e771aa799












Add Prometheus metrics to track reCAPTCHA success/failures
2018-07-03T18:39:00+00:00

Stan Hu
stanhu@gmail.com

2018-06-22T06:25:00+00:00

7376ffc3a3f3d0f3bc294c4431370c5560c19a00












Show a reCAPTCHA on signin page if custom header is set
2018-06-21T22:37:34+00:00

Stan Hu
stanhu@gmail.com

2018-06-21T18:13:08+00:00

9b48d9f43f237ccf87594a944a00896996cadf55

This will only be displayed if `X-GitLab-Show-Login-Captcha` is set as an HTTP
header.





This will only be displayed if `X-GitLab-Show-Login-Captcha` is set as an HTTP
header.







[Rails5] Fix sessions_controller_spec
2018-06-16T08:12:46+00:00

blackst0ne
blackst0ne.ru@gmail.com

2018-06-16T08:12:46+00:00

79c3ec014c7db667457268a75f9c47bee8653650

Refactor sessions_controller_spec to work both in rails4 and rails5.
Remove the stubbed `request.referer` method, set real header instead.





Refactor sessions_controller_spec to work both in rails4 and rails5.
Remove the stubbed `request.referer` method, set real header instead.







Reuses `InternalRedirect` when possible
2018-05-04T11:54:43+00:00

Bob Van Landuyt
bob@vanlanduyt.co

2018-05-02T18:25:21+00:00

39916fdfeddfd75279d13fa976fdb07f3b9b0e26

`InternalRedirect` prevents Open redirect issues by only allowing
redirection to paths on the same host.

It cleans up any unwanted strings from the path that could point to
another host (fe. //about.gitlab.com/hello). While preserving the
querystring and fragment of the uri.

It is already used by:

- `TermsController`
- `ContinueParams`
  - `ImportsController`
  - `ForksController`
- `SessionsController`: Only for verifying the host in CE. EE allows
   redirecting to a different instance using Geo.





`InternalRedirect` prevents Open redirect issues by only allowing
redirection to paths on the same host.

It cleans up any unwanted strings from the path that could point to
another host (fe. //about.gitlab.com/hello). While preserving the
querystring and fragment of the uri.

It is already used by:

- `TermsController`
- `ContinueParams`
  - `ImportsController`
  - `ForksController`
- `SessionsController`: Only for verifying the host in CE. EE allows
   redirecting to a different instance using Geo.







Refactor `have_http_status` into `have_gitlab_http_status` in the specs
2017-10-20T08:13:18+00:00

Jacopo
beschi.jacopo@gmail.com

2017-10-19T18:28:19+00:00

2f40dac35280f9de9af8c47bdf85c2f0b2d53680