<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/gitlab/gitlab-ce.git/spec/controllers/projects/merge_requests, branch document-lambda-deploy</title>
<subtitle>gitlab.com: gitlab-org/gitlab-ce.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/'/>
<entry>
<title>Change `be_success` to `be_successful` in specs</title>
<updated>2019-08-19T12:40:56+00:00</updated>
<author>
<name>Vitali Tatarintev</name>
<email>vtatarintev@gitlab.com</email>
</author>
<published>2019-08-19T09:55:20+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=6a6411938a2854bb20dd358a481bb3f067df8271'/>
<id>6a6411938a2854bb20dd358a481bb3f067df8271</id>
<content type='text'>
Fixes deprecation warning:

```
DEPRECATION WARNING: The success? predicate is deprecated and
will be removed in Rails 6.0.
Please use successful? as provided by Rack::Response::Helpers.
```
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Fixes deprecation warning:

```
DEPRECATION WARNING: The success? predicate is deprecated and
will be removed in Rails 6.0.
Please use successful? as provided by Rack::Response::Helpers.
```
</pre>
</div>
</content>
</entry>
<entry>
<title>Split MR widget into cached and non-cached serializers</title>
<updated>2019-08-09T21:01:55+00:00</updated>
<author>
<name>Igor</name>
<email>idrozdov@gitlab.com</email>
</author>
<published>2019-08-09T21:01:55+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=b99011af62935de0b15e8a314ffb7df1f8a3f303'/>
<id>b99011af62935de0b15e8a314ffb7df1f8a3f303</id>
<content type='text'>
Splits auto-refreshing of MR widget into 2 requests:

- the one which uses etag-caching and invalidates the fields on change
- the one without caching

The idea is to gradually move all the fields to etag-cached endpoint
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Splits auto-refreshing of MR widget into 2 requests:

- the one which uses etag-caching and invalidates the fields on change
- the one without caching

The idea is to gradually move all the fields to etag-cached endpoint
</pre>
</div>
</content>
</entry>
<entry>
<title>Added Usage Data for some Web IDE actions</title>
<updated>2019-07-19T11:11:27+00:00</updated>
<author>
<name>Francisco Javier López</name>
<email>fjlopez@gitlab.com</email>
</author>
<published>2019-07-19T11:11:27+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=01685eed7674ec841b4249b42f9b350f4a105e4a'/>
<id>01685eed7674ec841b4249b42f9b350f4a105e4a</id>
<content type='text'>
The actions tracked in the web IDE are:
- creation of commits
- creation of merge requests
- projects loaded
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The actions tracked in the web IDE are:
- creation of commits
- creation of merge requests
- projects loaded
</pre>
</div>
</content>
</entry>
<entry>
<title>Cleanup usages of `JSON.parse` in specs</title>
<updated>2019-07-16T08:03:49+00:00</updated>
<author>
<name>Peter Leitzen</name>
<email>pleitzen@gitlab.com</email>
</author>
<published>2019-07-16T08:03:49+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=7b87ed14991737930eb8f353feec9e6c8af6c1ac'/>
<id>7b87ed14991737930eb8f353feec9e6c8af6c1ac</id>
<content type='text'>
Prefer `json_response` where applicable.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Prefer `json_response` where applicable.
</pre>
</div>
</content>
</entry>
<entry>
<title>Extract MR's widget into a separate endpoint</title>
<updated>2019-06-28T07:52:48+00:00</updated>
<author>
<name>Igor Drozdov</name>
<email>idrozdov@gitlab.com</email>
</author>
<published>2019-06-21T18:22:55+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=07559fda51dd32cf23a14567cc7077c02c3900d4'/>
<id>07559fda51dd32cf23a14567cc7077c02c3900d4</id>
<content type='text'>
This commits extracts /merge_requests/1.json?serializer=widget
Into a separate /merge_requests/1/widget.json endpoint
This will allow to use caching for this request
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This commits extracts /merge_requests/1.json?serializer=widget
Into a separate /merge_requests/1/widget.json endpoint
This will allow to use caching for this request
</pre>
</div>
</content>
</entry>
<entry>
<title>Add some frozen string to spec/**/*.rb</title>
<updated>2019-04-15T10:17:05+00:00</updated>
<author>
<name>gfyoung</name>
<email>gfyoung17+gitlab@gmail.com</email>
</author>
<published>2019-04-15T10:17:05+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=93a44e135b0d09ed0fd31dce5d81841a96ef8d67'/>
<id>93a44e135b0d09ed0fd31dce5d81841a96ef8d67</id>
<content type='text'>
Adds frozen string to the following:

* spec/bin/**/*.rb
* spec/config/**/*.rb
* spec/controllers/**/*.rb

xref https://gitlab.com/gitlab-org/gitlab-ce/issues/59758
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Adds frozen string to the following:

* spec/bin/**/*.rb
* spec/config/**/*.rb
* spec/controllers/**/*.rb

xref https://gitlab.com/gitlab-org/gitlab-ce/issues/59758
</pre>
</div>
</content>
</entry>
<entry>
<title>Fix Projects::MergeRequests::DiffsController specs</title>
<updated>2019-02-18T11:13:08+00:00</updated>
<author>
<name>Rémy Coutable</name>
<email>remy@rymai.me</email>
</author>
<published>2019-02-14T15:52:42+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=45ce5ff7ea19254b16a721329820712d68886298'/>
<id>45ce5ff7ea19254b16a721329820712d68886298</id>
<content type='text'>
These specs were flaky and only passing after a retry due to how
rspec-retry works.

1. The test with paths that don't exist was returning 200 on the first
  try, then 404 on the second, not because the paths don't exist, but
  because the MR IID didn't change, thus the MR couldn't be found.
  I decided to remove the test entirely since we don't seem to return
  404 for paths that don't exist.
2. The test with a user that cannot view the merge request was failing
  the first time because the project owner wasn't removed with
  `project.team.truncate`.
  Changing the `let(:user)` to `create(:user)` and calling
  `project.add_maintainer(user)` in the `before` block fix the test.

Signed-off-by: Rémy Coutable &lt;remy@rymai.me&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
These specs were flaky and only passing after a retry due to how
rspec-retry works.

1. The test with paths that don't exist was returning 200 on the first
  try, then 404 on the second, not because the paths don't exist, but
  because the MR IID didn't change, thus the MR couldn't be found.
  I decided to remove the test entirely since we don't seem to return
  404 for paths that don't exist.
2. The test with a user that cannot view the merge request was failing
  the first time because the project owner wasn't removed with
  `project.team.truncate`.
  Changing the `let(:user)` to `create(:user)` and calling
  `project.add_maintainer(user)` in the `before` block fix the test.

Signed-off-by: Rémy Coutable &lt;remy@rymai.me&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Add committers and authors methods on MergeRequest</title>
<updated>2019-01-07T23:27:29+00:00</updated>
<author>
<name>Tiago Botelho</name>
<email>tiagonbotelho@hotmail.com</email>
</author>
<published>2019-01-03T10:59:14+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=a2842241d4f583625053aba4d2c37a2f15b21913'/>
<id>a2842241d4f583625053aba4d2c37a2f15b21913</id>
<content type='text'>
These are used by the EE-only approvers feature
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
These are used by the EE-only approvers feature
</pre>
</div>
</content>
</entry>
<entry>
<title>Update specs to rails5 format</title>
<updated>2018-12-18T23:04:31+00:00</updated>
<author>
<name>blackst0ne</name>
<email>blackst0ne.ru@gmail.com</email>
</author>
<published>2018-12-17T22:52:17+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=b44a2c801a64fb282cea794871fcfcf81e4ec539'/>
<id>b44a2c801a64fb282cea794871fcfcf81e4ec539</id>
<content type='text'>
Updates specs to use new rails5 format.

The old format:
`get :show, { some: params }, { some: headers }`

The new format:
`get :show, params: { some: params }, headers: { some: headers }`
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Updates specs to use new rails5 format.

The old format:
`get :show, { some: params }, { some: headers }`

The new format:
`get :show, params: { some: params }, headers: { some: headers }`
</pre>
</div>
</content>
</entry>
<entry>
<title>Avoid 500's when serializing legacy diff notes</title>
<updated>2018-12-04T15:13:22+00:00</updated>
<author>
<name>Oswaldo Ferreira</name>
<email>oswaldo@gitlab.com</email>
</author>
<published>2018-12-04T13:15:19+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=89a676019cd580520e6c2ee696b15818d6ca954a'/>
<id>89a676019cd580520e6c2ee696b15818d6ca954a</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
</feed>
