<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/gitlab/gitlab-ce.git/spec/controllers/projects/commit_controller_spec.rb, branch patch-6</title>
<subtitle>gitlab.com: gitlab-org/gitlab-ce.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/'/>
<entry>
<title>refactors tests because of gitlab-test repository changes</title>
<updated>2016-10-11T15:33:06+00:00</updated>
<author>
<name>tiagonbotelho</name>
<email>tiagonbotelho@hotmail.com</email>
</author>
<published>2016-10-03T12:11:16+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=c90483406ecc2717076391737ff57167b5a03393'/>
<id>c90483406ecc2717076391737ff57167b5a03393</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>fixes part1 of files to start using active tense</title>
<updated>2016-08-09T14:06:23+00:00</updated>
<author>
<name>tiagonbotelho</name>
<email>tiagonbotelho@hotmail.com</email>
</author>
<published>2016-07-25T18:16:19+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=519275c1102ad8a1d56f5807de2d8a1ae4b21dc0'/>
<id>519275c1102ad8a1d56f5807de2d8a1ae4b21dc0</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Move to Gitlab::Diff::FileCollection</title>
<updated>2016-08-03T05:00:20+00:00</updated>
<author>
<name>Paco Guzman</name>
<email>pacoguzmanp@gmail.com</email>
</author>
<published>2016-07-26T07:21:42+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=8f359ea9170b984ad43d126e17628c31ac3a1f14'/>
<id>8f359ea9170b984ad43d126e17628c31ac3a1f14</id>
<content type='text'>
Instead calling diff_collection.count use diff_collection.size which is cache on the diff_collection</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Instead calling diff_collection.count use diff_collection.size which is cache on the diff_collection</pre>
</div>
</content>
</entry>
<entry>
<title>Cache highlighted diff lines for merge requests</title>
<updated>2016-08-03T05:00:19+00:00</updated>
<author>
<name>Paco Guzman</name>
<email>pacoguzmanp@gmail.com</email>
</author>
<published>2016-07-20T16:25:36+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=cd7c2cb6ddd4d9c9f9bdae00c887c0022c121c17'/>
<id>cd7c2cb6ddd4d9c9f9bdae00c887c0022c121c17</id>
<content type='text'>
Introducing the concept of SafeDiffs which relates 
diffs with UI highlighting.</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Introducing the concept of SafeDiffs which relates 
diffs with UI highlighting.</pre>
</div>
</content>
</entry>
<entry>
<title>Fix failing CommitController spec</title>
<updated>2016-07-28T20:37:03+00:00</updated>
<author>
<name>Alejandro Rodríguez</name>
<email>alejorro70@gmail.com</email>
</author>
<published>2016-07-28T20:37:03+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=08bac551494d92bc096859144a7a631b987ac35d'/>
<id>08bac551494d92bc096859144a7a631b987ac35d</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Support renames in diff_for_path actions</title>
<updated>2016-07-11T08:31:34+00:00</updated>
<author>
<name>Sean McGivern</name>
<email>sean@gitlab.com</email>
</author>
<published>2016-07-08T21:50:06+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=5266ae87c43a6760600e397257f9791d950dbe15'/>
<id>5266ae87c43a6760600e397257f9791d950dbe15</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Tidy up spec action names</title>
<updated>2016-07-08T17:11:47+00:00</updated>
<author>
<name>Sean McGivern</name>
<email>sean@gitlab.com</email>
</author>
<published>2016-07-08T17:11:47+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=e462e122784f40550c53224af5a58b201ed1fd8f'/>
<id>e462e122784f40550c53224af5a58b201ed1fd8f</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Collapse large diffs by default</title>
<updated>2016-07-08T09:56:55+00:00</updated>
<author>
<name>Sean McGivern</name>
<email>sean@gitlab.com</email>
</author>
<published>2016-06-28T16:25:32+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=b6b26692ea44cfeab7e8fd64b7df60852850fce2'/>
<id>b6b26692ea44cfeab7e8fd64b7df60852850fce2</id>
<content type='text'>
When rendering a list of diff files, skip those where the diff is over
10 KB and provide an endpoint to render individually instead.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
When rendering a list of diff files, skip those where the diff is over
10 KB and provide an endpoint to render individually instead.
</pre>
</div>
</content>
</entry>
<entry>
<title>Fix Error 500 when viewing a blob with binary characters after the 1024-byte mark</title>
<updated>2016-06-12T14:36:25+00:00</updated>
<author>
<name>Stan Hu</name>
<email>stanhu@gmail.com</email>
</author>
<published>2016-05-24T05:59:35+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=0fdfd2dd6e01648f4daf6853f11a3ffc9a678a55'/>
<id>0fdfd2dd6e01648f4daf6853f11a3ffc9a678a55</id>
<content type='text'>
Here was the problem:

1. When determining whether a given blob is viewable text, gitlab_git reads the first 1024 bytes and checks with Linguist whether it is a text or binary file.
2. If the blob is text, GitLab will attempt to display it.
3. However, if the text has binary characters after the first 1024 bytes, then GitLab will attempt to load the entire contents, but the encoding will be ASCII-8BIT since there are binary characters.
4. The Error 500 results when GitLab attempts to display a mix UTF-8 and ASCII-8BIT.

To fix this, we load as much data as we are willing to display so that the detection will work properly. Requires
an update to gitlab_git: gitlab-org/gitlab_git!86

Closes #13826
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Here was the problem:

1. When determining whether a given blob is viewable text, gitlab_git reads the first 1024 bytes and checks with Linguist whether it is a text or binary file.
2. If the blob is text, GitLab will attempt to display it.
3. However, if the text has binary characters after the first 1024 bytes, then GitLab will attempt to load the entire contents, but the encoding will be ASCII-8BIT since there are binary characters.
4. The Error 500 results when GitLab attempts to display a mix UTF-8 and ASCII-8BIT.

To fix this, we load as much data as we are willing to display so that the detection will work properly. Requires
an update to gitlab_git: gitlab-org/gitlab_git!86

Closes #13826
</pre>
</div>
</content>
</entry>
<entry>
<title>Ensure Commit#show responds 404 instead of 500 when given an invalid ID</title>
<updated>2016-02-15T20:48:16+00:00</updated>
<author>
<name>Robert Speicher</name>
<email>rspeicher@gmail.com</email>
</author>
<published>2016-02-15T20:48:16+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=f5ab126fd0e607811638ca36b6752d5c74535adf'/>
<id>f5ab126fd0e607811638ca36b6752d5c74535adf</id>
<content type='text'>
Closes #13467
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Closes #13467
</pre>
</div>
</content>
</entry>
</feed>
