<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/gitlab/gitlab-ce.git/spec/controllers/omniauth_callbacks_controller_spec.rb, branch app-differences</title>
<subtitle>gitlab.com: gitlab-org/gitlab-ce.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/'/>
<entry>
<title>Revert Rails.application.env_config after using mock_auth_hash</title>
<updated>2019-04-23T19:11:08+00:00</updated>
<author>
<name>Rémy Coutable</name>
<email>remy@rymai.me</email>
</author>
<published>2019-04-23T18:30:29+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=a16d7e414d04ccf3268be9cab2fdff15b2ecb45e'/>
<id>a16d7e414d04ccf3268be9cab2fdff15b2ecb45e</id>
<content type='text'>
Signed-off-by: Rémy Coutable &lt;remy@rymai.me&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Signed-off-by: Rémy Coutable &lt;remy@rymai.me&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Add some frozen string to spec/**/*.rb</title>
<updated>2019-04-15T10:17:05+00:00</updated>
<author>
<name>gfyoung</name>
<email>gfyoung17+gitlab@gmail.com</email>
</author>
<published>2019-04-15T10:17:05+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=93a44e135b0d09ed0fd31dce5d81841a96ef8d67'/>
<id>93a44e135b0d09ed0fd31dce5d81841a96ef8d67</id>
<content type='text'>
Adds frozen string to the following:

* spec/bin/**/*.rb
* spec/config/**/*.rb
* spec/controllers/**/*.rb

xref https://gitlab.com/gitlab-org/gitlab-ce/issues/59758
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Adds frozen string to the following:

* spec/bin/**/*.rb
* spec/config/**/*.rb
* spec/controllers/**/*.rb

xref https://gitlab.com/gitlab-org/gitlab-ce/issues/59758
</pre>
</div>
</content>
</entry>
<entry>
<title>Autocorrect with RSpec/ExampleWording cop</title>
<updated>2019-04-05T08:43:27+00:00</updated>
<author>
<name>Thong Kuah</name>
<email>tkuah@gitlab.com</email>
</author>
<published>2019-04-05T08:43:27+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=4ec16912b8f4eba9cc70dd21afb65c441f857da0'/>
<id>4ec16912b8f4eba9cc70dd21afb65c441f857da0</id>
<content type='text'>
- rewords examples starting with 'should'
- rewords examples starting with 'it'

Note: I had to manually fixup "onlies" to "only"
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
- rewords examples starting with 'should'
- rewords examples starting with 'it'

Note: I had to manually fixup "onlies" to "only"
</pre>
</div>
</content>
</entry>
<entry>
<title>Move out link\unlink ability checks to a policy</title>
<updated>2019-03-19T12:38:16+00:00</updated>
<author>
<name>Pavel Shutsin</name>
<email>pshutsin@gitlab.com</email>
</author>
<published>2019-03-18T14:36:34+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=8ee1927db90d43205b4e6f8bd13f209c74b41bd1'/>
<id>8ee1927db90d43205b4e6f8bd13f209c74b41bd1</id>
<content type='text'>
We can extend the policy in EE for additional behavior
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
We can extend the policy in EE for additional behavior
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'ce-security-jej/group-saml-link-origin-verification' into 'master'</title>
<updated>2019-03-04T18:36:26+00:00</updated>
<author>
<name>Yorick Peterse</name>
<email>yorickpeterse@gmail.com</email>
</author>
<published>2019-03-04T18:36:26+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=040e6e72bfc0a40c0a133d07a4619597cf6b4675'/>
<id>040e6e72bfc0a40c0a133d07a4619597cf6b4675</id>
<content type='text'>
Ensure request to link GroupSAML acount was GitLab initiated

See merge request gitlab/gitlabhq!2976</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Ensure request to link GroupSAML acount was GitLab initiated

See merge request gitlab/gitlabhq!2976</pre>
</div>
</content>
</entry>
<entry>
<title>Avoid CSRF check on SAML failure endpoint</title>
<updated>2019-02-04T10:10:51+00:00</updated>
<author>
<name>James Edwards-Jones</name>
<email>jedwardsjones@gitlab.com</email>
</author>
<published>2019-01-19T20:41:39+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=6548e01f18c24ec8703bb85557d7509dbeace013'/>
<id>6548e01f18c24ec8703bb85557d7509dbeace013</id>
<content type='text'>
SAML and OAuth failures should cause a message to be presented, as well
as logging that an attempt was made. These were incorrectly prevented by
the CSRF check on POST endpoints such as SAML.

In addition we were using a NullSession forgery protection, which made
testing more difficult and could have allowed account linking to take
place if a CSRF was ever needed but not present.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
SAML and OAuth failures should cause a message to be presented, as well
as logging that an attempt was made. These were incorrectly prevented by
the CSRF check on POST endpoints such as SAML.

In addition we were using a NullSession forgery protection, which made
testing more difficult and could have allowed account linking to take
place if a CSRF was ever needed but not present.
</pre>
</div>
</content>
</entry>
<entry>
<title>Backport EE GroupSAML origin verification changes</title>
<updated>2019-01-23T19:42:16+00:00</updated>
<author>
<name>James Edwards-Jones</name>
<email>jedwardsjones@gitlab.com</email>
</author>
<published>2018-12-08T14:12:50+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=104c8b890dbca25a0d08b2567d003f02953a0fc1'/>
<id>104c8b890dbca25a0d08b2567d003f02953a0fc1</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Update gitlab-styles to 2.5.1</title>
<updated>2019-01-11T22:59:35+00:00</updated>
<author>
<name>Jasper Maes</name>
<email>jaspermaes.jm@gmail.com</email>
</author>
<published>2019-01-11T20:10:55+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=4361c92b6a41554ae8a8e4ad7204e8ed82ec7c5c'/>
<id>4361c92b6a41554ae8a8e4ad7204e8ed82ec7c5c</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Preserve URL fragment across sign-in and sign-up redirects</title>
<updated>2019-01-10T06:00:38+00:00</updated>
<author>
<name>Scott Escue</name>
<email>scott.escue@gmail.com</email>
</author>
<published>2018-05-22T20:04:19+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=6540a9468a8bce3f496423179db1862cfb9f5c8c'/>
<id>6540a9468a8bce3f496423179db1862cfb9f5c8c</id>
<content type='text'>
If window.location contains a URL fragment, append the fragment to all sign-in forms, the sign-up form, and all button based providers.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
If window.location contains a URL fragment, append the fragment to all sign-in forms, the sign-up form, and all button based providers.
</pre>
</div>
</content>
</entry>
<entry>
<title>Whitelist existing destroy_all offenses</title>
<updated>2018-08-16T15:29:37+00:00</updated>
<author>
<name>Yorick Peterse</name>
<email>yorickpeterse@gmail.com</email>
</author>
<published>2018-08-16T12:46:40+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=9606dbbb033567de9831a8cdea0e56236e7d2eb2'/>
<id>9606dbbb033567de9831a8cdea0e56236e7d2eb2</id>
<content type='text'>
This whitelists all existing places where we use "destroy_all".
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This whitelists all existing places where we use "destroy_all".
</pre>
</div>
</content>
</entry>
</feed>
