delta/gitlab/gitlab-ce.git/spec/controllers/groups_controller_spec.rb, branch commit-message-contribution gitlab.com: gitlab-org/gitlab-ce.git Fix sorting issues/mrs by votes on the groups page 2016-03-21T20:01:38+00:00 Douglas Barbosa Alexandre dbalexandre@gmail.com 2016-03-21T20:01:38+00:00 100e3e7601dd4d3033cd8292814273dd0354722e The `non_archived` scope applied here https://gitlab.com/gitlab-org/gitlab-ce/blob/master/app/controllers/conc erns/issues_action.rb#L5 overrides the previous `ORDER BY` applied inside the IssuesFinder, with the default scope of the Project model, resulting in SQL errors. 
The `non_archived` scope applied here
https://gitlab.com/gitlab-org/gitlab-ce/blob/master/app/controllers/conc
erns/issues_action.rb#L5 overrides the previous `ORDER BY` applied
inside the IssuesFinder, with the default scope of the Project model,
resulting in SQL errors.
Make the `/groups` route behave as expected 2016-01-24T00:10:13+00:00 Robert Speicher rspeicher@gmail.com 2016-01-24T00:08:15+00:00 a7c4d0da8c7a340efd7b92718cd0f9436f2ec56f The route is supposed to redirect the Groups#index request based on whether or not a user was logged in. If they are, we redirect them to their groups dashboard; if they're not, we redirect them to the public Explore page. But due to overly aggressive `before_action`s that weren't excluding the `index` action, the request always resulted in a 404, whether a user was logged in or not. Closes #12660 
The route is supposed to redirect the Groups#index request based on
whether or not a user was logged in. If they are, we redirect them to
their groups dashboard; if they're not, we redirect them to the public
Explore page.

But due to overly aggressive `before_action`s that weren't excluding the
`index` action, the request always resulted in a 404, whether a user was
logged in or not.

Closes #12660