delta/gitlab/gitlab-ce.git/spec/controllers/groups_controller_spec.rb, branch bugfix/upgrade-ruby-parser

Merge branch 'rework-authorizations-performance' into 'master'

2017-05-29T15:49:56+00:00

Rework project authorizations and nested groups for better performance

See merge request !10885

Refactor to more robust implementation

2017-05-19T16:13:27+00:00

In order to avoid string manipulation or modify route params (to make them unambiguous for `url_for`), we are accepting a behavior change:

When being redirected to the canonical path for a group, if you requested a group show path starting with `/groups/…` then you’ll now be redirected to the group at root `/…`.

Fix ensure_canonical_path for top level routes

2017-05-18T23:24:10+00:00

Don’t replace a substring of the path if it is part of the top level route.

E.g. When redirecting from `/groups/ups` to `/groups/foo`, be careful not to do `/grofoo/ups`.

Projects are unaffected by this issue, but I am grouping the `#ensure_canonical_path` tests similar to the group and user tests.

Add test that fails without the fix

2017-05-18T17:30:17+00:00

Hide nested group UI/API support for MySQL

2017-05-17T18:53:16+00:00

This hides/disables some UI elements and API parameters related to
nested groups when MySQL is used, since nested groups are not supported
for MySQL.

Fix redirect message for groups and users

2017-05-11T22:28:13+00:00

Merge branch '27144-enforce-rubocop-trailing_commas-no_comma-style' into 'master'

2017-05-10T21:43:34+00:00


Resolve "Use consistent style for trailing commas"

Closes #27144

See merge request !11063

Enable the Style/TrailingCommaInArguments cop

2017-05-10T16:25:45+00:00

Use the EnforcedStyleForMultiline: no_comma option.

Signed-off-by: Rémy Coutable

Merge branch 'tc-fix-private-subgroups-shown' into 'security'

2017-05-10T14:48:18+00:00


Use GroupsFinder to find subgroups the user has access to

See merge request !2096

Resolve discussions

2017-05-05T19:12:50+00:00