delta/gitlab/gitlab-ce.git/spec/controllers/blob_controller_spec.rb, branch patch-6

Fix Error 500 when viewing a blob with binary characters after the 1024-byte mark

2016-06-12T14:36:25+00:00

Here was the problem:

1. When determining whether a given blob is viewable text, gitlab_git reads the first 1024 bytes and checks with Linguist whether it is a text or binary file.
2. If the blob is text, GitLab will attempt to display it.
3. However, if the text has binary characters after the first 1024 bytes, then GitLab will attempt to load the entire contents, but the encoding will be ASCII-8BIT since there are binary characters.
4. The Error 500 results when GitLab attempts to display a mix UTF-8 and ASCII-8BIT.

To fix this, we load as much data as we are willing to display so that the detection will work properly. Requires
an update to gitlab_git: gitlab-org/gitlab_git!86

Closes #13826

Fix Style/AlignHash cop violations

2015-06-23T05:24:39+00:00

Upgrade to Rails 4.1.9

2015-02-14T18:09:23+00:00

Make the following changes to deal with new behavior in Rails 4.1.2:

* Use nested resources to avoid slashes in arguments to path helpers.

Even more hound fixes

2015-02-12T20:00:55+00:00

Signed-off-by: Jeroen van Baarsen

Fixed hound warnings

2015-02-12T18:32:58+00:00

Signed-off-by: Jeroen van Baarsen

Updated rspec to rspec 3.x syntax

2015-02-12T18:17:35+00:00

Signed-off-by: Jeroen van Baarsen

Fix tests

2014-08-07T17:46:17+00:00

Signed-off-by: Dmitriy Zaporozhets

Add tests for redirects.

2014-07-08T18:25:25+00:00

Make changes to tests

2014-01-22T19:03:52+00:00

* project_with_code -> project
* project -> ermpty_project

Signed-off-by: Dmitriy Zaporozhets

Drop support of root namespace in routing

2013-09-12T22:00:24+00:00