<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/gitlab/gitlab-ce.git/spec/controllers/admin, branch frozen_string_spec_models</title>
<subtitle>gitlab.com: gitlab-org/gitlab-ce.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/'/>
<entry>
<title>Fix undefined variable error on json project views</title>
<updated>2019-03-19T00:27:28+00:00</updated>
<author>
<name>Alejandro Rodríguez</name>
<email>alejorro70@gmail.com</email>
</author>
<published>2019-03-19T00:01:49+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=585fcfb9e7be7300af04cd2f9c6d1d97d5333cf5'/>
<id>585fcfb9e7be7300af04cd2f9c6d1d97d5333cf5</id>
<content type='text'>
This mistake seems to have always been there, but it only resulted in
errors on the `/explore*.json` since they were the one that _actually_
relied on the local variables.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This mistake seems to have always been there, but it only resulted in
errors on the `/explore*.json` since they were the one that _actually_
relied on the local variables.
</pre>
</div>
</content>
</entry>
<entry>
<title>Show header and footer system messages in email</title>
<updated>2019-02-27T20:07:50+00:00</updated>
<author>
<name>Alexandru Croitor</name>
<email>acroitor@gitlab.com</email>
</author>
<published>2019-02-20T15:18:15+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=77985826d94454514c40b8da926e13b3b3791841'/>
<id>77985826d94454514c40b8da926e13b3b3791841</id>
<content type='text'>
* Add email_header_and_footer_enabled flag to appearances table
* Set email_header_and_footer_enabled default value to false
* Add checkbox to appearance to toggle show header and footer in emails
* Add email_header_and_footer_enabled to allowed params in controller
* Add header and footer messages to the html and text email layouts
* Remove the color styling for emails header and footer
* Add empty_mailer layout for emails without layout,
to have the header and footer applied
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
* Add email_header_and_footer_enabled flag to appearances table
* Set email_header_and_footer_enabled default value to false
* Add checkbox to appearance to toggle show header and footer in emails
* Add email_header_and_footer_enabled to allowed params in controller
* Add header and footer messages to the html and text email layouts
* Remove the color styling for emails header and footer
* Add empty_mailer layout for emails without layout,
to have the header and footer applied
</pre>
</div>
</content>
</entry>
<entry>
<title>Remove N+1 query for tags in /admin/runners page</title>
<updated>2019-02-26T20:44:28+00:00</updated>
<author>
<name>Stan Hu</name>
<email>stanhu@gmail.com</email>
</author>
<published>2019-02-26T19:30:43+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=ebb284c0dc59e2fd5bc76921609b60034f000c53'/>
<id>ebb284c0dc59e2fd5bc76921609b60034f000c53</id>
<content type='text'>
As discussed in https://github.com/mbleigh/acts-as-taggable-on/issues/91,
we can avoid N+1 queries if we use `tags` instead of `tag_list`.

Seen while reviewing
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/19740.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
As discussed in https://github.com/mbleigh/acts-as-taggable-on/issues/91,
we can avoid N+1 queries if we use `tags` instead of `tag_list`.

Seen while reviewing
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/19740.
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'sh-fix-users-controller-ruby-2.6-compat' into 'master'</title>
<updated>2019-02-25T11:20:41+00:00</updated>
<author>
<name>Douwe Maan</name>
<email>douwe@gitlab.com</email>
</author>
<published>2019-02-25T11:20:41+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=e5c7027faffb75f1d2f7221fa11609741010d82f'/>
<id>e5c7027faffb75f1d2f7221fa11609741010d82f</id>
<content type='text'>
Make Admin::UsersController work with Ruby 2.6

See merge request gitlab-org/gitlab-ce!25316</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Make Admin::UsersController work with Ruby 2.6

See merge request gitlab-org/gitlab-ce!25316</pre>
</div>
</content>
</entry>
<entry>
<title>Port EE System Header And Footer feature to CE</title>
<updated>2019-02-21T15:55:51+00:00</updated>
<author>
<name>Douwe Maan</name>
<email>douwe@gitlab.com</email>
</author>
<published>2018-04-02T14:26:59+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=28e1739a3fd8c93e4805fe0053faf820cec4e1bc'/>
<id>28e1739a3fd8c93e4805fe0053faf820cec4e1bc</id>
<content type='text'>
remove EE specific code
remove EE licence checks
move migration from EE to CE folder structure
move specs from EE to CE folder structure
remove EE specific flag specs
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
remove EE specific code
remove EE licence checks
move migration from EE to CE folder structure
move specs from EE to CE folder structure
remove EE specific flag specs
</pre>
</div>
</content>
</entry>
<entry>
<title>Make Admin::UsersController work with Ruby 2.6</title>
<updated>2019-02-19T23:36:05+00:00</updated>
<author>
<name>Stan Hu</name>
<email>stanhu@gmail.com</email>
</author>
<published>2019-02-16T22:26:15+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=e87c255d9e76fb3ca691267107e83d48c90bc816'/>
<id>e87c255d9e76fb3ca691267107e83d48c90bc816</id>
<content type='text'>
Ruby 2.6 introduced `Enumerable#filter`, which takes no arguments.
Attempting to call `filter` on an `ActiveRecord::Relation` with a scope
will fail with a `wrong number of arguments (given 1, expected 0)`
message because the `Enumerable#filter` implementation overrides the
delegated `ActiveRecord::Relation#filter` method.

To make Admin::UsersController compatible with Ruby 2.6, rename
`User.filter` to `User.filter_items`.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Ruby 2.6 introduced `Enumerable#filter`, which takes no arguments.
Attempting to call `filter` on an `ActiveRecord::Relation` with a scope
will fail with a `wrong number of arguments (given 1, expected 0)`
message because the `Enumerable#filter` implementation overrides the
delegated `ActiveRecord::Relation#filter` method.

To make Admin::UsersController compatible with Ruby 2.6, rename
`User.filter` to `User.filter_items`.
</pre>
</div>
</content>
</entry>
<entry>
<title>Admin section finds users case-insensitively</title>
<updated>2019-02-12T22:28:06+00:00</updated>
<author>
<name>Robert Speicher</name>
<email>rspeicher@gmail.com</email>
</author>
<published>2019-02-12T22:26:07+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=12c70e636c432a5388f6fcb2508a9644ed24aa5c'/>
<id>12c70e636c432a5388f6fcb2508a9644ed24aa5c</id>
<content type='text'>
Previously, if you entered a username in the URL manually to view a
specific user, the lookup was done case-sensitively, despite usernames
being case-insensitive, often resulting in a 404. We now use the same
`find_routable!` logic as the non-admin Users controller.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Previously, if you entered a username in the URL manually to view a
specific user, the lookup was done case-sensitively, despite usernames
being case-insensitive, often resulting in a 404. We now use the same
`find_routable!` logic as the non-admin Users controller.
</pre>
</div>
</content>
</entry>
<entry>
<title>Fix requests profiler in admin page not rendering HTML properly</title>
<updated>2019-01-10T07:09:43+00:00</updated>
<author>
<name>Stan Hu</name>
<email>stanhu@gmail.com</email>
</author>
<published>2019-01-10T06:50:51+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=4ac4ba2654c9ffa6065e6d4789c279d676c5971b'/>
<id>4ac4ba2654c9ffa6065e6d4789c279d676c5971b</id>
<content type='text'>
By default in Rails 5, content passed to `render` will be
escaped. This doesn't work for the HTML profile output, which
should be considered safe HTML already.

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/56152
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
By default in Rails 5, content passed to `render` will be
escaped. This doesn't work for the HTML profile output, which
should be considered safe HTML already.

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/56152
</pre>
</div>
</content>
</entry>
<entry>
<title>Update specs to rails5 format</title>
<updated>2018-12-18T23:04:31+00:00</updated>
<author>
<name>blackst0ne</name>
<email>blackst0ne.ru@gmail.com</email>
</author>
<published>2018-12-17T22:52:17+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=b44a2c801a64fb282cea794871fcfcf81e4ec539'/>
<id>b44a2c801a64fb282cea794871fcfcf81e4ec539</id>
<content type='text'>
Updates specs to use new rails5 format.

The old format:
`get :show, { some: params }, { some: headers }`

The new format:
`get :show, params: { some: params }, headers: { some: headers }`
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Updates specs to use new rails5 format.

The old format:
`get :show, { some: params }, { some: headers }`

The new format:
`get :show, params: { some: params }, headers: { some: headers }`
</pre>
</div>
</content>
</entry>
<entry>
<title>Add config to disable impersonation</title>
<updated>2018-11-29T08:37:16+00:00</updated>
<author>
<name>Imre Farkas</name>
<email>ifarkas@gitlab.com</email>
</author>
<published>2018-11-24T12:39:16+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=bd3a4840329160a64c0cac25ed6c1d3b22f5bdb4'/>
<id>bd3a4840329160a64c0cac25ed6c1d3b22f5bdb4</id>
<content type='text'>
Adds gitlab.impersonation_enabled config option defaulting to true to
keep the current default behaviour.

Only the act of impersonation is modified, impersonation token
management is not affected.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Adds gitlab.impersonation_enabled config option defaulting to true to
keep the current default behaviour.

Only the act of impersonation is modified, impersonation token
management is not affected.
</pre>
</div>
</content>
</entry>
</feed>
