delta/gitlab/gitlab-ce.git/spec/controllers/admin/runners_controller_spec.rb, branch app-differences

Upgrade to Rails 5.2

2019-07-12T02:15:31+00:00

Updates changed method names and fixes spec failures

Add some frozen string to spec/**/*.rb

2019-04-15T10:17:05+00:00

Adds frozen string to the following:

* spec/bin/**/*.rb
* spec/config/**/*.rb
* spec/controllers/**/*.rb

xref https://gitlab.com/gitlab-org/gitlab-ce/issues/59758

Remove N+1 query for tags in /admin/runners page

2019-02-26T20:44:28+00:00

As discussed in https://github.com/mbleigh/acts-as-taggable-on/issues/91,
we can avoid N+1 queries if we use `tags` instead of `tag_list`.

Seen while reviewing
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/19740.

Update specs to rails5 format

2018-12-18T23:04:31+00:00

Updates specs to use new rails5 format.

The old format:
`get :show, { some: params }, { some: headers }`

The new format:
`get :show, params: { some: params }, headers: { some: headers }`

Refactor `have_http_status` into `have_gitlab_http_status` in the specs

2017-10-20T08:13:18+00:00

Use expect { }.to change { }

2017-02-15T12:21:51+00:00

Feedback:
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/8664#note_23427575

Add some tests for admin/project runners page

2017-02-15T11:16:12+00:00