delta/gitlab/gitlab-ce.git/scripts/review_apps, branch docs-app-dev-platform gitlab.com: gitlab-org/gitlab-ce.git Apply suggestion to scripts/review_apps/review-apps.sh 2019-06-12T17:01:15+00:00 Rémy Coutable remy@rymai.me 2019-06-12T17:01:15+00:00 7c1422c79555543062eee10c592f35fbe292fd2f 






[Review Apps] Set `global.imagePullPolicy: Always`
2019-06-12T11:22:12+00:00

Rémy Coutable
remy@rymai.me

2019-05-22T11:00:35+00:00

97037e4a11afc3c86702ba9b97c8ace9abe65f3b

Signed-off-by: Rémy Coutable <remy@rymai.me>





Signed-off-by: Rémy Coutable <remy@rymai.me>







Disable HTTP for the nginx-ingress Review App service
2019-04-30T07:49:10+00:00

Rémy Coutable
remy@rymai.me

2019-04-30T07:49:10+00:00

84103e2d2f2668053c09e7fc225610005dfaa3f7

Signed-off-by: Rémy Coutable <remy@rymai.me>





Signed-off-by: Rémy Coutable <remy@rymai.me>







Organize better Review Apps and QA jobs
2019-04-24T17:25:37+00:00

Rémy Coutable
remy@rymai.me

2019-04-18T19:18:20+00:00

9649c2ef474701646e74bfd5134613528018a6c1

Also, play manual jobs once dependency jobs are done instead of polling
for the dependent jobs to be finished.

Signed-off-by: Rémy Coutable <remy@rymai.me>





Also, play manual jobs once dependency jobs are done instead of polling
for the dependent jobs to be finished.

Signed-off-by: Rémy Coutable <remy@rymai.me>







Make the Review App cleanup more efficient
2019-04-19T08:50:43+00:00

Rémy Coutable
remy@rymai.me

2019-04-18T14:05:21+00:00

d0efb430ce43953d659b1f62bf58a9ac41804bc3

Ensure that the cleanup starts right away.

Signed-off-by: Rémy Coutable <remy@rymai.me>





Ensure that the cleanup starts right away.

Signed-off-by: Rémy Coutable <remy@rymai.me>







Don't fail the job if the Review App doesn't deploy properly
2019-04-17T08:49:02+00:00

Rémy Coutable
remy@rymai.me

2019-04-10T15:28:23+00:00

955136b56dd0551c18fc9917a3ea94790081d9df

It seems the deploy function causes the job to fail if it doesn't
succeed. That wasn't the intent as we want to curl the Review App after
the deploy finished (even if it failed) because sometimes the Review App
is just a bit long to be ready.

This change wraps the Review App deployment with "set +e"/"set -e" to
ensure that the job doesn't fail right away if the deploy fails.

Signed-off-by: Rémy Coutable <remy@rymai.me>





It seems the deploy function causes the job to fail if it doesn't
succeed. That wasn't the intent as we want to curl the Review App after
the deploy finished (even if it failed) because sometimes the Review App
is just a bit long to be ready.

This change wraps the Review App deployment with "set +e"/"set -e" to
ensure that the job doesn't fail right away if the deploy fails.

Signed-off-by: Rémy Coutable <remy@rymai.me>







Conform scripts/review_apps/review-apps.sh to shellcheck
2019-04-09T13:57:04+00:00

Rémy Coutable
remy@rymai.me

2019-04-09T11:12:49+00:00

64960ae762e16d5faeb029d2e8e5f557ff46ce24

Signed-off-by: Rémy Coutable <remy@rymai.me>





Signed-off-by: Rémy Coutable <remy@rymai.me>







Poll Review App after it's deployed to ensure it's accessible
2019-04-09T13:56:53+00:00

Rémy Coutable
remy@rymai.me

2019-04-08T17:10:18+00:00

6dadd965dc45f795fdf45b07e50e1a829d0b60c6

Signed-off-by: Rémy Coutable <remy@rymai.me>





Signed-off-by: Rémy Coutable <remy@rymai.me>







Add more logging in the Review Apps deployment steps
2019-03-28T10:56:38+00:00

Rémy Coutable
remy@rymai.me

2019-03-27T09:36:01+00:00

42102cd13aac63a81eb0208ebc74e2301799c621

Signed-off-by: Rémy Coutable <remy@rymai.me>





Signed-off-by: Rémy Coutable <remy@rymai.me>







Fix the .review-deploy-base job so that env variables are passed
2019-03-19T07:31:20+00:00

Rémy Coutable
remy@rymai.me

2019-03-19T07:30:25+00:00

dc2a482ba16fb43d8b772209b3a6863be3843f81

Signed-off-by: Rémy Coutable <remy@rymai.me>





Signed-off-by: Rémy Coutable <remy@rymai.me>