<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/gitlab/gitlab-ce.git/rubocop, branch patch-50</title>
<subtitle>gitlab.com: gitlab-org/gitlab-ce.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/'/>
<entry>
<title>Properly handle `ee` migration specs</title>
<updated>2019-03-27T21:48:53+00:00</updated>
<author>
<name>Heinrich Lee Yu</name>
<email>heinrich@gitlab.com</email>
</author>
<published>2019-03-27T21:48:53+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=f234d9f12d6a054412067b955d3b765325d4ccc6'/>
<id>f234d9f12d6a054412067b955d3b765325d4ccc6</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'fix-rubocop-ee-module-injection-detection' into 'master'</title>
<updated>2019-01-16T18:10:38+00:00</updated>
<author>
<name>Rémy Coutable</name>
<email>remy@rymai.me</email>
</author>
<published>2019-01-16T18:10:38+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=941f95ec7c3014dd6d12151434cb502379854402'/>
<id>941f95ec7c3014dd6d12151434cb502379854402</id>
<content type='text'>
Fix detecting nested EE constants in RuboCop

See merge request gitlab-org/gitlab-ce!24430</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Fix detecting nested EE constants in RuboCop

See merge request gitlab-org/gitlab-ce!24430</pre>
</div>
</content>
</entry>
<entry>
<title>Fix detecting nested EE constants in RuboCop</title>
<updated>2019-01-16T15:48:18+00:00</updated>
<author>
<name>Yorick Peterse</name>
<email>yorickpeterse@gmail.com</email>
</author>
<published>2019-01-16T14:21:50+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=9722158c15300dd4507cbb49b4230ab36b36ae65'/>
<id>9722158c15300dd4507cbb49b4230ab36b36ae65</id>
<content type='text'>
The InjectEnterpriseEditionModule cop would not detect certain nested EE
constants such as `EE::Foo::Bar::Baz`. This could result in it not
enforcing `prepend` being placed on the last line. This commit fixes
this by just performing a string match on the line, instead of relying
on AST matching.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The InjectEnterpriseEditionModule cop would not detect certain nested EE
constants such as `EE::Foo::Bar::Baz`. This could result in it not
enforcing `prepend` being placed on the last line. This commit fixes
this by just performing a string match on the line, instead of relying
on AST matching.
</pre>
</div>
</content>
</entry>
<entry>
<title>Prevent factories in background migration specs</title>
<updated>2019-01-16T12:15:33+00:00</updated>
<author>
<name>Bob Van Landuyt</name>
<email>bob@vanlanduyt.co</email>
</author>
<published>2019-01-16T10:35:08+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=7c801333a0f2c01639ed2d4b0eb5a1008de98fdb'/>
<id>7c801333a0f2c01639ed2d4b0eb5a1008de98fdb</id>
<content type='text'>
The Background migration specs also run against a certain version of
the database. So we should avoid using factories.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The Background migration specs also run against a certain version of
the database. So we should avoid using factories.
</pre>
</div>
</content>
</entry>
<entry>
<title>Added Cop for injecting EE modules</title>
<updated>2018-12-13T15:09:21+00:00</updated>
<author>
<name>Yorick Peterse</name>
<email>yorickpeterse@gmail.com</email>
</author>
<published>2018-12-13T14:46:01+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=7c580556319658daae5a77b252e83bfc54305e64'/>
<id>7c580556319658daae5a77b252e83bfc54305e64</id>
<content type='text'>
This Cop enforces the rule that injecting EE modules (using prepend,
include, or extend) is done by placing the injection on the last line of
a file, instead of somewhere in the middle. By placing these lines at
the very end, merge conflicts will not happen.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This Cop enforces the rule that injecting EE modules (using prepend,
include, or extend) is done by placing the injection on the last line of
a file, instead of somewhere in the middle. By placing these lines at
the very end, merge conflicts will not happen.
</pre>
</div>
</content>
</entry>
<entry>
<title>Make add_reference cop accept a hash for :index</title>
<updated>2018-11-27T10:40:38+00:00</updated>
<author>
<name>Toon Claes</name>
<email>toon@gitlab.com</email>
</author>
<published>2018-11-22T20:13:36+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=54b639195ddb2d11b5a5e8208d5f94df365041db'/>
<id>54b639195ddb2d11b5a5e8208d5f94df365041db</id>
<content type='text'>
It might happen you want to make the reference column have a unique
value, or you want to create partial indexes. So instead of only
accepting a `true` value, also accept a hash of options.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
It might happen you want to make the reference column have a unique
value, or you want to create partial indexes. So instead of only
accepting a `true` value, also accept a hash of options.
</pre>
</div>
</content>
</entry>
<entry>
<title>Add cop prohibiting params argument in url_for</title>
<updated>2018-11-22T09:08:18+00:00</updated>
<author>
<name>Jarka Košanová</name>
<email>jarka@gitlab.com</email>
</author>
<published>2018-11-15T09:50:04+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=186b2143abacf60611896bad829ad7eb3456f77d'/>
<id>186b2143abacf60611896bad829ad7eb3456f77d</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Whitelist none method from ActiveRecord::Querying</title>
<updated>2018-10-31T18:46:36+00:00</updated>
<author>
<name>Douglas Barbosa Alexandre</name>
<email>dbalexandre@gmail.com</email>
</author>
<published>2018-10-31T17:39:24+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=01d8c1f6f0dacbb8d4779d0226e1c02eb11dfe0e'/>
<id>01d8c1f6f0dacbb8d4779d0226e1c02eb11dfe0e</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Add a new QA::ElementWithPattern cop</title>
<updated>2018-10-15T12:28:03+00:00</updated>
<author>
<name>Rémy Coutable</name>
<email>remy@rymai.me</email>
</author>
<published>2018-10-11T17:10:42+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=02c47f2f73ac2d5a33b9a6c971668a38397b4910'/>
<id>02c47f2f73ac2d5a33b9a6c971668a38397b4910</id>
<content type='text'>
This cop forbids the use of `element :foo, 'pattern'` and
`element :bar, /pattern/` in QA files.

Signed-off-by: Rémy Coutable &lt;remy@rymai.me&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This cop forbids the use of `element :foo, 'pattern'` and
`element :bar, /pattern/` in QA files.

Signed-off-by: Rémy Coutable &lt;remy@rymai.me&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Applies the CE backport of EE#657</title>
<updated>2018-09-24T11:02:01+00:00</updated>
<author>
<name>Tiago Botelho</name>
<email>tiagonbotelho@hotmail.com</email>
</author>
<published>2018-09-07T12:29:19+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=81d949f656979429835e0b6059a10a44faba488b'/>
<id>81d949f656979429835e0b6059a10a44faba488b</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
</feed>
