delta/gitlab/gitlab-ce.git/rubocop, branch instance_level_clusters

Run rubocop -a on CE files

2019-05-05T10:24:28+00:00

Upgrade to Rubocop 0.68.1

2019-05-05T10:24:27+00:00

This adds Ruby 2.6 support.

Cache current working directory to speed up Rubocop

2019-05-03T12:44:46+00:00

This saves thousands of getcwd() system calls and improves the
performance of running Rubocop, which is also used by HAML linting.

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/61383

Add Rubocop rule to ban include ActionView::Context

2019-04-29T13:14:53+00:00

Forbid the use of `#reload` and prefer `#reset`

2019-04-15T11:05:14+00:00

The `#reload` makes to load all objects into memory,
and the main purpose of `#reload` is to drop the association cache.

The `#reset` seems to solve exactly that case.

Properly handle `ee` migration specs

2019-03-27T21:48:53+00:00

Merge branch 'fix-rubocop-ee-module-injection-detection' into 'master'

2019-01-16T18:10:38+00:00

Fix detecting nested EE constants in RuboCop

See merge request gitlab-org/gitlab-ce!24430

Fix detecting nested EE constants in RuboCop

2019-01-16T15:48:18+00:00

The InjectEnterpriseEditionModule cop would not detect certain nested EE
constants such as `EE::Foo::Bar::Baz`. This could result in it not
enforcing `prepend` being placed on the last line. This commit fixes
this by just performing a string match on the line, instead of relying
on AST matching.

Prevent factories in background migration specs

2019-01-16T12:15:33+00:00

The Background migration specs also run against a certain version of
the database. So we should avoid using factories.

Added Cop for injecting EE modules

2018-12-13T15:09:21+00:00

This Cop enforces the rule that injecting EE modules (using prepend,
include, or extend) is done by placing the injection on the last line of
a file, instead of somewhere in the middle. By placing these lines at
the very end, merge conflicts will not happen.