delta/gitlab/gitlab-ce.git/rubocop, branch docs/split-autodevops-variable-table gitlab.com: gitlab-org/gitlab-ce.git Change element_with_pattern cop to not use quotes 2019-07-10T23:10:28+00:00 ddavison ddavison@gitlab.com 2019-07-09T21:44:16+00:00 015b61b1dc73e2c8d6e6cf04b6b2c7fb896a452f Using quotes within string validations can be messy. Let's use a typical CSS selector for an unquoted attribute Update the cop spec to validate appropriate new message 
Using quotes within string validations can be messy. Let's
use  a typical CSS selector for an unquoted attribute

Update the cop spec to validate appropriate new message
Introduce data-qa-selector to supplant .qa-class 2019-07-10T23:09:43+00:00 ddavison ddavison@gitlab.com 2019-05-29T23:47:53+00:00 390e0d8906c066996e8bbb14aa5824643f9798f8 In order to break away from using CSS classes as our primary method of element identification, we need to provide the ability to search for data attributes. Make Test::Sanity::Selectors now work Utilize regex to match on literal strings of the element name Suggest the data-qa-selector pattern vs the qa- Add data-qa-selector to login page to start We need a page that is heavily used in order to be confident that this functionality works. Let's start with the Login page Use appropriate HAML data tag practices 
In order to break away from using CSS classes as
our primary method of element identification, we
need to provide the ability to search for data
attributes.

Make Test::Sanity::Selectors now work

Utilize regex to match on literal strings of the element name

Suggest the data-qa-selector pattern vs the qa-

Add data-qa-selector to login page to start

We need a page that is heavily used in order to be
confident that this functionality works. Let's start
with the Login page

Use appropriate HAML data tag practices
Add a rubocop for Rails.logger 2019-07-10T19:26:47+00:00 Mayra Cabrera mcabrera@gitlab.com 2019-07-10T19:26:47+00:00 0ab89d8e36ba58a95244b4c6dd49d53fac7a699f Suggests to use a JSON structured log instead Related to https://gitlab.com/gitlab-org/gitlab-ce/issues/54102 
Suggests to use a JSON structured log instead

Related to https://gitlab.com/gitlab-org/gitlab-ce/issues/54102
Add a cop to ensure we authorize GraphQL types 2019-06-21T11:00:50+00:00 Bob Van Landuyt bob@vanlanduyt.co 2019-06-18T14:18:26+00:00 ac2d08212b20bae20c85ea225ec3fb0052a9e1af 






Merge branch 'qa-extend-click-visit-actions' into 'master'
2019-05-28T16:44:22+00:00

Dan Davison
ddavison@gitlab.com

2019-05-28T16:44:22+00:00

e6c6acaf0750700614e9a28d1eb42ae6a206f90f

Implement dynamic validation on QA Pages

Closes gitlab-qa#280

See merge request gitlab-org/gitlab-ce!25704




Implement dynamic validation on QA Pages

Closes gitlab-qa#280

See merge request gitlab-org/gitlab-ce!25704






Link to issue in CodeReuse/ActiveRecord message
2019-05-21T23:37:46+00:00

Luke Duncalfe
lduncalfe@eml.cc

2019-05-20T05:13:29+00:00

3783c23457adaa4a1f97ffd0891a1a5a8d02f188

This provides the user with some context as to why certain ActiveRecord
methods are blacklisted.





This provides the user with some context as to why certain ActiveRecord
methods are blacklisted.







Implement dynamic validation on QA Pages
2019-05-20T19:35:51+00:00

ddavison
ddavison@gitlab.com

2019-03-02T02:03:43+00:00

7d5b68d837545909204e6caf2352f34ac2f1ba7a

Elements now have the ability to be required on pages or not
Currently using the default wait mechanism
Altered the ElementWithPattern Cop to fit new splat for init





Elements now have the ability to be required on pages or not
Currently using the default wait mechanism
Altered the ElementWithPattern Cop to fit new splat for init







Run rubocop -a on CE files
2019-05-05T10:24:28+00:00

Stan Hu
stanhu@gmail.com

2019-05-05T10:19:14+00:00

f93b2e02a56a3b1f3041119e8302d43aeafc8284












Upgrade to Rubocop 0.68.1
2019-05-05T10:24:27+00:00

Stan Hu
stanhu@gmail.com

2019-05-03T04:40:40+00:00

d40298c8584fcd06b9549ab1674a3ec9c0ad9af0

This adds Ruby 2.6 support.





This adds Ruby 2.6 support.







Cache current working directory to speed up Rubocop
2019-05-03T12:44:46+00:00

Stan Hu
stanhu@gmail.com

2019-05-03T12:41:47+00:00

a8cbec49a09fc82f5d6b0a74f06858b667f39a56

This saves thousands of getcwd() system calls and improves the
performance of running Rubocop, which is also used by HAML linting.

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/61383





This saves thousands of getcwd() system calls and improves the
performance of running Rubocop, which is also used by HAML linting.

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/61383