<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/gitlab/gitlab-ce.git/rubocop/cop, branch fix-github-clone-wiki</title>
<subtitle>gitlab.com: gitlab-org/gitlab-ce.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/'/>
<entry>
<title>Added Cop to blacklist polymorphic associations</title>
<updated>2017-06-07T15:36:55+00:00</updated>
<author>
<name>Yorick Peterse</name>
<email>yorickpeterse@gmail.com</email>
</author>
<published>2017-06-02T12:29:30+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=5819ca1a249d1daf3b4feb655c217c98a1b70225'/>
<id>5819ca1a249d1daf3b4feb655c217c98a1b70225</id>
<content type='text'>
One should really use a separate table instead of using polymorphic
associations.

See https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/11168 for
more information.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
One should really use a separate table instead of using polymorphic
associations.

See https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/11168 for
more information.
</pre>
</div>
</content>
</entry>
<entry>
<title>Add a rubocop rule to check if a method 'redirect_to' is used without explicitly set 'status' in 'destroy' actions of controllers</title>
<updated>2017-06-06T22:45:16+00:00</updated>
<author>
<name>blackst0ne</name>
<email>blackst0ne.ru@gmail.com</email>
</author>
<published>2017-06-06T22:45:16+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=a544e46bb083c27bfa2966ea67ddf97b5dc7cb08'/>
<id>a544e46bb083c27bfa2966ea67ddf97b5dc7cb08</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Added Cop to blacklist the use of serialize</title>
<updated>2017-05-31T12:03:37+00:00</updated>
<author>
<name>Yorick Peterse</name>
<email>yorickpeterse@gmail.com</email>
</author>
<published>2017-05-31T11:47:36+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=cd74c1434e42f7e6aa12fe2e2b8d9b1e56aea78f'/>
<id>cd74c1434e42f7e6aa12fe2e2b8d9b1e56aea78f</id>
<content type='text'>
This Cop blacklists the use of ActiveRecord's "serialize" method, except
for cases where we already use this.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This Cop blacklists the use of ActiveRecord's "serialize" method, except
for cases where we already use this.
</pre>
</div>
</content>
</entry>
<entry>
<title>New Migration/UpdateColumnInBatches cop</title>
<updated>2017-05-29T09:28:23+00:00</updated>
<author>
<name>Rémy Coutable</name>
<email>remy@rymai.me</email>
</author>
<published>2017-05-22T16:31:22+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=187e6c8d7c9eea51358bb9b653a512ac98fa5746'/>
<id>187e6c8d7c9eea51358bb9b653a512ac98fa5746</id>
<content type='text'>
Signed-off-by: Rémy Coutable &lt;remy@rymai.me&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Signed-off-by: Rémy Coutable &lt;remy@rymai.me&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Add AddColumnWithDefaultToLargeTable cop</title>
<updated>2017-04-28T20:55:55+00:00</updated>
<author>
<name>Robert Speicher</name>
<email>rspeicher@gmail.com</email>
</author>
<published>2017-04-24T17:48:35+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=b9fa17d87b534e588d80bb029c7f8cf9f9ff0c45'/>
<id>b9fa17d87b534e588d80bb029c7f8cf9f9ff0c45</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Rename AddColumnWithDefault to ReversibleAddColumnWithDefault</title>
<updated>2017-04-28T20:55:53+00:00</updated>
<author>
<name>Robert Speicher</name>
<email>rspeicher@gmail.com</email>
</author>
<published>2017-04-24T17:16:33+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=9c27c90b4a8a9ea179af9588a7dbd2037829905f'/>
<id>9c27c90b4a8a9ea179af9588a7dbd2037829905f</id>
<content type='text'>
We're going to add another cop that deals with another aspect of
`add_column_with_default`, so we need to separate them.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
We're going to add another cop that deals with another aspect of
`add_column_with_default`, so we need to separate them.
</pre>
</div>
</content>
</entry>
<entry>
<title>Refactor the AddColumnWithDefault cop to use node matchers</title>
<updated>2017-04-28T20:55:53+00:00</updated>
<author>
<name>Robert Speicher</name>
<email>rspeicher@gmail.com</email>
</author>
<published>2017-04-24T17:14:09+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=bbdaf982e6e9b4f674a309df9b16fb9c85498b50'/>
<id>bbdaf982e6e9b4f674a309df9b16fb9c85498b50</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Add remove_concurrent_index to database helper</title>
<updated>2017-04-05T22:53:57+00:00</updated>
<author>
<name>blackst0ne</name>
<email>blackst0ne.ru@gmail.com</email>
</author>
<published>2017-04-05T22:53:57+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=9997c58fc0db6469cde1a21428e050aa7b550a9a'/>
<id>9997c58fc0db6469cde1a21428e050aa7b550a9a</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Add cop to ensure reversibility of add_concurrent_index</title>
<updated>2017-03-07T16:09:01+00:00</updated>
<author>
<name>Douwe Maan</name>
<email>douwe@selenight.nl</email>
</author>
<published>2017-03-07T16:08:53+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=5d9762b3b5ace3da397b83f501d103a5152f0dd3'/>
<id>5d9762b3b5ace3da397b83f501d103a5152f0dd3</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Add RuboCop cop for custom error classes</title>
<updated>2017-03-01T10:53:10+00:00</updated>
<author>
<name>Sean McGivern</name>
<email>sean@gitlab.com</email>
</author>
<published>2017-02-28T10:41:59+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=8dd097a91530e4b047c4b391f21047c7d29d310d'/>
<id>8dd097a91530e4b047c4b391f21047c7d29d310d</id>
<content type='text'>
From the Ruby style guide:

    # bad
    class FooError &lt; StandardError
    end

    # okish
    class FooError &lt; StandardError; end

    # good
    FooError = Class.new(StandardError)

This cop does that, but only for error classes (classes where the
superclass ends in 'Error'). We have empty controllers and models, which
are perfectly valid empty classes.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
From the Ruby style guide:

    # bad
    class FooError &lt; StandardError
    end

    # okish
    class FooError &lt; StandardError; end

    # good
    FooError = Class.new(StandardError)

This cop does that, but only for error classes (classes where the
superclass ends in 'Error'). We have empty controllers and models, which
are perfectly valid empty classes.
</pre>
</div>
</content>
</entry>
</feed>
