delta/gitlab/gitlab-ce.git/qa, branch frozen_string_spec_support gitlab.com: gitlab-org/gitlab-ce.git Enable Rubocop Performance/InefficientHashSearch 2019-07-24T18:47:58+00:00 Stan Hu stanhu@gmail.com 2019-07-24T18:11:18+00:00 3e001d29ccdb5a5b1ba223710525f8dc7ae844ee When used with a Hash, `.keys.include?` is bad because: 1. It performs a O(n) search instead of the efficient `.has_key?` 2. It clones all keys into separate array. Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/64975 
When used with a Hash, `.keys.include?` is bad because:

1. It performs a O(n) search instead of the efficient `.has_key?`
2. It clones all keys into separate array.

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/64975
Use a single knapsack file 2019-07-24T10:24:06+00:00 Mark Lapierre mlapierre@gitlab.com 2019-07-24T10:24:06+00:00 61de1f3596c9de9ad7bf955fc4c04f0ab1c030b2 There should be no difference between jobs in package-and-qa. Review apps should also be similar but there might be differences if the runners have different resources. 
There should be no difference between jobs in package-and-qa.

Review apps should also be similar but there might be differences
if the runners have different resources.
Merge branch 'qa-staging-61-fix-ee-project-templates-spec-ce' into 'master' 2019-07-24T10:01:28+00:00 Sanad Liaquat sliaquat@gitlab.com 2019-07-24T10:01:28+00:00 53e444fe8762c7054ab789638130345c98c1edd6 CE port of EE branch qa-staging-61-fix-ee-project-templates-spec See merge request gitlab-org/gitlab-ce!30835 
CE port of EE branch qa-staging-61-fix-ee-project-templates-spec

See merge request gitlab-org/gitlab-ce!30835
 Replace homepage visit step 2019-07-23T09:15:22+00:00 Sanad Liaquat sliaquat@gitlab.com 2019-07-23T09:15:22+00:00 50a24da200be48940af2eeba075a69d9fd1fd35b 






Temporarily remove the before block to capture screenshots
2019-07-23T06:19:40+00:00

Sanad Liaquat
sliaquat@gitlab.com

2019-07-23T06:19:40+00:00

29d447af7b60641512e24743241d93dbd8eefd7c












Ensure test is on login page
2019-07-23T06:17:35+00:00

Sanad Liaquat
sliaquat@gitlab.com

2019-07-23T06:17:35+00:00

3b9b74072f8dad089558d64f1e96937b99ee34a9












QA: Prefer `flat_map` over `map` + `flatten`
2019-07-22T22:29:14+00:00

Peter Leitzen
pleitzen@gitlab.com

2019-07-22T22:29:14+00:00

510d03fec26ac64c1ec643f492676c02f4099a56












Merge branch 'sl-qa-staging-65-fix-check-mentions-for-xss-spec' into 'master'
2019-07-22T05:20:11+00:00

Ramya Authappan
rauthappan@gitlab.com

2019-07-22T05:20:11+00:00

53547792dd7ca9e516ec756e2c0262381641d9c7

Updates check_mentions_for_xss_spec to use admin token for creating the user

Closes gitlab-org/quality/staging#65

See merge request gitlab-org/gitlab-ce!30943




Updates check_mentions_for_xss_spec to use admin token for creating the user

Closes gitlab-org/quality/staging#65

See merge request gitlab-org/gitlab-ce!30943






Standardize Page Objects use on CE Plan Tests
2019-07-20T11:45:54+00:00

Walmyr Lima
walmyr@gitlab.com

2019-07-19T19:49:37+00:00

e1644da6f08cae0158d7a159c9f48d5575baf632

This is a first iteration to address the following issue:
https://gitlab.com/gitlab-org/quality/team-tasks/issues/168

Note: depends on
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/30945





This is a first iteration to address the following issue:
https://gitlab.com/gitlab-org/quality/team-tasks/issues/168

Note: depends on
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/30945







Merge branch 'qa/refactor-e2e-test' into 'master'
2019-07-19T23:45:39+00:00

Dan Davison
ddavison@gitlab.com

2019-07-19T23:45:39+00:00

66394bd1b7c98d7a6abbeade068b8b9c1b838ddf

Refactor collapse issue comments end-to-end test

See merge request gitlab-org/gitlab-ce!30902




Refactor collapse issue comments end-to-end test

See merge request gitlab-org/gitlab-ce!30902