<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/gitlab/gitlab-ce.git/qa, branch fix/github-doc</title>
<subtitle>gitlab.com: gitlab-org/gitlab-ce.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/'/>
<entry>
<title>Move tags out to containing feature</title>
<updated>2017-10-16T11:49:54+00:00</updated>
<author>
<name>Richard Clamp</name>
<email>richardc@unixbeard.net</email>
</author>
<published>2017-10-16T11:49:54+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=d600ea75c35235fd23da8bd65a8034778112c0d2'/>
<id>d600ea75c35235fd23da8bd65a8034778112c0d2</id>
<content type='text'>
We can currently reduce the number of times we specify the tag of a
given example group by moving them hoisting them up one level to the
containing `feature`
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
We can currently reduce the number of times we specify the tag of a
given example group by moving them hoisting them up one level to the
containing `feature`
</pre>
</div>
</content>
</entry>
<entry>
<title>Cleanup a stray instance variable</title>
<updated>2017-10-16T11:26:23+00:00</updated>
<author>
<name>Richard Clamp</name>
<email>richardc@unixbeard.net</email>
</author>
<published>2017-10-16T11:26:23+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=9818d3eec69cbf27c63ee481871544f726a9decc'/>
<id>9818d3eec69cbf27c63ee481871544f726a9decc</id>
<content type='text'>
This was added as part of the previous filtering via RSpec::Config.  It
should have been removed previously as part of moving the logic to
specify the tags we wanted in Specs::Runner
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This was added as part of the previous filtering via RSpec::Config.  It
should have been removed previously as part of moving the logic to
specify the tags we wanted in Specs::Runner
</pre>
</div>
</content>
</entry>
<entry>
<title>Explicitly tag :core and :mattermost scenarios</title>
<updated>2017-10-16T09:34:59+00:00</updated>
<author>
<name>Richard Clamp</name>
<email>richardc@unixbeard.net</email>
</author>
<published>2017-10-16T09:34:59+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=da393460b690a6e394460cfd768822a3134efe7b'/>
<id>da393460b690a6e394460cfd768822a3134efe7b</id>
<content type='text'>
It's adding additional potentially confusing behaviour to derive test
tagging from the file path, as it's not immediately apparent where that
lives when considering the tests in isolation.  Instead, just explicitly
tag.

* Remove the tagging of examples based on :file_path
* Explicitly tags scenarios as :core, or :mattermost
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
It's adding additional potentially confusing behaviour to derive test
tagging from the file path, as it's not immediately apparent where that
lives when considering the tests in isolation.  Instead, just explicitly
tag.

* Remove the tagging of examples based on :file_path
* Explicitly tags scenarios as :core, or :mattermost
</pre>
</div>
</content>
</entry>
<entry>
<title>Move rspec cli handling logic into Specs::Runner</title>
<updated>2017-10-16T09:21:00+00:00</updated>
<author>
<name>Richard Clamp</name>
<email>richardc@unixbeard.net</email>
</author>
<published>2017-10-16T09:15:50+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=cbc67b485efff3f51e86131a0da5af5a38a59955'/>
<id>cbc67b485efff3f51e86131a0da5af5a38a59955</id>
<content type='text'>
Here we convert Specs::Runner#rspec to use keyword arguments[1] and pass
named parameters rather than a pre-processed array of cli switches.
This allows parameter to cli logic to live just in Specs::Runner.

[1] https://robots.thoughtbot.com/ruby-2-keyword-arguments
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Here we convert Specs::Runner#rspec to use keyword arguments[1] and pass
named parameters rather than a pre-processed array of cli switches.
This allows parameter to cli logic to live just in Specs::Runner.

[1] https://robots.thoughtbot.com/ruby-2-keyword-arguments
</pre>
</div>
</content>
</entry>
<entry>
<title>Update comment</title>
<updated>2017-10-13T15:00:20+00:00</updated>
<author>
<name>Richard Clamp</name>
<email>richardc@unixbeard.net</email>
</author>
<published>2017-10-13T15:00:20+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=c6faeb7209d3e376fb1f5ac320a8fd706b0f93d5'/>
<id>c6faeb7209d3e376fb1f5ac320a8fd706b0f93d5</id>
<content type='text'>
Entrypoint is intended as a base class, so mention that in the comment.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Entrypoint is intended as a base class, so mention that in the comment.
</pre>
</div>
</content>
</entry>
<entry>
<title>Simplify tag specification</title>
<updated>2017-10-13T14:50:11+00:00</updated>
<author>
<name>Richard Clamp</name>
<email>richardc@unixbeard.net</email>
</author>
<published>2017-10-13T14:33:18+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=2d05cf40d102e0b99d2bd03347c3b8510af6e331'/>
<id>2d05cf40d102e0b99d2bd03347c3b8510af6e331</id>
<content type='text'>
As suggested by Grzegorz, we can be more declarative in our
configuration of the tags the Entrypoint cares about

Here we add a tags method to the entrypoint class, and use that to
declare the tags an entrypoint is interested in (:core for the existing
Test::Instance, :core and :mattermost for Test::Integration::Mattermost)

We declare everything in specs/features that isn't in
specs/features/mattermost, to have the tag :core, though that clean up
better if we move the integration tests out of specs/features.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
As suggested by Grzegorz, we can be more declarative in our
configuration of the tags the Entrypoint cares about

Here we add a tags method to the entrypoint class, and use that to
declare the tags an entrypoint is interested in (:core for the existing
Test::Instance, :core and :mattermost for Test::Integration::Mattermost)

We declare everything in specs/features that isn't in
specs/features/mattermost, to have the tag :core, though that clean up
better if we move the integration tests out of specs/features.
</pre>
</div>
</content>
</entry>
<entry>
<title>Fixup company name</title>
<updated>2017-10-13T14:03:13+00:00</updated>
<author>
<name>Richard Clamp</name>
<email>richardc@unixbeard.net</email>
</author>
<published>2017-10-13T14:03:13+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=d6044a10f1d173e04fd2f4d69f6ebc1df34630be'/>
<id>d6044a10f1d173e04fd2f4d69f6ebc1df34630be</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Add Test::Integration::Mattermost</title>
<updated>2017-10-13T13:04:38+00:00</updated>
<author>
<name>Richard Clamp</name>
<email>richardc@unixbeard.net</email>
</author>
<published>2017-10-11T14:19:24+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=60e8347c7f9cbd689f014fa5d633ffa3276d9650'/>
<id>60e8347c7f9cbd689f014fa5d633ffa3276d9650</id>
<content type='text'>
Here we add a new entrypoint for the test suite,
Test::Integration::Mattermost.  It is to ensure that mattermost
integration is working when enabling the embedded mattermost of
gitlab-omnibus

It runs all the example groups from Test::Instance, in addition to any
groups tagged :mattermost

* Extracts a common entrypoint class from Test::Instance as
  Scenario::Entrypoint, and uses that as the base for Test::Instance and
  Test::Integration::Mattermost

* RSpec groups defined in `specs/features/mattermost/**_spec.rb` are
  tagged with :mattermost so they can be filtered out of the default
  run.

* Tests tagged :mattermost are filtered out by default, and are
  un-filtered by Test::Integration::Mattermost
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Here we add a new entrypoint for the test suite,
Test::Integration::Mattermost.  It is to ensure that mattermost
integration is working when enabling the embedded mattermost of
gitlab-omnibus

It runs all the example groups from Test::Instance, in addition to any
groups tagged :mattermost

* Extracts a common entrypoint class from Test::Instance as
  Scenario::Entrypoint, and uses that as the base for Test::Instance and
  Test::Integration::Mattermost

* RSpec groups defined in `specs/features/mattermost/**_spec.rb` are
  tagged with :mattermost so they can be filtered out of the default
  run.

* Tests tagged :mattermost are filtered out by default, and are
  un-filtered by Test::Integration::Mattermost
</pre>
</div>
</content>
</entry>
<entry>
<title>QA group name, use hyphens rather than underscores</title>
<updated>2017-10-10T13:25:36+00:00</updated>
<author>
<name>Richard Clamp</name>
<email>richardc@unixbeard.net</email>
</author>
<published>2017-10-10T10:54:05+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=5c15d83f7210fe625f35f65c576e8aad239b37f8'/>
<id>5c15d83f7210fe625f35f65c576e8aad239b37f8</id>
<content type='text'>
In doing some experimental testing of enabling the embedded mattermost
we found that the currently generated QA namespace was problematic in that
it used underscores when generating group names.  This is invalid for a
mattermost team name, underscores are illegal there.

Here we change to use hyphens as they are legal in team names.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
In doing some experimental testing of enabling the embedded mattermost
we found that the currently generated QA namespace was problematic in that
it used underscores when generating group names.  This is invalid for a
mattermost team name, underscores are illegal there.

Here we change to use hyphens as they are legal in team names.
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'rs-qa-sandbox-group' into 'master'</title>
<updated>2017-10-09T13:52:59+00:00</updated>
<author>
<name>Grzegorz Bizon</name>
<email>grzegorz@gitlab.com</email>
</author>
<published>2017-10-09T13:52:59+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=8ed259b0829798698d074d41116ca6b15b436f0a'/>
<id>8ed259b0829798698d074d41116ca6b15b436f0a</id>
<content type='text'>
Make use of a `gitlab-qa-sandbox` group if available

See merge request gitlab-org/gitlab-ce!14682</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Make use of a `gitlab-qa-sandbox` group if available

See merge request gitlab-org/gitlab-ce!14682</pre>
</div>
</content>
</entry>
</feed>
