<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/gitlab/gitlab-ce.git/qa, branch docs/doc-README</title>
<subtitle>gitlab.com: gitlab-org/gitlab-ce.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/'/>
<entry>
<title>Move test method to the bottom</title>
<updated>2019-04-29T11:39:59+00:00</updated>
<author>
<name>Walmyr Lima</name>
<email>walmyr@gitlab.com</email>
</author>
<published>2019-04-29T11:34:01+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=d80080b5cb6721e8d08d9cb8702c59730215467a'/>
<id>d80080b5cb6721e8d08d9cb8702c59730215467a</id>
<content type='text'>
The reason for the change is that reading the code it should be si-
milar to reading a newspaper, where high-level information is at
the top, like the title and summary of the news, and low level, or
more specific information, are at the bottom.

This improves code readability.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The reason for the change is that reading the code it should be si-
milar to reading a newspaper, where high-level information is at
the top, like the title and summary of the news, and low level, or
more specific information, are at the bottom.

This improves code readability.
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'qa-nightly-98-fix-oauth-spec' into 'master'</title>
<updated>2019-04-29T10:30:01+00:00</updated>
<author>
<name>Sanad Liaquat</name>
<email>sliaquat@gitlab.com</email>
</author>
<published>2019-04-29T10:30:01+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=08e0dbe6754711604952313b01d7159d7fa8f946'/>
<id>08e0dbe6754711604952313b01d7159d7fa8f946</id>
<content type='text'>
Fix GitHub oAuth test

Closes gitlab-org/quality/nightly#98

See merge request gitlab-org/gitlab-ce!27736</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Fix GitHub oAuth test

Closes gitlab-org/quality/nightly#98

See merge request gitlab-org/gitlab-ce!27736</pre>
</div>
</content>
</entry>
<entry>
<title>Quarantine failing test</title>
<updated>2019-04-29T06:11:28+00:00</updated>
<author>
<name>Mark Lapierre</name>
<email>mlapierre@gitlab.com</email>
</author>
<published>2019-04-29T06:11:28+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=ece771536a0bf7c55afde89afdb990a8fd380f38'/>
<id>ece771536a0bf7c55afde89afdb990a8fd380f38</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Refactor quarantine helper</title>
<updated>2019-04-26T17:16:40+00:00</updated>
<author>
<name>Walmyr Lima</name>
<email>walmyr@gitlab.com</email>
</author>
<published>2019-04-26T16:33:41+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=eaba732e91e9b0d37d47e2cccacb1960daf95145'/>
<id>eaba732e91e9b0d37d47e2cccacb1960daf95145</id>
<content type='text'>
By moving methods closer to where they are called.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
By moving methods closer to where they are called.
</pre>
</div>
</content>
</entry>
<entry>
<title>Fix GitHub OAuth e2e spec</title>
<updated>2019-04-26T13:18:42+00:00</updated>
<author>
<name>Sanad Liaquat</name>
<email>sliaquat@gitlab.com</email>
</author>
<published>2019-04-26T13:18:42+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=50faf2222404bd9d42e3367e22f547cdd45f26c8'/>
<id>50faf2222404bd9d42e3367e22f547cdd45f26c8</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Quaraintine flaky tests</title>
<updated>2019-04-26T11:53:07+00:00</updated>
<author>
<name>Sanad Liaquat</name>
<email>sliaquat@gitlab.com</email>
</author>
<published>2019-04-26T11:53:07+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=500fb97fd1e3e2df31192059d82793cbca841ce9'/>
<id>500fb97fd1e3e2df31192059d82793cbca841ce9</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Bump Nokogiri to 1.10.3</title>
<updated>2019-04-22T20:59:15+00:00</updated>
<author>
<name>Stan Hu</name>
<email>stanhu@gmail.com</email>
</author>
<published>2019-04-22T20:59:15+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=9d7bb9d8c2631a9bd781fa7793fbcfc4fdbf71b8'/>
<id>9d7bb9d8c2631a9bd781fa7793fbcfc4fdbf71b8</id>
<content type='text'>
This pulls in a fix for libxslt that addresses CVE-2019-11068:
https://github.com/sparklemotion/nokogiri/releases
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This pulls in a fix for libxslt that addresses CVE-2019-11068:
https://github.com/sparklemotion/nokogiri/releases
</pre>
</div>
</content>
</entry>
<entry>
<title>Remove unnecessary comments from login tests</title>
<updated>2019-04-22T07:11:45+00:00</updated>
<author>
<name>Walmyr</name>
<email>walmyr@gitlab.com</email>
</author>
<published>2019-04-22T07:11:45+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=2fba2adeaddd3c357242d1aec6492e43cbef5dcf'/>
<id>2fba2adeaddd3c357242d1aec6492e43cbef5dcf</id>
<content type='text'>
The comments were TODOs but there were no explanation of what
needed to be done.

Also, I think the expectation describes very well how it checks
that the user is logged in.

Finally, as Robert C. Martin said once:
"After you check in a TODO comment it turns into a DON'T DO"
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The comments were TODOs but there were no explanation of what
needed to be done.

Also, I think the expectation describes very well how it checks
that the user is logged in.

Finally, as Robert C. Martin said once:
"After you check in a TODO comment it turns into a DON'T DO"
</pre>
</div>
</content>
</entry>
<entry>
<title>Extract discussion actions into separate component</title>
<updated>2019-04-17T17:42:44+00:00</updated>
<author>
<name>Paul Gascou-Vaillancourt</name>
<email>paul.gascvail@gmail.com</email>
</author>
<published>2019-04-10T16:23:05+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=e555c8f480e6c1bb534aac60a75eb181e50f92e9'/>
<id>e555c8f480e6c1bb534aac60a75eb181e50f92e9</id>
<content type='text'>
- Created DiscussionActions component
- Updated NoteableDiscussion component accordingly
- Wrote Jest tests for DiscussionActions
- Updated Jest config to enable emojis aliases mock
- Updated qa specs to reflect changes in NoteableDiscussions
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
- Created DiscussionActions component
- Updated NoteableDiscussion component accordingly
- Wrote Jest tests for DiscussionActions
- Updated Jest config to enable emojis aliases mock
- Updated qa specs to reflect changes in NoteableDiscussions
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch '60356-add-qa-tests-for-the-performance-bar' into 'master'</title>
<updated>2019-04-17T10:09:11+00:00</updated>
<author>
<name>Sanad Liaquat</name>
<email>sliaquat@gitlab.com</email>
</author>
<published>2019-04-17T10:09:11+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=2811ace5738cae31f766aae41020ecd3332617c3'/>
<id>2811ace5738cae31f766aae41020ecd3332617c3</id>
<content type='text'>
Resolve "Add QA tests for the performance bar"

Closes #60356

See merge request gitlab-org/gitlab-ce!27305</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Resolve "Add QA tests for the performance bar"

Closes #60356

See merge request gitlab-org/gitlab-ce!27305</pre>
</div>
</content>
</entry>
</feed>
