<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/gitlab/gitlab-ce.git/lib, branch api-docs-fix</title>
<subtitle>gitlab.com: gitlab-org/gitlab-ce.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/'/>
<entry>
<title>Merge branch '24880-configurable-plaintext-emails' into 'master'</title>
<updated>2016-11-29T12:05:23+00:00</updated>
<author>
<name>Sean McGivern</name>
<email>sean@mcgivern.me.uk</email>
</author>
<published>2016-11-29T12:05:23+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=d8eee8ed73de13a5af42a5cf6de8ec1194e45483'/>
<id>d8eee8ed73de13a5af42a5cf6de8ec1194e45483</id>
<content type='text'>

Add setting to enable/disable HTML emails

Closes #24880

See merge request !7749</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>

Add setting to enable/disable HTML emails

Closes #24880

See merge request !7749</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'zj-issue-search-slash-command' into 'master'</title>
<updated>2016-11-29T11:04:17+00:00</updated>
<author>
<name>Kamil Trzciński</name>
<email>ayufan@ayufan.eu</email>
</author>
<published>2016-11-29T11:04:17+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=35212deb062dda60220a9a0929c26196c1c598b5'/>
<id>35212deb062dda60220a9a0929c26196c1c598b5</id>
<content type='text'>

Add issue search slash command

See merge request !7752</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>

Add issue search slash command

See merge request !7752</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'jej-use-issuable-finder-instead-of-access-check' into 'security'</title>
<updated>2016-11-29T00:26:23+00:00</updated>
<author>
<name>Douwe Maan</name>
<email>douwe@gitlab.com</email>
</author>
<published>2016-11-22T10:25:04+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=3bf34face4cacf07ca973705c261369b1f596626'/>
<id>3bf34face4cacf07ca973705c261369b1f596626</id>
<content type='text'>

Replace issue access checks with use of IssuableFinder

Split from !2024 to partially solve https://gitlab.com/gitlab-org/gitlab-ce/issues/23867

## Which fixes are in this MR?

:warning: - Potentially untested  
:bomb: - No test coverage  
:traffic_light: - Test coverage of some sort exists (a test failed when error raised)  
:vertical_traffic_light: - Test coverage of return value (a test failed when nil used)  
:white_check_mark: - Permissions check tested

### Issue lookup with access check

Using `visible_to_user` likely makes these security issues too. See [Code smells](#code-smells).

- [x] :vertical_traffic_light: app/finders/notes_finder.rb:15 [`visible_to_user`]
- [x] :traffic_light: app/views/layouts/nav/_project.html.haml:73 [`visible_to_user`] [`.count`]
- [x] :white_check_mark: app/services/merge_requests/build_service.rb:84 [`issue.try(:confidential?)`]
- [x] :white_check_mark: lib/api/issues.rb:112 [`visible_to_user`]
  - CHANGELOG: Prevented API returning issues set to 'Only team members' to everyone
- [x] :white_check_mark: lib/api/helpers.rb:126 [`can?(current_user, :read_issue, issue)`] Maybe here too?
- [x] :white_check_mark: lib/gitlab/search_results.rb:53 [`visible_to_user`]

### Previous discussions
- [ ] https://dev.gitlab.org/gitlab/gitlabhq/merge_requests/2024/diffs#b2ff264eddf9819d7693c14ae213d941494fe2b3_128_126
- [ ] https://dev.gitlab.org/gitlab/gitlabhq/merge_requests/2024/diffs#7b6375270d22f880bdcb085e47b519b426a5c6c7_87_87

See merge request !2031</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>

Replace issue access checks with use of IssuableFinder

Split from !2024 to partially solve https://gitlab.com/gitlab-org/gitlab-ce/issues/23867

## Which fixes are in this MR?

:warning: - Potentially untested  
:bomb: - No test coverage  
:traffic_light: - Test coverage of some sort exists (a test failed when error raised)  
:vertical_traffic_light: - Test coverage of return value (a test failed when nil used)  
:white_check_mark: - Permissions check tested

### Issue lookup with access check

Using `visible_to_user` likely makes these security issues too. See [Code smells](#code-smells).

- [x] :vertical_traffic_light: app/finders/notes_finder.rb:15 [`visible_to_user`]
- [x] :traffic_light: app/views/layouts/nav/_project.html.haml:73 [`visible_to_user`] [`.count`]
- [x] :white_check_mark: app/services/merge_requests/build_service.rb:84 [`issue.try(:confidential?)`]
- [x] :white_check_mark: lib/api/issues.rb:112 [`visible_to_user`]
  - CHANGELOG: Prevented API returning issues set to 'Only team members' to everyone
- [x] :white_check_mark: lib/api/helpers.rb:126 [`can?(current_user, :read_issue, issue)`] Maybe here too?
- [x] :white_check_mark: lib/gitlab/search_results.rb:53 [`visible_to_user`]

### Previous discussions
- [ ] https://dev.gitlab.org/gitlab/gitlabhq/merge_requests/2024/diffs#b2ff264eddf9819d7693c14ae213d941494fe2b3_128_126
- [ ] https://dev.gitlab.org/gitlab/gitlabhq/merge_requests/2024/diffs#7b6375270d22f880bdcb085e47b519b426a5c6c7_87_87

See merge request !2031</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'zj-fix-label-creation-non-members' into 'security'</title>
<updated>2016-11-29T00:24:19+00:00</updated>
<author>
<name>Douwe Maan</name>
<email>douwe@gitlab.com</email>
</author>
<published>2016-11-10T10:23:44+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=3d7704ae5f62446b8b399c796c64d1f527666376'/>
<id>3d7704ae5f62446b8b399c796c64d1f527666376</id>
<content type='text'>
Fix label creation non members

Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/23416

See merge request !2006
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Fix label creation non members

Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/23416

See merge request !2006
</pre>
</div>
</content>
</entry>
<entry>
<title>Add new configuration setting to enable/disable HTML emails.</title>
<updated>2016-11-28T22:00:03+00:00</updated>
<author>
<name>Ruben Davila</name>
<email>rdavila84@gmail.com</email>
</author>
<published>2016-11-28T22:00:03+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=b62e2bedbfa49aacfc4847049aa589f045af15ce'/>
<id>b62e2bedbfa49aacfc4847049aa589f045af15ce</id>
<content type='text'>
This new global setting will allow admins to specify if HTML emails should be sent or not,
this is basically useful when system administrators want to save some disk space by avoiding
emails in HTML format and using only the Plain Text version.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This new global setting will allow admins to specify if HTML emails should be sent or not,
this is basically useful when system administrators want to save some disk space by avoiding
emails in HTML format and using only the Plain Text version.
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'refresh-authorizations-with-lease' into 'master'</title>
<updated>2016-11-28T03:35:37+00:00</updated>
<author>
<name>Douwe Maan</name>
<email>douwe@gitlab.com</email>
</author>
<published>2016-11-28T03:35:37+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=d2813832615c6baf1f176c39b260b66a702d3e70'/>
<id>d2813832615c6baf1f176c39b260b66a702d3e70</id>
<content type='text'>

Refresh project authorizations using a Redis lease

This MR changes `User#refresh_authorized_projects` so it uses a Redis lease instead of relying on serializable transactions. See the commit message(s) for more details.

See merge request !7733</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>

Refresh project authorizations using a Redis lease

This MR changes `User#refresh_authorized_projects` so it uses a Redis lease instead of relying on serializable transactions. See the commit message(s) for more details.

See merge request !7733</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'zj-expose-coverage-pipelines' into 'master'</title>
<updated>2016-11-25T16:51:53+00:00</updated>
<author>
<name>Rémy Coutable</name>
<email>remy@rymai.me</email>
</author>
<published>2016-11-25T16:51:53+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=e17328986abcaabff47edb6292ede7546f607bb2'/>
<id>e17328986abcaabff47edb6292ede7546f607bb2</id>
<content type='text'>

Expose coverage on GET pipelines/:id

Closes gitlab-org/gitlab-ce#24801

See merge request !7670</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>

Expose coverage on GET pipelines/:id

Closes gitlab-org/gitlab-ce#24801

See merge request !7670</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'timeout-merge-request-for-binary-file' into 'master'</title>
<updated>2016-11-25T16:19:03+00:00</updated>
<author>
<name>Yorick Peterse</name>
<email>yorickpeterse@gmail.com</email>
</author>
<published>2016-11-25T16:19:03+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=746b6ec82d1ed29a679fe4dc6a93b2d0228e9d34'/>
<id>746b6ec82d1ed29a679fe4dc6a93b2d0228e9d34</id>
<content type='text'>

Fix: Timeout creating and viewing merge request for binary file

See merge request !7713</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>

Fix: Timeout creating and viewing merge request for binary file

See merge request !7713</pre>
</div>
</content>
</entry>
<entry>
<title>Expose coverage on GET pipelines/:id</title>
<updated>2016-11-25T14:49:59+00:00</updated>
<author>
<name>Z.J. van de Weg</name>
<email>git@zjvandeweg.nl</email>
</author>
<published>2016-11-22T16:28:58+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=40e8185b64a04f719c85a793d0fdd5438a129975'/>
<id>40e8185b64a04f719c85a793d0fdd5438a129975</id>
<content type='text'>
The coverage wasn't exposed yet, now it is but only for detailed
requests to save queries on the database.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The coverage wasn't exposed yet, now it is but only for detailed
requests to save queries on the database.
</pre>
</div>
</content>
</entry>
<entry>
<title>Add issue search slash command</title>
<updated>2016-11-25T14:41:28+00:00</updated>
<author>
<name>Z.J. van de Weg</name>
<email>git@zjvandeweg.nl</email>
</author>
<published>2016-11-25T14:41:28+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=6a08de7386fd41c9bbe27c32338328c6e6b40027'/>
<id>6a08de7386fd41c9bbe27c32338328c6e6b40027</id>
<content type='text'>
One of many requested in: gitlab-org/gitlab-ce#24768
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
One of many requested in: gitlab-org/gitlab-ce#24768
</pre>
</div>
</content>
</entry>
</feed>
