delta/gitlab/gitlab-ce.git/lib/tasks, branch diff-scroll-point gitlab.com: gitlab-org/gitlab-ce.git Properly quote table name in Rake task for MySQL and PostgreSQL compatibility 2016-06-09T22:06:19+00:00 Stan Hu stanhu@gmail.com 2016-06-09T21:51:57+00:00 bf92ea687f7085d8ea0168f47507d0bc459b6d36 !4318 broke the gitlab:db:drop_tables functionality for PostgreSQL. Closes #15259 
!4318 broke the gitlab:db:drop_tables functionality for PostgreSQL.

Closes #15259
Merge branch 'fix_issue_15259' into 'master' 2016-06-09T21:44:10+00:00 Stan Hu stanhu@gmail.com 2016-06-09T21:44:10+00:00 4fbb284cfd8a23ed3b754e0f168752c1ab211a7c Fix bug with SQL syntax error during backup restoration ## What does this MR do? It properly escapes the table name in the `DROP TABLE IF EXISTS ...` statement used during restore of a backup. ## Are there points in the code the reviewer needs to double check? Please check compatibility with PostgreSQL ## Why was this MR needed? Fix an issue with backups can not be restored if MySQL is used as database for GitLab. ## What are the relevant issue numbers? #15259 ## Screenshots (if relevant) - See merge request !4318 

Fix bug with SQL syntax error during backup restoration

## What does this MR do?
It properly escapes the table name in the `DROP TABLE IF EXISTS ...` statement used during restore of a backup.

## Are there points in the code the reviewer needs to double check?
Please check compatibility with PostgreSQL

## Why was this MR needed?
Fix an issue with backups can not be restored if MySQL is used as database for GitLab.

## What are the relevant issue numbers?
#15259 

## Screenshots (if relevant)
-

See merge request !4318
 Fix missed colorize methods. 2016-06-06T21:32:36+00:00 Connor Shea connor.james.shea@gmail.com 2016-06-06T21:17:42+00:00 efb7da68e686e501abcfb8b0aea241c7b625fac5 






Replace colorize gem with rainbow.
2016-06-03T16:37:09+00:00

Connor Shea
connor.james.shea@gmail.com

2016-06-01T22:37:15+00:00

903946c78a0f73e5cbdfce7b93d31c4d1bd045cd

Colorize is a gem licensed under the GPLv2, so we can’t use it in GitLab without relicensing GitLab under the terms of the GPL. Rainbow is licensed under the MIT license and does the exact same thing as Colorize, so Rainbow was added in place of Colorize.

The syntax is slightly different for Rainbow vs. Colorize, and was updated in accordance.

The gem is still a dependency of Spinach, so it’s included in the development/test environments, but won’t be packaged with the actual product, and therefore doesn’t require we relicense the product.

An attempt at relicensing Colorize was made, but didn’t succeed as the library owner never responded.

Rainbow library: https://github.com/sickill/rainbow
Relevant issue regarding licensing in GitLab's gems: https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/3775





Colorize is a gem licensed under the GPLv2, so we can’t use it in GitLab without relicensing GitLab under the terms of the GPL. Rainbow is licensed under the MIT license and does the exact same thing as Colorize, so Rainbow was added in place of Colorize.

The syntax is slightly different for Rainbow vs. Colorize, and was updated in accordance.

The gem is still a dependency of Spinach, so it’s included in the development/test environments, but won’t be packaged with the actual product, and therefore doesn’t require we relicense the product.

An attempt at relicensing Colorize was made, but didn’t succeed as the library owner never responded.

Rainbow library: https://github.com/sickill/rainbow
Relevant issue regarding licensing in GitLab's gems: https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/3775







Fix bug with SQL syntax error during backup restoration
2016-05-27T11:35:12+00:00

Daniel Beyer
ymc-dabe@vcs.ymc.ch

2016-05-27T11:35:12+00:00

97aecdeadeb85383a793135f92677daf99c6183e

closes #15259




closes #15259






Switch the gitlab:db:configure task to use tables.any? instead of looking specifically for the schema_migrations table
2016-05-25T17:47:09+00:00

DJ Mountney
david@twkie.net

2016-05-15T14:59:49+00:00

1a7326ba9ae4c7db0d03df0c114b84a22ab83ced












Update hash syntax and add changelog for the gitlab:db:configure rake task
2016-05-25T17:44:22+00:00

DJ Mountney
david@twkie.net

2016-05-06T17:08:05+00:00

24632d215029f8a03cf6742363d42dbf63fa92f2












Add a gitlab:db:configure rake task to handle conditionally seeding or migrating the database.
2016-05-25T17:44:22+00:00

DJ Mountney
david@twkie.net

2016-05-05T23:06:34+00:00

c6e7d826b271a0fc51ed7eb7772c1820c720f1ff












Merge branch 'fix-registry-backups' into 'master'

2016-05-25T09:28:22+00:00

Douwe Maan
douwe@gitlab.com

2016-05-25T09:28:22+00:00

019a3c781efd75a8ce44297519a724e322cfde96


Fix backups if registry is disabled

Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/17749

See merge request !4263





Fix backups if registry is disabled

Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/17749

See merge request !4263






Add rubocop-rspec
2016-05-23T19:59:32+00:00

Robert Speicher
rspeicher@gmail.com

2016-05-21T23:27:15+00:00

43d9e06b68d82588ca582f43971cae040b04674f

Almost all cops are starting as disabled until we can fix their
violations.





Almost all cops are starting as disabled until we can fix their
violations.