<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/gitlab/gitlab-ce.git/lib/banzai, branch commit-message-contribution</title>
<subtitle>gitlab.com: gitlab-org/gitlab-ce.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/'/>
<entry>
<title>Instrument Banzai code</title>
<updated>2016-04-11T15:43:12+00:00</updated>
<author>
<name>Yorick Peterse</name>
<email>yorickpeterse@gmail.com</email>
</author>
<published>2016-04-11T15:42:12+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=935f913165b91467a70d9ba2b0ea29fad467db9d'/>
<id>935f913165b91467a70d9ba2b0ea29fad467db9d</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'patch/fix-markdown-preview-wikis' into 'master'</title>
<updated>2016-04-07T00:17:21+00:00</updated>
<author>
<name>Robert Speicher</name>
<email>robert@gitlab.com</email>
</author>
<published>2016-04-07T00:17:21+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=730625f022b1c3b9394cf944f04968a29ac8dc36'/>
<id>730625f022b1c3b9394cf944f04968a29ac8dc36</id>
<content type='text'>

Wiki preview URL converting problem [via Markdown]

Current implementation when rendering the preview, thinks relative links are for project repository files.

We are creating a new preview route that will define correct context data to render for wikis instead.

Fixes #2380, #1184

See merge request !3461</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>

Wiki preview URL converting problem [via Markdown]

Current implementation when rendering the preview, thinks relative links are for project repository files.

We are creating a new preview route that will define correct context data to render for wikis instead.

Fixes #2380, #1184

See merge request !3461</pre>
</div>
</content>
</entry>
<entry>
<title>little refactor and improvements on specs</title>
<updated>2016-04-06T23:09:15+00:00</updated>
<author>
<name>Gabriel Mazetto</name>
<email>gabriel@gitlab.com</email>
</author>
<published>2016-04-06T23:09:15+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=1575a95b65d4cad91f775ae260b8828cdf303462'/>
<id>1575a95b65d4cad91f775ae260b8828cdf303462</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Fix header link rendering when containing numbers</title>
<updated>2016-04-06T12:24:30+00:00</updated>
<author>
<name>Yorick Peterse</name>
<email>yorickpeterse@gmail.com</email>
</author>
<published>2016-04-06T12:24:30+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=507cbca339444eabdfdd5d6dff1237bd00ee636a'/>
<id>507cbca339444eabdfdd5d6dff1237bd00ee636a</id>
<content type='text'>
This fixes the problem where Markdown such as:

    ### 31st

Would get rendered as a link tag pointing to issue number 31 inside a
header tag.

See gitlab-org/gitlab-ce#14936 for more information.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This fixes the problem where Markdown such as:

    ### 31st

Would get rendered as a link tag pointing to issue number 31 inside a
header tag.

See gitlab-org/gitlab-ce#14936 for more information.
</pre>
</div>
</content>
</entry>
<entry>
<title>Ensure correct filter order to validate with our markdown spec</title>
<updated>2016-04-06T06:30:56+00:00</updated>
<author>
<name>Gabriel Mazetto</name>
<email>gabriel@gitlab.com</email>
</author>
<published>2016-04-01T18:03:39+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=207b7218aa4394dc24c68041eade04474ff41537'/>
<id>207b7218aa4394dc24c68041eade04474ff41537</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Fix a few edited references from WikiLinkFilter and specs</title>
<updated>2016-04-06T06:13:46+00:00</updated>
<author>
<name>Gabriel Mazetto</name>
<email>gabriel@gitlab.com</email>
</author>
<published>2016-04-01T08:22:22+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=22055e10580ae93c2cb87956eefba0a06e9b50d0'/>
<id>22055e10580ae93c2cb87956eefba0a06e9b50d0</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Fixed WikiPipeline and specs</title>
<updated>2016-04-06T06:12:39+00:00</updated>
<author>
<name>Gabriel Mazetto</name>
<email>gabriel@gitlab.com</email>
</author>
<published>2016-04-01T07:03:08+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=61fe0a23977749b0a5dba41ca26101b4a03de720'/>
<id>61fe0a23977749b0a5dba41ca26101b4a03de720</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Wrap images in discussions and wikis with a link to the image source using ImageLinkFilter.</title>
<updated>2016-04-05T01:44:07+00:00</updated>
<author>
<name>connorshea</name>
<email>connor.james.shea@gmail.com</email>
</author>
<published>2016-03-30T22:03:49+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=b9abf938edf52e762d320b1eb8732155e23d7b72'/>
<id>b9abf938edf52e762d320b1eb8732155e23d7b72</id>
<content type='text'>
Resolves #14411.

See merge request !3464
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Resolves #14411.

See merge request !3464
</pre>
</div>
</content>
</entry>
<entry>
<title>Cleaned up caching in AbstractReferenceFilter</title>
<updated>2016-04-04T09:39:11+00:00</updated>
<author>
<name>Yorick Peterse</name>
<email>yorickpeterse@gmail.com</email>
</author>
<published>2016-04-04T09:39:11+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=915fd3f910921bc97abdda5f2ae63093c11533fd'/>
<id>915fd3f910921bc97abdda5f2ae63093c11533fd</id>
<content type='text'>
Cleaning this up any further is a bit tricky as the caches in question
should only be evaluated if RequestStore is actually enabled.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Cleaning this up any further is a bit tricky as the caches in question
should only be evaluated if RequestStore is actually enabled.
</pre>
</div>
</content>
</entry>
<entry>
<title>Cache default_issues_tracker? in Banzai</title>
<updated>2016-04-04T08:44:35+00:00</updated>
<author>
<name>Yorick Peterse</name>
<email>yorickpeterse@gmail.com</email>
</author>
<published>2016-03-30T12:04:28+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=7f0fd73eeb983782bac26bb983ec8ea52194b80a'/>
<id>7f0fd73eeb983782bac26bb983ec8ea52194b80a</id>
<content type='text'>
Every object processed by ExternalIssueReferenceFilter can return a
different Project instance when calling "project". For example, every
note processed will have it's own associated Project. If we were to
cache Project#default_issues_tracker? on Project level this would have
no impact on Markdown rendering timings as the cache would have to be
built for every Project instance without it ever being re-used.

To work around this we cache Project#default_issues_tracker? in
Banzai::Filter::ExternalIssueReferenceFilter using the project's _id_
instead of the whole object. This setup allows re-using of the cached
data even when the Project instances used are different, as long as the
actual project IDs are the same.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Every object processed by ExternalIssueReferenceFilter can return a
different Project instance when calling "project". For example, every
note processed will have it's own associated Project. If we were to
cache Project#default_issues_tracker? on Project level this would have
no impact on Markdown rendering timings as the cache would have to be
built for every Project instance without it ever being re-used.

To work around this we cache Project#default_issues_tracker? in
Banzai::Filter::ExternalIssueReferenceFilter using the project's _id_
instead of the whole object. This setup allows re-using of the cached
data even when the Project instances used are different, as long as the
actual project IDs are the same.
</pre>
</div>
</content>
</entry>
</feed>
